New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692275 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

in fullscreen mode, top bar disappears even if mouse is over addressbar/buttons/bookmarks

Reported by clarione...@gmail.com, Feb 14 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce the problem:
1. Enter Fullscreen mode on Mac (I'm on Sierra 10.12.3)
2. Move mouse to top of screen to make tabs/address/bookmarks visible
3. move down to try to click address, buttons (e.g. back), or bookmark bar icons
4. whole top bar disappears very quickly

What is the expected behavior?
The top bar should persist until i move below it

What went wrong?
The top bar disappears even though my mouse is still over it

Did this work before? Yes not sure

Chrome version: 56.0.2924.87  Channel: stable
OS Version: OS X 10.12.3
Flash Version: Shockwave Flash 24.0 r0

The top bar does NOT disappear if the mouse is over the Tab bar; but it does if you're over address, buttons, or bookmarks bar
 
Labels: Needs-Bisect Needs-Triage-M56
Cc: rbasuvula@chromium.org
Labels: -Needs-Bisect -Needs-Triage-M56 M-58
Status: Untriaged (was: Unconfirmed)
Tested the issue on chrome Stable #56.0.2924.87, Canary 58.0.3012.0 in Mac 10.12.2 and was able to reproduce the issue.

This is a Non-Regression issue since seeing this from M30 #30.0.1549.0, Making the status to Untriaged so that the issue would get addressed.

Note :Mac specific issue.

Thank you.

Comment 3 by meh...@chromium.org, Feb 15 2017

Cc: spqc...@chromium.org
Components: -UI UI>Browser>FullScreen
Somehow related to  issue 418413 . 

Comment 4 by a...@chromium.org, Feb 28 2017

Owner: erikc...@chromium.org
Erik, can you take a look? You were working in this area.

Comment 5 by a...@chromium.org, Feb 28 2017

Status: Assigned (was: Untriaged)
Cc: -spqc...@chromium.org
Owner: spqc...@chromium.org
spqchan is a better owner.
I'll look into this. There's a threshold below the toolbar that if the mouse moves past
it, the toolbar will disappear. It looks like the bookmarks bar is reaching past the threshold which is causing this issue
Labels: -Pri-2 -M-58 M-60 Pri-1
Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50aafec7a5ed2822f6dd50acfd2c2c4a79e01fce

commit 50aafec7a5ed2822f6dd50acfd2c2c4a79e01fce
Author: spqchan <spqchan@chromium.org>
Date: Thu May 11 18:36:38 2017

[Mac] Fullscreen Toolbar Fixes

- Increased the mouse threshold to hide the toolbar
-The toolbar will now hide when the mouse is over 50px below it

- In FullscreenMenubarTracker, the toolbar layout and menubarFraction
 needs to be updated before the tracker attempt to animate the toolbar
 out.

BUG= 692275 

Review-Url: https://codereview.chromium.org/2875673004
Cr-Commit-Position: refs/heads/master@{#471016}

[modify] https://crrev.com/50aafec7a5ed2822f6dd50acfd2c2c4a79e01fce/chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm
[modify] https://crrev.com/50aafec7a5ed2822f6dd50acfd2c2c4a79e01fce/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm

Status: Fixed (was: Started)
Hi spqchan@: Have you fixed here an issue regarding the deactivated "Always Show Toolbar in Fullscreen" option? 

See  Issue 706634 
Thanks. Sorry, there was a misunderstanding from my side.

I thought you fixed the bug from  issue 418413  here as well.

But I noticed now, that you fixed an issue with the whole Toolbar animation when „Always Show Toolbar in Fullscreen“ is unchecked. Sorry for the confusing.


No worries, thanks for letting me know about that issue. I'll close it
Cc: spqc...@chromium.org rsesek@chromium.org erikc...@chromium.org
 Issue 418413  has been merged into this issue.

Comment 17 by ajha@chromium.org, May 16 2017

Labels: TE-Verified-M60 TE-Verified-60.0.3100.0
Verified the fix on the latest canary(60.0.3100.0) on Mac OS 10.12.4 and this is working as intended when compared to build without the fix. Attached is the screen-cast of the behavior seen on the latest canary. Adding the verified label.
692275.mp4
530 KB View Download

Sign in to add a comment