metrics daemon division by zero |
|||||||||
Issue descriptionOne of the top crashes is for metrics_daemon here: 0xb6ee2453 (metrics_daemon -metrics_daemon.cc:868 ) MetricsDaemon::ReportZram(base::FilePath const&) the signature is: raise-97580e1f sample crash: https://crash.corp.google.com/browse?q=product.name%3D%27ChromeOS%27%20AND%20product.version%20%3D%20%279202.12.0%27%20and%20%20stable_signature%3D%27raise-97580e1f%27%20AND%20ReportID%3D%27531d0e3580000000%27&ignore_case=false&enable_rewrite=false&omit_field_name=&omit_field_value=&omit_field_opt=&stbtiq=&reportid=&index=0
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f542bb4a0513a44ec70e9c03847b25ed88171cd3 commit f542bb4a0513a44ec70e9c03847b25ed88171cd3 Author: Luigi Semenzato <semenzato@chromium.org> Date: Wed Feb 15 18:47:31 2017 metrics: metrics_daemon: avoid division by zero Don't send ratio samples when the ratio doesn't exist. BUG= chromium:692271 TEST=none Change-Id: I8c37c460b4d0953aa9b1cd0a6c20d6082bb2d05b Reviewed-on: https://chromium-review.googlesource.com/442628 Commit-Ready: Luigi Semenzato <semenzato@chromium.org> Tested-by: Luigi Semenzato <semenzato@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f542bb4a0513a44ec70e9c03847b25ed88171cd3/metrics/metrics_daemon.cc
,
Mar 31 2017
,
Mar 31 2017
Hi Josafat, do you know who might be able to approve this merge request as well as the one in issue 686928 ? Thanks!
,
Apr 1 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 3 2017
My mistake---this was already merged.
,
Apr 5 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4b34da9e49c4e8ee6752dc468d7a960f940ec3e7 commit 4b34da9e49c4e8ee6752dc468d7a960f940ec3e7 Author: Luigi Semenzato <semenzato@chromium.org> Date: Wed Apr 05 15:34:15 2017 metrics: metrics_daemon: avoid division by zero Don't send ratio samples when the ratio doesn't exist. BUG= chromium:692271 TEST=none Change-Id: I8c37c460b4d0953aa9b1cd0a6c20d6082bb2d05b Reviewed-on: https://chromium-review.googlesource.com/442628 Commit-Ready: Luigi Semenzato <semenzato@chromium.org> Tested-by: Luigi Semenzato <semenzato@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit f542bb4a0513a44ec70e9c03847b25ed88171cd3) Reviewed-on: https://chromium-review.googlesource.com/468530 Reviewed-by: Luigi Semenzato <semenzato@chromium.org> Commit-Queue: Luigi Semenzato <semenzato@chromium.org> [modify] https://crrev.com/4b34da9e49c4e8ee6752dc468d7a960f940ec3e7/metrics/metrics_daemon.cc
,
Apr 5 2017
To recapitulate: no need to merge to 58 (already there) and just merged to 57.
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by semenzato@chromium.org
, Feb 15 2017