New issue
Advanced search Search tips

Issue 692269 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 692268



Sign in to add a comment

kitchen: add logdog stream tags

Project Member Reported by no...@chromium.org, Feb 14 2017

Issue description

kitchen: add the following tags to logdog streams, if possible:
- swarming task id
- swarming run id
- swarming host
- buildbucket build id. Requires  bug 692268 
- buildbucket bucket

 

Comment 1 by no...@chromium.org, Feb 23 2017

Labels: -Pri-2 luci Pri-1

Comment 2 by estaab@chromium.org, Feb 24 2017

Components: Infra>Platform>LogDog
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/41b090cb93a0e3410f13b8e57df31ba5e0a99112

commit 41b090cb93a0e3410f13b8e57df31ba5e0a99112
Author: Dan Jacques <dnj@chromium.org>
Date: Fri Feb 24 15:48:32 2017

Kitchen: Add Swarming/BuildBot LogDog tags.

Automatically add Swarming/BuildBot-specific tags to generated LogDog
streams.

BUG= chromium:692269 
TEST=None

Change-Id: Iee7d81dadc824eed32d9de9d51fa1a835d18885b
Reviewed-on: https://chromium-review.googlesource.com/446692
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/41b090cb93a0e3410f13b8e57df31ba5e0a99112/go/src/infra/tools/kitchen/cook_mode.go
[modify] https://crrev.com/41b090cb93a0e3410f13b8e57df31ba5e0a99112/go/src/infra/tools/kitchen/cook_logdog.go

Comment 4 by d...@chromium.org, Feb 24 2017

Owner: no...@chromium.org
This should be working for Kitchen at ToT. WRT BuildBucket ID/bucket, that's something that will have to be supplied by the BuildBucket template, since there's no canonical way to know that information from Kitchen's perspective.

Do this by adding "-logdog-tag key=value" flags to the SwarmBucket template invocation. Passing to nodir@ to verify that this is acceptable and implement.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6487a513377c50f9a71361084e27278a92a92838

commit 6487a513377c50f9a71361084e27278a92a92838
Author: Nodir Turakulov <nodir@chromium.org>
Date: Thu Mar 30 01:22:28 2017

buildbucket: add build_id template parameter

It will be used in a logdog stream tag.

R=dnj@chromium.org
BUG= 692269 

Change-Id: Ia45f5f4ad0dfe4f89307c8ceabd0cdc7e164caec
Reviewed-on: https://chromium-review.googlesource.com/461206
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/6487a513377c50f9a71361084e27278a92a92838/appengine/cr-buildbucket/swarming/swarming.py

Comment 6 by no...@chromium.org, Mar 23 2018

Status: Fixed (was: Assigned)

Sign in to add a comment