New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692265 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Update manual review statement on merge request

Project Member Reported by cma...@chromium.org, Feb 14 2017

Issue description

We get this statement by sheriffbot@chromium.org when we are more than 2 weeks ahead of AppStore submission. 

"This bug requires manual review: Less than 2 weeks to go before AppStore submit on M57 Please contact the milestone owner if you have questions."

This statement is not always correct and should be updated to reflect the exact time we are  away from AppStore submission.
 

Comment 1 by dimu@google.com, Feb 14 2017

Yeah, the current script only tags for manual review if it is less 33 days away from stable date, which is just an estimate.

Do we have a schedule for AppStore submission somewhere? 

Comment 2 by cma...@chromium.org, Feb 14 2017

Yes, we use the same schedule with the rest of Chrome for the release date, but we submit to Appstore 3 days before that release date. I guess your script can just do the calculations :)

Comment 3 by dimu@google.com, Feb 14 2017

got it, so should we still keep the 2 weeks? I would be happy to update the manual review rule from 33 days to 17 days(2weeks + 3days). Please let me know if 17 days works.

Comment 4 by cma...@chromium.org, Feb 15 2017

33 days is fine but the statement should reflect that. So instead of saying we are 2 weeks to go before Appstore submit, it can say we are 4 weeks to go or something else. Anything that will be more accurate.

Sign in to add a comment