New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692261 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocked on:
issue 650113



Sign in to add a comment

Very old frame emitted from tab capture after resume()

Project Member Reported by m...@chromium.org, Feb 14 2017

Issue description

For various use cases, the MediaStreams returned by the tab capture API can be suspended. Later, when they are resumed, tab capture *does* emit a "refresh frame." However, the content of this refresh frame is old: It is the last frame before capture was suspended, which may be a very long time ago. If the tab content has changed, a full frame capture must be performed.
 

Comment 1 by m...@chromium.org, Feb 14 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7239bff66dcb73541208ba0924470f5e74dad72a

commit 7239bff66dcb73541208ba0924470f5e74dad72a
Author: miu <miu@chromium.org>
Date: Wed Feb 15 05:57:18 2017

Tab/Desktop capture: Fix for super-old frame after resume.

After a Resume() operation, set a flag that will force the next frame
refresh operation to be of the "active" kind (i.e., actually execute a
capture of the current screen) rather than the "passive" kind (i.e.,
pull the last frame back out of the buffer pool). This will ensure that,
since the screen may have changed during the Suspend(), the next frame
emitted contains the most up-to-date content.

BUG= 692261 , 650113 

Review-Url: https://codereview.chromium.org/2692393002
Cr-Commit-Position: refs/heads/master@{#450575}

[modify] https://crrev.com/7239bff66dcb73541208ba0924470f5e74dad72a/media/capture/content/screen_capture_device_core.cc
[modify] https://crrev.com/7239bff66dcb73541208ba0924470f5e74dad72a/media/capture/content/screen_capture_device_core.h

Comment 3 by m...@chromium.org, Feb 15 2017

Status: Fixed (was: Started)

Sign in to add a comment