Milo: load annotations from logdog on swarming build page |
|||||||
Issue description
In Milo swarming task page:
1. load tash result by task id
2. if it does NOT have tag "log_location:logdog_annotations", do it what Milo does now.
Otherwise:
3. if logdog_host, logdog_prefix or logdog_annotation_stream tags are not present, render the build as invalid. Tasks with "log_location:logdog_annotations" tag MUST HAVE these tags.
4. Load the task result, read the runid.
5. If present, replace the ${swarming_run_id} substring in logdog_prefix with the value of runid.
6. Load the annotation stream and render it. Render logdog links to step logs too.
,
Feb 14 2017
,
Feb 14 2017
,
Feb 15 2017
Ryan, is this something you can take? Do you agree with this approach?
,
Feb 15 2017
Approach lgtm, but I do want to avoid milo linking out of the luci-milo domain for logs.
,
Feb 15 2017
good idea. do you want milo's step log handler to redirect to logdog stream viewer then?
,
Feb 15 2017
Talked with Ryan, I'll do this one too.
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/0118a73d6c8f7cb94001978d89424a82b0b37d37 commit 0118a73d6c8f7cb94001978d89424a82b0b37d37 Author: dnj <dnj@chromium.org> Date: Thu Feb 16 03:04:02 2017 milo: Enable Swarming LogDog log loading. Enable Swarming builds to load directly from Milo annotation streams when the build contains a LogDog "log_location" tag. To do this, Swarming parses the tags when it fetches a task result. If the tags include a "log_location" tag, and that location is LogDog, it will terminate any log fetching (if applicable) and, rather than parse Swarming logs through Annotee, load the annotation protobuf instead. To enable this, we introduce the concept of a LogDog URL: logdog://host/project/prefix/+/name This URL is handled in the LogDog "types" package. BUG= chromium:692220 TEST=unit Review-Url: https://codereview.chromium.org/2695383002 [add] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/logdog/common/types/streamaddr.go [add] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/logdog/common/types/streamaddr_test.go [modify] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/logdog/common/types/streamname_test.go [modify] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/buildbot/buildinfo.go [add] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-running-logdog.html [add] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-running-logdog.html [modify] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/logdog/build.go [modify] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/logdog/http.go [modify] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/swarming/build.go [modify] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/swarming/build_test.go [modify] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/swarming/buildinfo.go [modify] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/swarming/buildinfo_test.go [add] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/swarming/expectations/build-running-logdog.json [modify] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/swarming/html.go [modify] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/swarming/html_data.go [add] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/swarming/testdata/build-running-logdog [add] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/swarming/testdata/build-running-logdog.pb.txt [add] https://crrev.com/0118a73d6c8f7cb94001978d89424a82b0b37d37/milo/appengine/swarming/testdata/build-running-logdog.swarm
,
Feb 18 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by no...@chromium.org
, Feb 14 2017