kitchen: add flags for logdog prefix and annotation stream |
||||
Issue description
in kitchen add flags:
- "logdog-prefix". It may contain "${swarming_run_id}" substring that must be replaced with the value of $SWARMING_TASK_ID env var
- "logdog-annotation-stream" which is a name of the stream to send annotation datagrams to
in swarming_task_template.json pass them as a constants:
-logdog-prefix swarm/chromium-swarm.appspot.com/${swarming_run_id}
-logdog-annotation-stream annotations
,
Feb 14 2017
,
Feb 18 2017
We should also add "${swarming_host}".
This would make the LogDog URL:
logdog://luci-logdog.appspot.com/${project}/swarm/${swarming_host}/${swarming_run_id}/+/annotations
WDYT?
,
Feb 18 2017
SG. Currently swarming_task_template.json uses $swarming_host instead of ${swarming_host}. Both work. Consider updating the template to use ${swarming_host}
,
Feb 18 2017
Actually going to back off from #3. I think we should prescribe as much as possible upstream, and since SwarmBucket already knows its host, I think it should use the command-line:
-logdog-annotation-url logdog://luci-logdog.appspot.com/$project/swarm/$swarming_host/${swarming_run_id}/+/annotations
This will have SwarmBucket fill in everything except for "${swarming_run_id}", which is great since it knows all of that in advance. Kitchen will fill that in the "${swarming_run_id}" b/c only it knows that value.
,
Feb 18 2017
Yeah, one URL flag should be enough
,
Feb 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/fc6bd8a8856796312b4a2e3c043a74dac66ac194 commit fc6bd8a8856796312b4a2e3c043a74dac66ac194 Author: dnj <dnj@chromium.org> Date: Sat Feb 18 19:31:11 2017 milo: Add SwarmBucket templating. Add SwarmBucket template resolution package. Employ this in Milo when resolving the "log_location" URL. This will enable SwarmBucket templates that include a Swarming run ID in their name to resolve to their actual annotation log stream. BUG= chromium:692217 TEST=unit Review-Url: https://codereview.chromium.org/2701033003 [delete] https://crrev.com/c0b973a0a2e68852c035a98b7b0a4bad5d283f6a/.gitignore [add] https://crrev.com/fc6bd8a8856796312b4a2e3c043a74dac66ac194/common/data/text/stringtemplate/template.go [add] https://crrev.com/fc6bd8a8856796312b4a2e3c043a74dac66ac194/common/data/text/stringtemplate/template_test.go [modify] https://crrev.com/fc6bd8a8856796312b4a2e3c043a74dac66ac194/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-running-logdog.html [modify] https://crrev.com/fc6bd8a8856796312b4a2e3c043a74dac66ac194/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-running-logdog.html [modify] https://crrev.com/fc6bd8a8856796312b4a2e3c043a74dac66ac194/milo/appengine/swarming/build.go [modify] https://crrev.com/fc6bd8a8856796312b4a2e3c043a74dac66ac194/milo/appengine/swarming/buildinfo.go [modify] https://crrev.com/fc6bd8a8856796312b4a2e3c043a74dac66ac194/milo/appengine/swarming/expectations/build-running-logdog.json [modify] https://crrev.com/fc6bd8a8856796312b4a2e3c043a74dac66ac194/milo/appengine/swarming/testdata/build-running-logdog.swarm [add] https://crrev.com/fc6bd8a8856796312b4a2e3c043a74dac66ac194/swarming/tasktemplate/template.go [add] https://crrev.com/fc6bd8a8856796312b4a2e3c043a74dac66ac194/swarming/tasktemplate/template_test.go
,
Feb 19 2017
,
Feb 21 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by no...@chromium.org
, Feb 14 2017