add tags locating logdog annotation stream |
|||
Issue descriptionIn Swarmbucket add the following tags to swarming task: - "log_location:logdog_annotations" that signals that logs must be found in the logdog annotation stream "luci_project_id:<project_id>" that specifies common luci project id that will be used by logdog (for streaming) and milo (for loading logs from logdog and milo acls) "logdog_host:<host>" "logdog_prefix:<prefix>" that is the logdog stream prefix. This will be computed by swarmbucket and will no longer be computed by kitchen. Milo will not have to assume the prefix format used by kitchen. "logdog_annotation_stream:annotations" the name of the steam that contains annotations, a constant in practice.
,
Feb 14 2017
,
Feb 15 2017
WDYT of simplifying this a bit: log_location:logdog://host/project/prefix/+/path This is more concise single tag that fully expresses the intent.
,
Feb 15 2017
I like it. Ryan? We will still need luci_project_id for other purposes
,
Feb 15 2017
Yeah that's true, luci_project_id should definitely be independent. WDYT about "luci_project"? The "id" seems superfluous.
,
Feb 15 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/fc48cf11ee1cb3d6231216a779f2e2223b7d9409 commit fc48cf11ee1cb3d6231216a779f2e2223b7d9409 Author: Ryan Tseng <hinoka@google.com> Date: Wed Feb 15 21:23:05 2017
,
Feb 15 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/fc48cf11ee1cb3d6231216a779f2e2223b7d9409 commit fc48cf11ee1cb3d6231216a779f2e2223b7d9409 Author: Ryan Tseng <hinoka@google.com> Date: Wed Feb 15 21:23:05 2017
,
Feb 15 2017
I like the 2 tag proposal log_location:logdog://host/project/prefix/+/path luci_projet:infra
,
Feb 15 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/6f5bf057be4f03043b73d850bebc4c66a1ada934 commit 6f5bf057be4f03043b73d850bebc4c66a1ada934 Author: Ryan Tseng <hinoka@google.com> Date: Wed Feb 15 22:39:12 2017
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/2d33c6ed168c4b7f0d50a3bd34bf9cf7e825ad79 commit 2d33c6ed168c4b7f0d50a3bd34bf9cf7e825ad79 Author: Ryan Tseng <hinoka@google.com> Date: Thu Feb 16 00:19:30 2017 Add swarming hostname to buildbucket templates for swarming BUG= 692207 Change-Id: Ibf85247b1956164b486b2753fd0870d44e173097 Reviewed-on: https://chromium-review.googlesource.com/443135 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> [modify] https://crrev.com/2d33c6ed168c4b7f0d50a3bd34bf9cf7e825ad79/appengine/cr-buildbucket/swarming/swarming.py
,
Feb 17 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/80cf3b2993d9cadc266f0b1137f6dc3b9e6a6af0 commit 80cf3b2993d9cadc266f0b1137f6dc3b9e6a6af0 Author: Ryan Tseng <hinoka@google.com> Date: Fri Feb 17 17:00:00 2017
,
Feb 21 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by no...@chromium.org
, Feb 14 2017re logdog prefix, add tag "logdog_prefix:swarm/chromium-swarm.appspot.com/${swarming_run_id}" where ${swarming_run_id} must be replaced by users with the actually task run id. In particular, Milo will replace it wit the value found in the task result loaded by task id.