Issue 692169 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	benchan@chromium.org
Closed:	Feb 2017
Components:	OS>Systems
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
VerifyIn-59 VerifyIn-60 VerifyIn-61

CrOS: remove superfluous or direct dependency on dbus, dbus-glib, dbus-c++

Project Member Reported by benchan@chromium.org, Feb 14 2017

Issue description

A few CrOS packages specify explicit dependencies on dbus, dbus-glib, dbus-c++ in gyp and ebuild, which is either superfluous (as they use chrome's dbus bindings via libchrome, libbrillo, and chromeos-dbus-bindings), or unnecessary (as they only interface directly with libbrillo and chromeos-dbus-bindings, which introduces a transitive dependency on dbus / dbus-glib).

Comment 1 by benchan@chromium.org, Feb 14 2017

Previous related CL: https://chromium-review.googlesource.com/c/437606/

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3a2d038b47bc0bf0b13048fcab4bc6e2cd3d6c0d

commit 3a2d038b47bc0bf0b13048fcab4bc6e2cd3d6c0d
Author: Ben Chan <benchan@chromium.org>
Date: Wed Feb 15 21:33:11 2017

libbrillo: remove superfluous dev-libs/dbus-c++ dependency

libbrillo uses DBus bindings from libchrome and dbus-glib, but not
dbus-c++. This CL removes the superfluous dev-libs/dbus-c++ dependency
in libbrillo ebuild.

BUG= chromium:692169 
TEST=Run unit tests.
TEST=Verify that runtime dependencies of libbrillo hasn't changed.

Change-Id: I38f41648e4d439da6d71bc5603fbfa66fb88df27
Reviewed-on: https://chromium-review.googlesource.com/442626
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3a2d038b47bc0bf0b13048fcab4bc6e2cd3d6c0d/chromeos-base/libbrillo/libbrillo-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7bd8ced00161779fdfbfe23c1326be9787465c58

commit 7bd8ced00161779fdfbfe23c1326be9787465c58
Author: Ben Chan <benchan@chromium.org>
Date: Wed Feb 15 21:33:12 2017

authpolicy: remove superfluous dbus-c++ dependency

authpolicy uses Chrome DBus bindings provided by libchrome, libbrillo,
and chromeos-dbus-bindings, and not dbus-c++. This CL removes the
superfluous dbus-c++ dependency from authpolicy.gyp.

BUG= chromium:692169 
TEST=Run unit tests.
TEST=Check runtime dependencies of authpolicyd.

Change-Id: I53485a818c8872e98f9b0070f34c9a8fca34648e
Reviewed-on: https://chromium-review.googlesource.com/442688
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/7bd8ced00161779fdfbfe23c1326be9787465c58/authpolicy/authpolicy.gyp