landmines.py doesn't print output when running as a gclient hook |
|||||
Issue descriptionThis recently caused me problems, so I'm hoping that we can improve gclient.py so that this doesn't bite someone else. I spent a half hour or so trying to figure out what I'd done wrong that was causing `fetch v8` to fail. As it turns out, gclient was using landmines.py, which was failing. When I ran landmines.py directly, it gave a clear error message about how I didn't have Visual Studio 2013 installed (although I did have VS 2015 installed), which immediately tipped me off to what the problem was. It probably makes sense to output landmines.py's output from gclient.py if landmines.py fails.
,
Feb 14 2017
gclient is running landmines via a hook. It's not part of gclient itself. Plenty of hooks print stuff to the command line while running, whether they fail or succeed. I don't know why landmines fails to print to stdout/stderr when running as a gclient hook, but it isn't the fault of gclient.
,
Feb 14 2017
Ah, okay: that makes sense. Any suggestion on who might be a good person to talk to about gclient hooks?
,
Feb 14 2017
I CC'd thakis, who appears to be the closest thing to an Owner that landmines has. Hopefully he'll be able to help with the script.
,
Feb 14 2017
I think iannucci wrote landmines. I don't own it, I just tell people not to rely on landmines for things a lot. I wish we could get rid of it eventually.
,
Nov 3 2017
charliea: did you only see this on Windows? Perhaps it's due to thakis's and dcheng's recent work in gclient, but I can't repro the behavior you describe on Linux.
,
Nov 3 2017
,
Nov 6 2017
Yep, I only saw this on my Windows laptop. (granted, it was back in February, so I don't have too much more information on what I was doing when I ran into it)
,
Oct 19
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by charliea@chromium.org
, Feb 14 2017