New issue
Advanced search Search tips

Issue 692154 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

BackgroundThreadLoad tracker should be disabled by default.

Project Member Reported by altimin@chromium.org, Feb 14 2017

Issue description

BackgroundMainThreadLockTracker currently is enabled when created during RendererSchedulerImpl initialisation. It's wrong, BMTLT should be disabled.
 
Labels: Merge-Request-57
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 16 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dc5c88fe6b2540b401991e0add66f31622ec2a6

commit 6dc5c88fe6b2540b401991e0add66f31622ec2a6
Author: Alexander Timin <altimin@chromium.org>
Date: Thu Feb 16 12:46:49 2017

[scheduler] Disable background thread load tracker by default.

Disable background thread load tracker during initialisation of renderer
scheduler.

R=skyostil@chromium.org

BUG= 692154 

Review-Url: https://codereview.chromium.org/2693953005
Cr-Commit-Position: refs/heads/master@{#450662}
(cherry picked from commit 501f3047595ae7f139fcf4ae025ea08b927f4202)

Review-Url: https://codereview.chromium.org/2693323003 .
Cr-Commit-Position: refs/branch-heads/2987@{#547}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/6dc5c88fe6b2540b401991e0add66f31622ec2a6/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker.cc
[modify] https://crrev.com/6dc5c88fe6b2540b401991e0add66f31622ec2a6/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker_unittest.cc
[modify] https://crrev.com/6dc5c88fe6b2540b401991e0add66f31622ec2a6/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment