New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692153 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 692223


Participants' hotlists:
Launcher-Tech-Debt


Sign in to add a comment

mash: Launching apps from app list doesn't always work

Project Member Reported by mfomitchev@chromium.org, Feb 14 2017

Issue description

E.g. launching the Files app works, which Chrome doesn't. One uses ChromeLauncherController::LaunchApp, while the other uses ChromeLauncherController::ActivateApp, which is not implemented for Mus.

 

Comment 1 by msw@chromium.org, Feb 14 2017

Components: -Internals>MUS Platform>Apps>AppLauncher
I'm working on LauncherItemController::Activate / ShelfItemDelegate::ItemSelected refactoring at the moment.
That doesn't exactly ChromeLauncherController::LaunchApp / ChromeLauncherController::ActivateApp, but it'll help.
Any help in this area is greatly appreciated.

Is there a meta-bug tracking app list defects in mash? (like shelf  Issue 557406  and  Issue 681072 ).
Perhaps we should re-open  Issue 557408 ...
There's issue 678705, which covers all chrome <-> ash communication changes necessary for our 30 min casual browsing Q1 OKR. No app-list specific master bug that I know of. We could create it, but we don't have to do all of it for Q1. It would be good to identify the parts that we do need to do for Q1 (this issue?) and log bugs under issue 678705.

Comment 3 by sky@chromium.org, Feb 14 2017

Blocking: 692223

Comment 4 by sky@chromium.org, Feb 14 2017

Labels: -Pri-3 mustash-1 OS-Chrome Pri-1
Blockedon: 557406
Owner: thanhph@chromium.org

Comment 6 by msw@chromium.org, Feb 14 2017

Blockedon: -557406
I wouldn't say that this is blocked on  Issue 557406 . We don't need all mash shelf functionality to launch apps from the app list.

Comment 7 by sky@chromium.org, Feb 22 2017

Owner: mfomitchev@chromium.org
Status: Assigned (was: Available)
Labels: mustash-2
Summary: mash: Launching apps from app list doesn't always work (was: Launching apps from app list doesn't always work)
As of r463266 this morning, on device Pixel 1 with --mash, I cannot launch any app from the app list, including the Files app. I don't see anything interesting in the logs.

On desktop I can launch the Files app but not the web store app. On desktop I see this:

[11953:11953:0410/092813.400805:ERROR:chrome_launcher_controller_mus.cc(87)] Not implemented reached in virtual void ChromeLauncherControllerMus::ActivateApp(const std::string &, ash::ShelfLaunchSource, int)

Labels: Touch-Friendly-Launcher
Labels: Touch-Friendly-Launcher-Triaged
Cc: newcomer@chromium.org
Seems fixed in Tot.
Owner: newcomer@chromium.org
Test the rest of launcher in Mash.
Status: Fixed (was: Assigned)

Comment 15 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 16 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment