New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692147 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Storage API: upstream tests to web-platform-tests

Project Member Reported by jsb...@chromium.org, Feb 14 2017

Issue description

web-platform-tests doesn't have a suite for https://storage.spec.whatwg.org

We can upstream our tests; we should add an idlharness test as well.
 

Comment 1 by jsb...@chromium.org, Feb 15 2017

Cc: mkwst@chromium.org
PR to create a storage/ suite in WPT: 

https://github.com/w3c/web-platform-tests/pull/4837
That landed - need to look to see if there's any tests we can upstream or dedupe.
Status: Started (was: Assigned)
https://codereview.chromium.org/2791963004
We still have:

LayoutTests/http/tests/storage/durability-basics.html
LayoutTests/http/tests/storage/durability-workers.html

These can be upstreamed; ideally as .any.js tests but whatevs.

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/890c567c988debbe7d456765fdbc202d01571cf8

commit 890c567c988debbe7d456765fdbc202d01571cf8
Author: jsbell <jsbell@chromium.org>
Date: Sat Apr 08 00:04:12 2017

Upstream navigator.storage.persist()/persisted() tests to WPT

The tests just assert that the methods return promises and
that the promises resolve to booleans.

TODO: Replace the *.worker.html files with just *.worker.js
once Blink supports running those.

BUG= 692147 

Review-Url: https://codereview.chromium.org/2805353003
Cr-Commit-Position: refs/heads/master@{#463062}

[add] https://crrev.com/890c567c988debbe7d456765fdbc202d01571cf8/third_party/WebKit/LayoutTests/external/wpt/storage/resources/storagemanager-persist-worker.js
[add] https://crrev.com/890c567c988debbe7d456765fdbc202d01571cf8/third_party/WebKit/LayoutTests/external/wpt/storage/resources/storagemanager-persisted-worker.js
[add] https://crrev.com/890c567c988debbe7d456765fdbc202d01571cf8/third_party/WebKit/LayoutTests/external/wpt/storage/storagemanager-persist-worker.https.html
[add] https://crrev.com/890c567c988debbe7d456765fdbc202d01571cf8/third_party/WebKit/LayoutTests/external/wpt/storage/storagemanager-persist.https.html
[add] https://crrev.com/890c567c988debbe7d456765fdbc202d01571cf8/third_party/WebKit/LayoutTests/external/wpt/storage/storagemanager-persisted-worker.https.html
[add] https://crrev.com/890c567c988debbe7d456765fdbc202d01571cf8/third_party/WebKit/LayoutTests/external/wpt/storage/storagemanager-persisted.https.html
[delete] https://crrev.com/41b9cfb8710fbeec6ead343de517cdb6fbd5d205/third_party/WebKit/LayoutTests/http/tests/storage/durability-basics.html
[delete] https://crrev.com/41b9cfb8710fbeec6ead343de517cdb6fbd5d205/third_party/WebKit/LayoutTests/http/tests/storage/durability-workers.html
[delete] https://crrev.com/41b9cfb8710fbeec6ead343de517cdb6fbd5d205/third_party/WebKit/LayoutTests/http/tests/storage/resources/durability-worker.js

Comment 7 by jsb...@chromium.org, Apr 11 2017

Status: Fixed (was: Started)

Sign in to add a comment