New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 692121 link

Starred by 1 user
Status: Duplicate
Owner: ----
Closed: Apr 2017
Cc:
█ pam@chromium.org
emaxx@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 646113


Sign in to add a comment

Modernize the TestingPrefService* interface to use C++11 features

Project Member Reported by emaxx@chromium.org, Feb 14 2017 
In particular, change the following methods to accept base::Value either by value or by unique_ptr instead of raw owning pointer:
* TestingPrefServiceBase::SetManagedPref
* TestingPrefServiceBase::SetExtensionPref
* TestingPrefServiceBase::SetUserPref
* TestingPrefServiceBase::SetRecommendedPref

Comment 1 by emaxx@chromium.org, Feb 15 2017

Blockedon: 646113
This should probably wait a bit until the refactoring of the base::Value API comes to some stable point.

Comment 2 by emaxx@chromium.org, Apr 10 2017

Mergedinto: 697817
Status: Duplicate (was: Available)
Seems that this is done by vabr@: crrev.com/8684c9acc69aa307f5fabfef0182b61c7fe8ce00
►

Sign in to add a comment