New issue
Advanced search Search tips

Issue 692117 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

Remove web::BlockedPopupInfo class

Project Member Reported by eugene...@chromium.org, Feb 14 2017

Issue description

Popup blocking us now implemented in Chrome
 
Components: UI>Browser>PopupBlocker
Summary: Remove web::BlockedPopupInfo class (was: Remove window_name property from web::BlockedPopupInfo )
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0984e8e9374ac9926dd9f41ad873c0c0abd90b3

commit d0984e8e9374ac9926dd9f41ad873c0c0abd90b3
Author: eugenebut <eugenebut@chromium.org>
Date: Wed Feb 22 23:47:51 2017

Do not use TabModel inside BlockedPopupInfo handler block.

BlockedPopupInfo handler block will be folded into BlockedPopupHandler
which does not have access to TabModel.

Calling updateSnapshotWithOverlay:visibleFrameOnly: is unnecessary,
because it is called from TabInfoBarObserver::OnInfoBarRemoved.

Opening popup functionality was moved to
WebStateDelegate::OpenURLFromWebState, which is currently BVC.

BUG= 692117 

Review-Url: https://codereview.chromium.org/2705113004
Cr-Commit-Position: refs/heads/master@{#452278}

[modify] https://crrev.com/d0984e8e9374ac9926dd9f41ad873c0c0abd90b3/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/d0984e8e9374ac9926dd9f41ad873c0c0abd90b3/ios/chrome/browser/ui/browser_view_controller.mm

Description: Show this description
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 2 2017

Status: Fixed (was: Started)

Sign in to add a comment