After switching to WKWebView it is always empty.
Popup blocking us now implemented in Chrome
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0984e8e9374ac9926dd9f41ad873c0c0abd90b3 commit d0984e8e9374ac9926dd9f41ad873c0c0abd90b3 Author: eugenebut <eugenebut@chromium.org> Date: Wed Feb 22 23:47:51 2017 Do not use TabModel inside BlockedPopupInfo handler block. BlockedPopupInfo handler block will be folded into BlockedPopupHandler which does not have access to TabModel. Calling updateSnapshotWithOverlay:visibleFrameOnly: is unnecessary, because it is called from TabInfoBarObserver::OnInfoBarRemoved. Opening popup functionality was moved to WebStateDelegate::OpenURLFromWebState, which is currently BVC. BUG= 692117 Review-Url: https://codereview.chromium.org/2705113004 Cr-Commit-Position: refs/heads/master@{#452278} [modify] https://crrev.com/d0984e8e9374ac9926dd9f41ad873c0c0abd90b3/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/d0984e8e9374ac9926dd9f41ad873c0c0abd90b3/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29ed2a2bcc95599c41501cbf5a1918735bb96d7b commit 29ed2a2bcc95599c41501cbf5a1918735bb96d7b Author: eugenebut <eugenebut@chromium.org> Date: Thu Mar 02 19:30:44 2017 Moved ios popup opening code from Tab to BlockedPopupTabHelper. BUG= 692117 Review-Url: https://codereview.chromium.org/2717613006 Cr-Commit-Position: refs/heads/master@{#454338} [modify] https://crrev.com/29ed2a2bcc95599c41501cbf5a1918735bb96d7b/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/29ed2a2bcc95599c41501cbf5a1918735bb96d7b/ios/chrome/browser/web/blocked_popup_tab_helper.mm [modify] https://crrev.com/29ed2a2bcc95599c41501cbf5a1918735bb96d7b/ios/chrome/browser/web/blocked_popup_tab_helper_unittest.mm [modify] https://crrev.com/29ed2a2bcc95599c41501cbf5a1918735bb96d7b/ios/web/public/test/fakes/test_web_state_delegate.h [modify] https://crrev.com/29ed2a2bcc95599c41501cbf5a1918735bb96d7b/ios/web/public/test/fakes/test_web_state_delegate.mm [modify] https://crrev.com/29ed2a2bcc95599c41501cbf5a1918735bb96d7b/ios/web/public/test/web_test_with_web_state.h [modify] https://crrev.com/29ed2a2bcc95599c41501cbf5a1918735bb96d7b/ios/web/public/test/web_test_with_web_state.mm [modify] https://crrev.com/29ed2a2bcc95599c41501cbf5a1918735bb96d7b/ios/web/web_state/blocked_popup_info.h [modify] https://crrev.com/29ed2a2bcc95599c41501cbf5a1918735bb96d7b/ios/web/web_state/blocked_popup_info.mm
Comment 1 by eugene...@chromium.org
, Feb 21 2017Summary: Remove web::BlockedPopupInfo class (was: Remove window_name property from web::BlockedPopupInfo )