New issue
Advanced search Search tips

Issue 692105 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

WPT import: Large influx of new tests which could not be handled all at once.

Project Member Reported by qyears...@chromium.org, Feb 14 2017 
In the last week, a large number of tests were added to web-platform-tests, which resulted in a large import that Rietveld/CQ wasn't able to handle.

So, I made an import CL (http://crrev.com/2697453005) but the MANIFEST.json file wasn't updated and uploaded with the CL, so many new tests weren't run.

In order to get these tests imported with new baselines and updated test expectations, I think it may be easiest now to import them first without updating expectations, then update expectations and baselines in follow-up CLs.

New directories and their owners:
webvtt: foolip@chromium.org, maksim.sisov@intel.com
referrer-policy: jochen@chromium.org, estark@chromium.org
subresource-integrity: mkwst@chromium.org,jochen@chromium.org
service-workers/service-worker/multi-globals: shimazu@chromium.org
mixed-content: mkwst@chromium.org
assumptions: newly added to wpt, no owners in Blink

In addition, there were new and changed tests in existing directories:

html, dom, shadow-dom, custom-elements: dom-dev@chromium.org
streams: domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org
fullscreen: foolip@chromium.org
FileAPI, resources: jsbell@chromium.org
webmessaging: mek@chromium.org
service-workers: shimazu@chromium.org
web-animations: suzyh@chromium.org
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8111f4d820ce77d9cfc6c1d47db3f35159d8f2e1

commit 8111f4d820ce77d9cfc6c1d47db3f35159d8f2e1
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Feb 15 06:01:18 2017

Enable new wpt/webvtt tests.

R=foolip@chromium.org, maksim.sisov@intel.com
BUG= 692105 

Review-Url: https://codereview.chromium.org/2694623006
Cr-Commit-Position: refs/heads/master@{#450578}

[modify] https://crrev.com/8111f4d820ce77d9cfc6c1d47db3f35159d8f2e1/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/8111f4d820ce77d9cfc6c1d47db3f35159d8f2e1/third_party/WebKit/LayoutTests/external/wpt/webvtt/interfaces-expected.txt
[add] https://crrev.com/8111f4d820ce77d9cfc6c1d47db3f35159d8f2e1/third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/align-expected.txt
[add] https://crrev.com/8111f4d820ce77d9cfc6c1d47db3f35159d8f2e1/third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/getCueAsHTML-expected.txt
[add] https://crrev.com/8111f4d820ce77d9cfc6c1d47db3f35159d8f2e1/third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/line-expected.txt
[add] https://crrev.com/8111f4d820ce77d9cfc6c1d47db3f35159d8f2e1/third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/snapToLines-expected.txt
[add] https://crrev.com/8111f4d820ce77d9cfc6c1d47db3f35159d8f2e1/third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/text-expected.txt
[add] https://crrev.com/8111f4d820ce77d9cfc6c1d47db3f35159d8f2e1/third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-api-for-browsers/vttcue-interface/vertical-expected.txt
[add] https://crrev.com/8111f4d820ce77d9cfc6c1d47db3f35159d8f2e1/third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-file-format-parsing/webvtt-cue-text-parsing-rules/tests/entities-expected.txt
[add] https://crrev.com/8111f4d820ce77d9cfc6c1d47db3f35159d8f2e1/third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-file-format-parsing/webvtt-cue-text-parsing-rules/tests/tags-expected.txt
[add] https://crrev.com/8111f4d820ce77d9cfc6c1d47db3f35159d8f2e1/third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-file-format-parsing/webvtt-cue-text-parsing-rules/tests/timestamps-expected.txt
[add] https://crrev.com/8111f4d820ce77d9cfc6c1d47db3f35159d8f2e1/third_party/WebKit/LayoutTests/external/wpt/webvtt/webvtt-file-format-parsing/webvtt-cue-text-parsing-rules/tests/tree-building-expected.txt
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/224a858114095586e1d7a2f782a8a7ba21328656

commit 224a858114095586e1d7a2f782a8a7ba21328656
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Feb 15 18:52:08 2017

Enable new wpt/subresource-integrity tests.

R=mkwst@chromium.org,jochen@chromium.org
BUG= 692105 

Review-Url: https://codereview.chromium.org/2696043002
Cr-Commit-Position: refs/heads/master@{#450747}

[modify] https://crrev.com/224a858114095586e1d7a2f782a8a7ba21328656/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by qyears...@chromium.org, Feb 15 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13e532004647b3d9fefe0c3643d3741a3c53184e

commit 13e532004647b3d9fefe0c3643d3741a3c53184e
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Feb 17 17:31:28 2017

Enable new wpt/referrer-policy tests.

R=jochen@chromium.org, estark@chromium.org
BUG= 692105 

Review-Url: https://codereview.chromium.org/2693703007
Cr-Commit-Position: refs/heads/master@{#451331}

[modify] https://crrev.com/13e532004647b3d9fefe0c3643d3741a3c53184e/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de87f8618d5c944a250e0096f8174a83fb07c932

commit de87f8618d5c944a250e0096f8174a83fb07c932
Author: qyearsley <qyearsley@chromium.org>
Date: Tue Feb 21 11:19:04 2017

Enable new wpt/mixed-content tests.

R=mkwst@chromium.org
BUG= 692105 

Review-Url: https://codereview.chromium.org/2689323003
Cr-Commit-Position: refs/heads/master@{#451727}

[modify] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/allowed/http-csp/same-host-https/audio-tag/top-level/keep-scheme-redirect/allowed.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/allowed/http-csp/same-host-https/audio-tag/top-level/no-redirect/allowed.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/allowed/http-csp/same-host-https/video-tag/top-level/keep-scheme-redirect/allowed.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/allowed/http-csp/same-host-https/video-tag/top-level/no-redirect/allowed.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/allowed/meta-csp/same-host-https/audio-tag/top-level/no-redirect/allowed.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/allowed/meta-csp/same-host-https/video-tag/top-level/no-redirect/allowed.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/allowed/no-opt-in/same-host-https/audio-tag/top-level/keep-scheme-redirect/allowed.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/allowed/no-opt-in/same-host-https/audio-tag/top-level/no-redirect/allowed.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/allowed/no-opt-in/same-host-https/video-tag/top-level/keep-scheme-redirect/allowed.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/allowed/no-opt-in/same-host-https/video-tag/top-level/no-redirect/allowed.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/optionally-blockable/no-opt-in/cross-origin-http/audio-tag/top-level/keep-scheme-redirect/no-opt-in-allows.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/optionally-blockable/no-opt-in/cross-origin-http/audio-tag/top-level/no-redirect/no-opt-in-allows.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/optionally-blockable/no-opt-in/cross-origin-http/audio-tag/top-level/swap-scheme-redirect/no-opt-in-allows.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/optionally-blockable/no-opt-in/cross-origin-http/video-tag/top-level/keep-scheme-redirect/no-opt-in-allows.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/optionally-blockable/no-opt-in/cross-origin-http/video-tag/top-level/no-redirect/no-opt-in-allows.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/optionally-blockable/no-opt-in/cross-origin-http/video-tag/top-level/swap-scheme-redirect/no-opt-in-allows.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/optionally-blockable/no-opt-in/same-host-http/audio-tag/top-level/keep-scheme-redirect/no-opt-in-allows.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/optionally-blockable/no-opt-in/same-host-http/audio-tag/top-level/no-redirect/no-opt-in-allows.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/optionally-blockable/no-opt-in/same-host-http/audio-tag/top-level/swap-scheme-redirect/no-opt-in-allows.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/optionally-blockable/no-opt-in/same-host-http/video-tag/top-level/keep-scheme-redirect/no-opt-in-allows.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/optionally-blockable/no-opt-in/same-host-http/video-tag/top-level/no-redirect/no-opt-in-allows.https-expected.txt
[add] https://crrev.com/de87f8618d5c944a250e0096f8174a83fb07c932/third_party/WebKit/LayoutTests/external/wpt/mixed-content/optionally-blockable/no-opt-in/same-host-http/video-tag/top-level/swap-scheme-redirect/no-opt-in-allows.https-expected.txt
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaec153c7362dc18e576db2f64f6dc99934fd6f1

commit aaec153c7362dc18e576db2f64f6dc99934fd6f1
Author: Quinten Yearsley <qyearsley@google.com>
Date: Tue Feb 28 16:37:50 2017

Enable new tests in wpt/html/.

BUG= 692105 

Change-Id: I7186d2434c6b58db45b6c15484893bd9ccdc5ff9
Reviewed-on: https://chromium-review.googlesource.com/446056
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#453620}
[modify] https://crrev.com/aaec153c7362dc18e576db2f64f6dc99934fd6f1/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/aaec153c7362dc18e576db2f64f6dc99934fd6f1/third_party/WebKit/LayoutTests/external/wpt/html/browsers/browsing-the-web/unloading-documents/beforeunload-canceling-expected.txt
[add] https://crrev.com/aaec153c7362dc18e576db2f64f6dc99934fd6f1/third_party/WebKit/LayoutTests/external/wpt/html/browsers/history/the-location-interface/location-valueof-expected.txt
[add] https://crrev.com/aaec153c7362dc18e576db2f64f6dc99934fd6f1/third_party/WebKit/LayoutTests/external/wpt/html/dom/self-origin.sub-expected.txt
[add] https://crrev.com/aaec153c7362dc18e576db2f64f6dc99934fd6f1/third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-embed-element/embed-in-object-fallback-2-expected.txt
[add] https://crrev.com/aaec153c7362dc18e576db2f64f6dc99934fd6f1/third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-object-element/object-in-object-fallback-2-expected.txt
[add] https://crrev.com/aaec153c7362dc18e576db2f64f6dc99934fd6f1/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/execorder-expected.txt
[add] https://crrev.com/aaec153c7362dc18e576db2f64f6dc99934fd6f1/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/imports-expected.txt
[add] https://crrev.com/aaec153c7362dc18e576db2f64f6dc99934fd6f1/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/idle-callbacks/callback-suspended-expected.txt
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ebf780ebaa4e6bea494255675832c3e017997d3

commit 6ebf780ebaa4e6bea494255675832c3e017997d3
Author: Quinten Yearsley <qyearsley@google.com>
Date: Mon Mar 06 05:44:18 2017

Enable recently-imported external/wpt/streams tests.

BUG= 692105 

Change-Id: I0dd1cd5971236b686473dedc208c84431f661b75
Reviewed-on: https://chromium-review.googlesource.com/448759
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#454832}
[modify] https://crrev.com/6ebf780ebaa4e6bea494255675832c3e017997d3/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/6ebf780ebaa4e6bea494255675832c3e017997d3/third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/floating-point-total-queue-size-expected.txt
[add] https://crrev.com/6ebf780ebaa4e6bea494255675832c3e017997d3/third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt
[add] https://crrev.com/6ebf780ebaa4e6bea494255675832c3e017997d3/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/floating-point-total-queue-size-expected.txt
[add] https://crrev.com/6ebf780ebaa4e6bea494255675832c3e017997d3/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt

Comment 12 by qyears...@chromium.org, Mar 6 2017 

Update: almost finished, I think the last change for this bug should be: https://codereview.chromium.org/2733523003

Comment 14 by qyears...@chromium.org, Mar 8 2017

Status: Fixed (was: Started)

Comment 15 by foolip@chromium.org, Jul 3 2017

Components: Blink>Infra>Ecosystem

Comment 16 by foolip@chromium.org, Jul 3 2017

Components: -Blink>Infra>Predictability
►

Sign in to add a comment