New issue
Advanced search Search tips

Issue 692104 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
V1



Sign in to add a comment

ProfilePolicyConnector::GetManagementDomain() returns empty string for AD-managed domains

Project Member Reported by hunyadym@chromium.org, Feb 14 2017

Issue description

ProfilePolicyConnector::GetManagementDomain() returns empty string if it's an AD managed domain. It should return the Active Directory realm instead. This is used to show the name for the managed bookmarks.
 

Comment 1 by tnagel@chromium.org, Feb 14 2017

Labels: -Pri-3 V1 Pri-2
Status: Available (was: Untriaged)

Comment 2 by emaxx@chromium.org, Feb 19 2017

Cc: -tnagel@chromium.org emaxx@chromium.org
Owner: tnagel@chromium.org
Status: Assigned (was: Available)
Thiemo, sounds like you're the right owner for this.

Comment 3 by tnagel@chromium.org, Jul 26 2017

Owner: ----
Status: Available (was: Assigned)
Labels: Enterprise-Triaged
Owner: rsorokin@chromium.org
Status: Assigned (was: Available)
Labels: M-63
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b300bfc9c17b664bde1a01c7b2927d5dfa5735d0

commit b300bfc9c17b664bde1a01c7b2927d5dfa5735d0
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Tue Sep 26 23:38:44 2017

Return realm for ProfilePolicyConnector::GetManagementDomain

Now it returns an empty string for Active Directory managed devices.
The string is used to show the name for the managed bookmarks.

TBR=achuith@chromium.org

Bug:  692104 
Change-Id: Ib0da6724cf5439050c435312af64d4ee9d59b79c
Reviewed-on: https://chromium-review.googlesource.com/678511
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504522}
[modify] https://crrev.com/b300bfc9c17b664bde1a01c7b2927d5dfa5735d0/chrome/browser/policy/profile_policy_connector.cc
[modify] https://crrev.com/b300bfc9c17b664bde1a01c7b2927d5dfa5735d0/chrome/browser/policy/profile_policy_connector.h
[modify] https://crrev.com/b300bfc9c17b664bde1a01c7b2927d5dfa5735d0/chrome/browser/policy/profile_policy_connector_unittest.cc
[modify] https://crrev.com/b300bfc9c17b664bde1a01c7b2927d5dfa5735d0/components/user_manager/user.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Marked as "Verified", no issues with managed bookmarks for Active Directory managed devices (see screenshot).

Chrome OS: 10575.17.0
Chrome: 67.0.3396.19
Device: Santa
Screenshot 2018-04-27 at 3.30.35 PM.png
123 KB View Download

Sign in to add a comment