New issue
Advanced search Search tips

Issue 692088 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Update freetype-android to 2.7.1

Project Member Reported by drott@chromium.org, Feb 14 2017

Issue description

Update freetype-android to 2.7.1 for latest OpenType variation fixes, especially correct advance widths in Noto Arabic variation font.

Commit 069083cccd73d1d68da68116c8d050bb62cdfe0e
 

Comment 2 by drott@chromium.org, Feb 15 2017

Status: Fixed (was: Started)
Further rolls blocked on https://savannah.nongnu.org/bugs/index.php?50313

Comment 3 by js...@chromium.org, Feb 17 2017

Thanks, Dominik. For Android OS, I'll go to 66725768cdf758cfb3f9abf03cbf5e5a77f42088 for now (even though it can go farther because it's not blocked by 
 https://savannah.nongnu.org/bugs/index.php?50313 ). 

For Chrome OS, I'll do the same. 


Comment 4 by js...@chromium.org, Feb 17 2017

FYI: https://android-review.googlesource.com/#/c/329663/ is an Android-OS CL. 

Comment 5 by js...@chromium.org, Feb 20 2017

Dominik, why is FreeType in Android-Chrome blocked by fontconfig compile issue? 

For CrOS, that can be an issue, but can be taken care of by applying your proposed patch on top of that.  

For Android-OS, I'm going all the way to ToT (e432ebf2) for now and will update to 2.7.2 when it's released. 

Comment 6 by drott@chromium.org, Feb 20 2017

> Dominik, why is FreeType in Android-Chrome blocked by fontconfig compile issue? 

freetype-android is used for the Chromecast build as well, which builds Fontconfig against this version of FreeType, which leads to the build failure as described in https://savannah.nongnu.org/bugs/index.php?50313

If you don't have a dependency on the legacy IDs, rolling further is fine.

Comment 7 by js...@chromium.org, Feb 21 2017

> freetype-android is used for the Chromecast build as well

Thanks ! I didn't know that. The upstream has just took your patch. 

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/08dccc568ecef2c9eaf288b32289642b0ac735b5

commit 08dccc568ecef2c9eaf288b32289642b0ac735b5
Author: Jungshik Shin <jshin@chromium.org>
Date: Thu Mar 02 23:12:42 2017

Update FreeType to 2.7.1 + patches

Update FreeType to e432ebf (past 2.7.1)

The most significant change since 2.7 is support for variable fonts as
specified in Opentype 1.8.1.

Subpixel hinting is enabled.

Ebuild for freeytpe 2.7 with changes is used because EAPI=6 is not
supported yet.

On top of e432ebf, apply a patch by <drott@google.com> to make
fontconfig happy.

BUG= chromium:692088 
TEST=emerge-{x86-alex,amd64-generic,daisy} freetype succeeds.
TEST=cbuildbot chromiumos-sdk
TEST=cbuildbot  amd64-generic-full x86-generic-full arm-generic-full
TEST=manual/visual: WebUI rendering and web page rendering do not have any noticeable regression.

Change-Id: I2a4595a38bd01d097bb554ad17eeb3929de1fb6c
Reviewed-on: https://chromium-review.googlesource.com/444834
Commit-Ready: Jungshik Shin <jshin@chromium.org>
Tested-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>

[add] https://crrev.com/08dccc568ecef2c9eaf288b32289642b0ac735b5/media-libs/freetype/files/freetype-2.7.1-ttnames.patch
[delete] https://crrev.com/b106323434a13d4620e74a588ea5f9ff167791a6/media-libs/freetype/freetype-2.7-r1.ebuild
[add] https://crrev.com/08dccc568ecef2c9eaf288b32289642b0ac735b5/media-libs/freetype/freetype-2.7.1-r1.ebuild
[delete] https://crrev.com/b106323434a13d4620e74a588ea5f9ff167791a6/media-libs/freetype/files/freetype-2.7-enable-valid.patch
[rename] https://crrev.com/08dccc568ecef2c9eaf288b32289642b0ac735b5/media-libs/freetype/freetype-2.7.1.ebuild
[modify] https://crrev.com/08dccc568ecef2c9eaf288b32289642b0ac735b5/media-libs/freetype/Manifest
[delete] https://crrev.com/b106323434a13d4620e74a588ea5f9ff167791a6/media-libs/freetype/files/freetype-2.7-disable-subpixel-hinting.patch
[add] https://crrev.com/08dccc568ecef2c9eaf288b32289642b0ac735b5/media-libs/freetype/files/freetype-2.7.1-e432ebf.patch
[delete] https://crrev.com/b106323434a13d4620e74a588ea5f9ff167791a6/media-libs/freetype/files/freetype-2.7-c38be52bf8.patch

Sign in to add a comment