New issue
Advanced search Search tips

Issue 692087 link

Starred by 1 user
Status: Fixed
Owner:
dougt@chromium.org
Closed: Jul 2017
Cc:
dmazz...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Add PRESUMIT for accessibility_mode_enums values

Project Member Reported by dougt@chromium.org, Feb 14 2017 
Values in content/common/accessibility_mode_enums.h need to be kept in sync with content/browser/resources/accessibility/accessibility.js. It's easy to forget and we should have a PRESUBMIT guarding against mistakes.

This came up in https://codereview.chromium.org/2690653004/ and dmazzoni wrote:

Things that need to be kept in sync are always a maintenance burden - especially when they cross language boundaries like this.

How about doing one of the following two things:

1. Add a PRESUBMIT that fails if you try to modify 
    content/common/accessibility_mode_enums.h without
    also modifying this file to match. You can use the
    one in ui/accessibility/ as a good example to copy.

2. Alternatively, have accessibility.js load the list of enums
    from C++ code in JSON, for example it would get
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96252c9df30022a3c734bc03dea7b1c73e5de23c

commit 96252c9df30022a3c734bc03dea7b1c73e5de23c
Author: dougt <dougt@chromium.org>
Date: Sun Jun 25 19:28:58 2017

Add PRESUMIT for accessibility_mode_enums values

Values in content/common/accessibility_mode_enums.h need to be kept in
sync with content/browser/resources/accessibility/accessibility.js. It's
easy to forget and we should have a PRESUBMIT guarding against mistakes.

BUG= 692087 

Review-Url: https://codereview.chromium.org/2852023002
Cr-Commit-Position: refs/heads/master@{#482174}

[modify] https://crrev.com/96252c9df30022a3c734bc03dea7b1c73e5de23c/content/browser/resources/accessibility/accessibility.js
[add] https://crrev.com/96252c9df30022a3c734bc03dea7b1c73e5de23c/content/common/PRESUBMIT.py
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48db56bc090cfeb1b2f1a556f0d5f21413627dd3

commit 48db56bc090cfeb1b2f1a556f0d5f21413627dd3
Author: dougt <dougt@chromium.org>
Date: Tue Jun 27 22:49:47 2017

Move AX Role predicates into ax_role_properties.h.

In prep of moving more code from BrowserAccessibility to AXPlatformNode,
there are a number of AXRole tests in the form of "Is this role a ____"
hanging off of BrowserAccessibility and in BrowserAccessibilityManagerMac.
What this CL does is adds a few more predicates in the UI:: namespace for
this sort of testing.

BUG= 692087 

Review-Url: https://codereview.chromium.org/2962453002
Cr-Commit-Position: refs/heads/master@{#482770}

[modify] https://crrev.com/48db56bc090cfeb1b2f1a556f0d5f21413627dd3/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/48db56bc090cfeb1b2f1a556f0d5f21413627dd3/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/48db56bc090cfeb1b2f1a556f0d5f21413627dd3/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/48db56bc090cfeb1b2f1a556f0d5f21413627dd3/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/48db56bc090cfeb1b2f1a556f0d5f21413627dd3/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/48db56bc090cfeb1b2f1a556f0d5f21413627dd3/content/browser/accessibility/browser_accessibility_manager_mac.mm
[modify] https://crrev.com/48db56bc090cfeb1b2f1a556f0d5f21413627dd3/content/browser/accessibility/one_shot_accessibility_tree_search.cc
[modify] https://crrev.com/48db56bc090cfeb1b2f1a556f0d5f21413627dd3/ui/accessibility/ax_role_properties.cc
[modify] https://crrev.com/48db56bc090cfeb1b2f1a556f0d5f21413627dd3/ui/accessibility/ax_role_properties.h

Comment 3 by dougt@chromium.org, Jul 13 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment