New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692085 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 650594



Sign in to add a comment

When system is descheduled PumpThrottledTasks may be called immediately

Project Member Reported by altimin@chromium.org, Feb 14 2017

Issue description

When system is descheduled (next task run time is significantly in the past) PumpThrottledTasks may be scheduled immediately, effectively removing 1 second background timer alignment. 
 
Blocking: 650594
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ded2254448f22310ab52645b57a864b281c948d

commit 0ded2254448f22310ab52645b57a864b281c948d
Author: altimin <altimin@chromium.org>
Date: Wed Feb 15 01:45:19 2017

[scheduler] Do not call PumpThrottledTasks immediately when descheduled

BUG= 692085 

Review-Url: https://codereview.chromium.org/2696833002
Cr-Commit-Position: refs/heads/master@{#450550}

[modify] https://crrev.com/0ded2254448f22310ab52645b57a864b281c948d/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc

Labels: Merge-Request-57
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 16 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
If possible, could you please merge your CL into M57 branch 2987 before 5 PM PT tomorrow, Thursday (02/16/17). Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 16 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1880d73756cedad5096f02aaf7fc2aece5e8e382

commit 1880d73756cedad5096f02aaf7fc2aece5e8e382
Author: Alexander Timin <altimin@chromium.org>
Date: Thu Feb 16 12:44:45 2017

[scheduler] Do not call PumpThrottledTasks immediately when descheduled

BUG= 692085 

Review-Url: https://codereview.chromium.org/2696833002
Cr-Commit-Position: refs/heads/master@{#450550}
(cherry picked from commit 0ded2254448f22310ab52645b57a864b281c948d)

Review-Url: https://codereview.chromium.org/2703483003 .
Cr-Commit-Position: refs/branch-heads/2987@{#546}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/1880d73756cedad5096f02aaf7fc2aece5e8e382/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc

Status: Fixed (was: Started)

Sign in to add a comment