New issue
Advanced search Search tips

Issue 692084 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 26
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Deprecate and remove `document.origin`

Project Member Reported by mkwst@chromium.org, Feb 14 2017

Issue description

With support for `self.origin`, `document.origin` is unnecessary. It adds basically zero code, but we should remove it to save developers from trying to decide which of `self.origin`, `document.origin`, or `document.location.origin` they ought to use.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52308ad80706727459885730039fdf64a35392a7

commit 52308ad80706727459885730039fdf64a35392a7
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Wed Apr 25 13:58:15 2018

Deprecate document.origin

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/0D_37iuh1zc/ndyyNaxgCQAJ

Bug:  692084 
Change-Id: Iae09a7d82e09c9bc3f0394dfa476370fd1efe516
Reviewed-on: https://chromium-review.googlesource.com/1013699
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553537}
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/dom/domparsing/domparser-document-origin.html
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/frame-ancestors/frame-ancestors-overrides-xfo.html
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/generic/common.js
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/generic/referrer-policy-test-case.js
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/fast/dom/everything-to-string-expected.txt
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/http/tests/background_fetch/block-cors-preflights.https.html
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/http/tests/media/encrypted-media/encrypted-media-encrypted-event-different-origin.html
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/http/tests/security/dangling-markup/a-ping.html
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/blob-url-script-in-sandboxed-iframe.https.html
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/http/tests/security/resources/post-origin-to-opener.html
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/http/tests/security/resources/post-origin-to-parent.html
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/http/tests/security/resources/postmessage-document-origin.html
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/http/tests/security/sandbox-inherit-to-blank-document-unsandboxed-navigate.php
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/http/tests/security/sandbox-inherit-to-blank-document-unsandboxed.php
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/WebKit/LayoutTests/http/tests/security/sandbox-inherit-to-blank-document.php
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/blink/renderer/core/dom/document.idl
[modify] https://crrev.com/52308ad80706727459885730039fdf64a35392a7/third_party/blink/renderer/core/frame/deprecation.cc

Owner: foolip@chromium.org
Summary: Deprecate and remove `document.origin` (was: Deprecate `document.origin`)

Comment 4 Deleted

Comment 5 Deleted

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67302a22412c17d86ccb8e57c2b19a558f45f206

commit 67302a22412c17d86ccb8e57c2b19a558f45f206
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Fri Sep 14 09:58:05 2018

Use self.origin instead of document.origin in tests

In preparation for removing document.origin.

Bug:  692084 
Change-Id: I24b73ef0e6e5ab0317d2d6c25faec5a4c8a54512
Reviewed-on: https://chromium-review.googlesource.com/1170686
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591315}
[modify] https://crrev.com/67302a22412c17d86ccb8e57c2b19a558f45f206/chrome/browser/chrome_navigation_browsertest.cc
[modify] https://crrev.com/67302a22412c17d86ccb8e57c2b19a558f45f206/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/67302a22412c17d86ccb8e57c2b19a558f45f206/chrome/test/data/extensions/platform_apps/web_view/load_webview_accessible_resource/embedder.js
[modify] https://crrev.com/67302a22412c17d86ccb8e57c2b19a558f45f206/chrome/test/data/subresource_filter/iframe_spoof_click_popup.html
[modify] https://crrev.com/67302a22412c17d86ccb8e57c2b19a558f45f206/content/browser/blob_storage/blob_url_browsertest.cc
[modify] https://crrev.com/67302a22412c17d86ccb8e57c2b19a558f45f206/content/browser/frame_host/frame_tree_browsertest.cc
[modify] https://crrev.com/67302a22412c17d86ccb8e57c2b19a558f45f206/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/67302a22412c17d86ccb8e57c2b19a558f45f206/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/67302a22412c17d86ccb8e57c2b19a558f45f206/content/browser/site_per_process_browsertest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dddfa8b8082c477c841d4df7a79f386d585d2e0

commit 7dddfa8b8082c477c841d4df7a79f386d585d2e0
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Sat Sep 15 21:04:59 2018

Remove document.origin

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/0D_37iuh1zc/ndyyNaxgCQAJ

Bug:  692084 
Change-Id: Ide9047f425e792c79e4758a954859f690cee29c7
Reviewed-on: https://chromium-review.googlesource.com/1169054
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591591}
[modify] https://crrev.com/7dddfa8b8082c477c841d4df7a79f386d585d2e0/third_party/WebKit/LayoutTests/dom/domparsing/domparser-detached-no-crash.html
[delete] https://crrev.com/d3358b8975bdf2127257df2b3fc9513cbb7c988f/third_party/WebKit/LayoutTests/dom/domparsing/domparser-document-origin.html
[modify] https://crrev.com/7dddfa8b8082c477c841d4df7a79f386d585d2e0/third_party/WebKit/LayoutTests/external/wpt/dom/interfaces_exclude=Node-expected.txt
[modify] https://crrev.com/7dddfa8b8082c477c841d4df7a79f386d585d2e0/third_party/WebKit/LayoutTests/fast/dom/everything-to-string-expected.txt
[rename] https://crrev.com/7dddfa8b8082c477c841d4df7a79f386d585d2e0/third_party/WebKit/LayoutTests/http/tests/security/document-domain-self-origin.html
[delete] https://crrev.com/d3358b8975bdf2127257df2b3fc9513cbb7c988f/third_party/WebKit/LayoutTests/http/tests/security/document-origin.html
[modify] https://crrev.com/7dddfa8b8082c477c841d4df7a79f386d585d2e0/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/7dddfa8b8082c477c841d4df7a79f386d585d2e0/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/7dddfa8b8082c477c841d4df7a79f386d585d2e0/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/7dddfa8b8082c477c841d4df7a79f386d585d2e0/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/7dddfa8b8082c477c841d4df7a79f386d585d2e0/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/7dddfa8b8082c477c841d4df7a79f386d585d2e0/third_party/blink/renderer/core/dom/document.idl
[modify] https://crrev.com/7dddfa8b8082c477c841d4df7a79f386d585d2e0/third_party/blink/renderer/core/frame/deprecation.cc

Comment 8 Deleted

Comment 9 Deleted

Labels: M-71
Status: Fixed (was: Assigned)

Sign in to add a comment