New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692079 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 604736
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Gerrit should show files which current set of reviewers don't have OWNERS

Project Member Reported by rmcilroy@chromium.org, Feb 14 2017

Issue description

In Rietveld, when either the Rietveld Usability Toolkit or Chromite Butler extension is enabled (sorry I can't remember which extension adds this), the code review tool will show green/red boxes at the side of files to show whether you have reviews on the CL which own those files.  I found this really useful to ensure I had the right reviewers on a CL.

The tool would also create a list of potential reviewers on a new CL, and mousing over an reviewer would highlight the set of files which that reviewer was an OWNER for.

Any chance these features could be added to PolyGerrit?
 
Cc: vikt...@google.com aga...@chromium.org
Labels: -Milestone-Dogfood Milestone-Afterglow
Status: Available (was: Untriaged)
This is likely to implemented via a Gerrit plugin (at least at first).

Including relevant plugin and migration people...

Comment 2 by aga...@chromium.org, Feb 14 2017

Those are great features! Those are great features that were added by extensions and never actually part of the product. We'd love to have them, but they're not at the top of our list of improvements, and certainly aren't blocking. Long story short, we'd love to add this, but for the immediate future, patches are welcome :) We'll revisit this after launch.

(Aside: I'm 90% sure it's the Chromite Butler extension, since I used RUT all the time and never had OWNERS information.)


Someone on Android is working on a find-owners plugin: go/android-owners

Definitely chime in if you have any specific concerns or feature requests :)
Mergedinto: 604736
Status: Duplicate (was: Available)

Sign in to add a comment