New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692077 link

Starred by 13 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 685901



Sign in to add a comment

Common shortcuts (Cmd+T, Cmd+Tab, etc.) don't work on full screen

Reported by sslozan...@gmail.com, Feb 14 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3012.0 Safari/537.36

Steps to reproduce the problem:
1. Put Chrome on fullscreen (using Mac OSX)
2. Using shortcuts, try to open a new tab
3. 

What is the expected behavior?
It should open a new tab

What went wrong?
No tab is open, it does nothing. It doesn't even play an error sound or anything alike. The options appear disabled too in the menu bar, as shown in the attached picture.

Did this work before? Yes 

Chrome version: 58.0.3012.0  Channel: canary
OS Version: OS X 10.12.3
Flash Version: Shockwave Flash 25.0 r0

Tried in incognito, it didn't work either. Tried on a stable version of Chrome installed in the same Mac and everything worked perfectly.

 
Labels: Canary-Feedback Hotlist-ConOps
Forum : https://productforums.google.com/forum/#!topic/chrome/yZjyfP-oe1Q
Components: UI>Browser>Core
Labels: M-58
We have some reports about this in feedback as well.
Chrome : 58.0.3011.0
Mac OS : 10.12.3
Could this be related to 
commit	df183ec6ada211dda086eda5b3bb940f7802ca9f	
author	dvallet <dvallet@chromium.org>	Mon Feb 13 04:49:49 2017
committer	Commit bot <commit-bot@chromium.org>	Mon Feb 13 04:49:49 2017
Remove code and minimize references to aura as to facilitate refractoring needed for Mac headless
BUG= 687407 

Review-Url: https://codereview.chromium.org/2669693002
Cr-Commit-Position: refs/heads/master@{#449909}
Labels: Needs-Triage-M58 Needs-Bisect
Cc: sureshkumari@chromium.org
Labels: -Pri-2 -Needs-Bisect -Needs-Triage-M58 hasbisect-per-revision ReleaseBlock-Stable Pri-1
Owner: zijiehe@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Mac 10.12.2 using chrome canary 58.0.3012.0
This is regression issue broken in M58.Please find the bisect information as below
Narrow Bisect::
===============
Good::58.0.3010.0 --   (build revision 449855)
Bad:: 58.0.3011.0 --   (build revision 449903)

ChangeLog: 
===========
https://chromium.googlesource.com/chromium/src/+log/1a8d5f3805dbae5242cf7dce14df3807344dae37..3c7af99a93f4b4837b2fbee5cb66697f66ccf241

Review-Url: https://codereview.chromium.org/2636013002

zijiehe@ could you please look into this issue if it is related to your change, else please help us in finding the appropriate owner for this issue.

Note:Issue not observed in Windows-7 and Linux Ubuntu-14.04.

Adding ReleaseBlock-Stable label as it is recent regression.

Thanks.

Comment 6 by rpad...@gmail.com, Feb 15 2017

Able to reproduce the issue on Mac 10.11.6, Canary 58.0.3013.0
greyed out commands @ fullscreen.
Captura de Tela 2017-02-15 às 08.22.49.png
27.8 KB View Download
This is by-design. Intent to implement and Ship of the feature is @ https://goo.gl/4tJ32G.

Comment 8 by shrike@chromium.org, Feb 15 2017

Blocking: 685901
Cc: rpop@chromium.org
The logic behind the basic idea of funneling all keyboard shortcuts to the web content is reasonable, however I don't think it works well in practice (or certainly not in all cases). On the Mac at least there's an option to always keep the toolbar (and tabstrip) visible. With the top chrome visible in this case it's a real problem not having keyboard shortcuts working. What's worse, the way the shortcuts were disabled was by disabling the menu commands instead of temporarily removing the shortcuts from the menu commands. This means that it is no longer possible to, for example, reopen a closed tab in fullscreen mode.

The issue of the disabling of menu items is a bug. I am working on a fix @ https://codereview.chromium.org/2689383002/.
That's good, but a blanket disable of keyboard shortcuts in fullscreen is still a problem. I see that if I have the toolbar visible and the window contains multiple tabs, I can use Cmd-Option-[arrow key] to move between my tabs.

Basically, if the top chrome is showing my keyboard shortcuts should work.
Cc: zijiehe@chromium.org dominickn@chromium.org shrike@chromium.org
 Issue 692421  has been merged into this issue.
Labels: -ReleaseBlock-Stable ReleaseBlock-Beta
Cc: jamiewa...@chromium.org
Sorry for the lack of Mac knowledge. I think we can work together to detect the visibility of the menu and tab on Mac, and change the behavior.
Also add Jamie to the thread.

Comment 14 Deleted

#10: since crrev.com/2698013004 landed, there is no blanket disable of keyboard shortcuts in fullscreen. Shortcuts will still work unless the web page explicitly captures them. That CL hasn't made it to Canary yet but should later today. I've manually verified the fix on tip of tree.

The key reservation logic should definitely be tuned such that if the toolbar and tabs are visible on Mac, browser shortcuts are still regarded as reserved (and thus non-capturable). I think this specific issue (shortcuts don't work in fullscreen on Mac) is fixed by crrev.com/2698013004, and can now be closed. It's a separate issue that shortcuts should not be allowed to be overridden if Mac is in the fullscreen-with-top-Chrome mode - perhaps we should have a new bug for that.
I do hope the proposal to remove keyb shortcuts from Full Screen chrome doesn't go forward.
I spend the day in dozens of Full Screen windows with dozens of pages.
not being able to open/close new ones via keyboard would considerably slow my performance. 
c#15 - thank you for addressing our concerns (I very much appreciate it). I'm looking forward to testing out crrev.com/2698013004 once it lands. I agree that should mean we can close out this bug and we should open a new one for fullscreen-with-top-chrome.
Re: c#17, that new bug is  Issue 693613 .
#17: the CL has now made it to Canary. I think we can close this one as fixed and move over to  issue 693613 , but I'll wait for your verification.
Labels: TE-Verified-58.0.3020.0
Verified the fix on Latest Canary#58.0.3020.0 for Mac OS X 10.12.3 - Working as intended.

Thank you!
fixed in Dev
58.0.3018.3 (Official Build) dev (64-bit)
Revision	9f90720567a93b798d314c9d4af6bdd092a07767-refs/branch-heads/3018@{#5}

(i really hate these new recaptcha.....)
Status: Fixed (was: Assigned)

Sign in to add a comment