New issue
Advanced search Search tips

Issue 692073 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Create context menu for ContentSuggestions

Project Member Reported by gambard@chromium.org, Feb 14 2017

Issue description

When long pressing on a article in content suggestion, we should display a context menu letting the user open in new tab, open in new incognito tab or delete it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b6abde6cad9c609e4961e2149aafd328bfa19a5

commit 9b6abde6cad9c609e4961e2149aafd328bfa19a5
Author: gambard <gambard@chromium.org>
Date: Mon Feb 20 12:13:55 2017

Add context menu for ContentSuggestions

This CL adds a context menu for ContentSuggestions and a way to open the
article by tapping it.
The context menu does nothing for deletion for now.

BUG= 692073 

Review-Url: https://codereview.chromium.org/2691303002
Cr-Commit-Position: refs/heads/master@{#451602}

[modify] https://crrev.com/9b6abde6cad9c609e4961e2149aafd328bfa19a5/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/9b6abde6cad9c609e4961e2149aafd328bfa19a5/ios/chrome/browser/content_suggestions/BUILD.gn
[modify] https://crrev.com/9b6abde6cad9c609e4961e2149aafd328bfa19a5/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.h
[modify] https://crrev.com/9b6abde6cad9c609e4961e2149aafd328bfa19a5/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/9b6abde6cad9c609e4961e2149aafd328bfa19a5/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/9b6abde6cad9c609e4961e2149aafd328bfa19a5/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h
[modify] https://crrev.com/9b6abde6cad9c609e4961e2149aafd328bfa19a5/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm
[modify] https://crrev.com/9b6abde6cad9c609e4961e2149aafd328bfa19a5/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h
[modify] https://crrev.com/9b6abde6cad9c609e4961e2149aafd328bfa19a5/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Status: Fixed (was: Assigned)

Sign in to add a comment