Would be good to track a few use cases that we want to get covered (ideally with a test target) so that we can properly prioritize this bug and know when it's don e :-)

I'd like two things:

- The fakebox, in particular how it redirects input to the omnibox. This also serves as a smoke test for the embeddedSearch.searchBox API, which will be helpful e.g. for  bug 631937 .

- A test for the NTP tiles, making sure the default tiles get loaded correctly. This got broken during a recent refactoring, see  bug 681749 .

I think a fully comprehensive test suite, e.g. with blacklisting tiles and undoing it again, might not be necessary. The above tests will make sure all the APIs are hooked up correctly; more tests would probably not improve the signal-to-noise ratio. WDYT?

I think it's a good first step and reasonable for blocking the NTP switch.
Of course more test coverage would be better, but we need to prioritize that work then and it probably shouldn't block the other efforts.
Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af71c6b09dc5bd882f2f2018050c2902a92e024b

commit af71c6b09dc5bd882f2f2018050c2902a92e024b
Author: treib <treib@chromium.org>
Date: Wed Feb 15 15:31:39 2017

[Local NTP] Add an integration test for the fakebox

BUG= 692002 

Review-Url: https://codereview.chromium.org/2691033004
Cr-Commit-Position: refs/heads/master@{#450706}

[modify] https://crrev.com/af71c6b09dc5bd882f2f2018050c2902a92e024b/chrome/browser/ui/search/instant_test_utils.cc
[modify] https://crrev.com/af71c6b09dc5bd882f2f2018050c2902a92e024b/chrome/browser/ui/search/instant_test_utils.h
[modify] https://crrev.com/af71c6b09dc5bd882f2f2018050c2902a92e024b/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/af71c6b09dc5bd882f2f2018050c2902a92e024b/chrome/test/data/local_ntp_browsertest.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f955fb9cd61c9b6b246a9484a60068eb38c54aec

commit f955fb9cd61c9b6b246a9484a60068eb38c54aec
Author: treib <treib@chromium.org>
Date: Thu Feb 16 19:45:08 2017

[Local NTP] Add a simple test for embeddedSearch.newTabPage.mostVisited

BUG= 692002 

Review-Url: https://codereview.chromium.org/2703613002
Cr-Commit-Position: refs/heads/master@{#451059}

[modify] https://crrev.com/f955fb9cd61c9b6b246a9484a60068eb38c54aec/chrome/test/data/local_ntp_browsertest.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be5176536dd8dafc48fb719ad718a16d84caad0e

commit be5176536dd8dafc48fb719ad718a16d84caad0e
Author: treib <treib@chromium.org>
Date: Mon Feb 20 13:46:56 2017

[Local NTP] Add an integration test for the most visited iframe

BUG= 692002 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2695813012
Cr-Commit-Position: refs/heads/master@{#451617}

[modify] https://crrev.com/be5176536dd8dafc48fb719ad718a16d84caad0e/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/be5176536dd8dafc48fb719ad718a16d84caad0e/chrome/browser/ui/search/instant_test_utils.cc
[modify] https://crrev.com/be5176536dd8dafc48fb719ad718a16d84caad0e/chrome/browser/ui/search/instant_test_utils.h
[modify] https://crrev.com/be5176536dd8dafc48fb719ad718a16d84caad0e/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/be5176536dd8dafc48fb719ad718a16d84caad0e/chrome/test/data/local_ntp_browsertest.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/769bc0d70e165bfea010611d8eb3065e6fa6f1d0

commit 769bc0d70e165bfea010611d8eb3065e6fa6f1d0
Author: treib <treib@chromium.org>
Date: Tue Feb 21 13:16:12 2017

[Local NTP] Add a test for embeddedSearch API availability

BUG= 692002 

Review-Url: https://codereview.chromium.org/2704373002
Cr-Commit-Position: refs/heads/master@{#451750}

[modify] https://crrev.com/769bc0d70e165bfea010611d8eb3065e6fa6f1d0/chrome/browser/ui/search/local_ntp_browsertest.cc

Marking fixed, since we now IMO have enough tests to unblock the other work. Of course, test coverage could always be improved further :)