New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 691986 link

Starred by 3 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Feb 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary 'Recently closed' option is seen enabled on history overlay.

Reported by lpa...@etouch.net, Feb 14 2017 
Chrome Version: 58.0.3012.0 (Official Build) 66847e854d3acd13965764bcbc72d38f455c463c-refs/heads/master@{#450199}(64-bit)

OS: Windows(7,8,8.1,10), Linux (14.04 LTS)

Steps to reproduce:
1. Freshly install and launch chrome, click on wrench icon and hover mouse on 'History' option.
2. Observe 'Recently closed' option.

Actual Result: Recently closed option is seen enabled for freshly launched chrome and nothing is happened after clicking on it.
Expected Result: Recently closed option should be in disabled form.

This is regression issue broken in 'M 55' and will soon update the bisect info.

Manual Bisect Info: 
Good Build 55.0.2880.0
Bad Build 55.0.2881.0

Note: Issue is not reproducible in MAC.
Actual result.mp4
750 KB View Download
Expected Result.mp4
864 KB View Download

Comment 1 by rbasuvula@chromium.org, Feb 14 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2880.0 (Revision: 422654).
Bad build: 55.0.2881.0 (Revision: 423030).

You are probably looking for a change made after 422664 (known good), but no later than 422665 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/55e6683f5fad4e9ee67af77ffc2300cf4198c195..f02568a216b975130849079183cc0f7173d6b832

From the CL above, assigning the issue to the concern owner

@estade:Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2382443007
Note:1.Able to reproduce the issue in Win 10.0,Ubuntu 14.04 not in Mac 10.12.2 and able to reproduce in latest canary #58.0.3012.0

Comment 2 by est...@chromium.org, Feb 15 2017 

yea, looks like my fault
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c16383b5973aa220cb24ae2b14f589f5e994baa

commit 0c16383b5973aa220cb24ae2b14f589f5e994baa
Author: estade <estade@chromium.org>
Date: Fri Feb 17 00:07:43 2017

Don't use bold text for the "no recently closed tabs" menu item.

BUG= 691986 

Review-Url: https://codereview.chromium.org/2698613003
Cr-Commit-Position: refs/heads/master@{#451146}

[modify] https://crrev.com/0c16383b5973aa220cb24ae2b14f589f5e994baa/chrome/browser/ui/views/toolbar/app_menu.cc

Comment 4 by est...@chromium.org, Feb 17 2017

Status: Fixed (was: Assigned)
already shipped a couple times with this bug; it's a minor graphical glitch; I vote no merge.

Comment 5 by jmukthavaram@chromium.org, Feb 21 2017

Labels: TE-Verified-M58 TE-Verified-58.0.3018.0
Tested the issue on windows 7 & Linux Ubuntu 14.04 using chrome version#58.0.3018.0 with the steps mentioned in comment #0. 
Recently closed option is in disabled form for a freshly onstalled chrome.Hence adding TE-Verified labels.
Please find the attached screencast for the same.
Thanks!!
691986.png
145 KB View Download
►

Sign in to add a comment