New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691979 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Add metrics for ContentSuggestions

Project Member Reported by gambard@chromium.org, Feb 14 2017

Issue description

This bug will be used as placeholder in the code.
 

Comment 1 by cma...@chromium.org, Mar 10 2017

Components: UI>Browser>Omnibox
Cc: cma...@chromium.org
Can someone explain what ContentSuggestions are and how it relates to the omnibox?  I'm an omnibox owner and this is the first I've heard of it.

Comment 3 by cma...@chromium.org, Mar 11 2017

Components: -UI>Browser>Omnibox UI>Browser>NewTabPage
Sorry mpearson@, that was a mistake. 
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8721eb90586b45d5fa4e3483f11cfce9a8131f92

commit 8721eb90586b45d5fa4e3483f11cfce9a8131f92
Author: gambard <gambard@chromium.org>
Date: Thu Jul 13 11:18:37 2017

Add missing user actions for Reading List

Reading List user actions were missing log when opening from the NTP
and from the swipe next gesture. This CL fixes it.

Bug:  691979 
Change-Id: I0170d855211abc4eaa625bce9683370f528b18de
Reviewed-on: https://chromium-review.googlesource.com/569164
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486341}
[modify] https://crrev.com/8721eb90586b45d5fa4e3483f11cfce9a8131f92/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/8721eb90586b45d5fa4e3483f11cfce9a8131f92/ios/chrome/browser/ui/reading_list/reading_list_side_swipe_provider.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/774e70de89a31e9cd817459e4f91093610ae94dd

commit 774e70de89a31e9cd817459e4f91093610ae94dd
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Aug 24 14:08:56 2017

Add NTP impressions metrics

This CL adds metrics recording for types of NTP impressions.

Bug:  691979 
Change-Id: I9c512d81abb25993c714c7d4346918eb1922caea
Reviewed-on: https://chromium-review.googlesource.com/625898
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497031}
[modify] https://crrev.com/774e70de89a31e9cd817459e4f91093610ae94dd/ios/chrome/browser/content_suggestions/BUILD.gn
[modify] https://crrev.com/774e70de89a31e9cd817459e4f91093610ae94dd/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[add] https://crrev.com/774e70de89a31e9cd817459e4f91093610ae94dd/ios/chrome/browser/content_suggestions/ntp_home_metrics.h
[add] https://crrev.com/774e70de89a31e9cd817459e4f91093610ae94dd/ios/chrome/browser/content_suggestions/ntp_home_metrics.mm
[modify] https://crrev.com/774e70de89a31e9cd817459e4f91093610ae94dd/ios/chrome/browser/ui/content_suggestions/ntp_home_constant.h
[modify] https://crrev.com/774e70de89a31e9cd817459e4f91093610ae94dd/ios/clean/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/774e70de89a31e9cd817459e4f91093610ae94dd/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm
[modify] https://crrev.com/774e70de89a31e9cd817459e4f91093610ae94dd/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/774e70de89a31e9cd817459e4f91093610ae94dd/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3bf246c04d29c2435ee0ab53e5b28e48a836540

commit a3bf246c04d29c2435ee0ab53e5b28e48a836540
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Aug 25 07:15:30 2017

Add metrics for NTP actions

Adds metrics to know how the user leaves the NTP.

Bug:  691979 
Change-Id: I7728d5a6f5b5b7b71e1657dea9f0b1f2feb6474e
Reviewed-on: https://chromium-review.googlesource.com/626137
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497343}
[modify] https://crrev.com/a3bf246c04d29c2435ee0ab53e5b28e48a836540/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/a3bf246c04d29c2435ee0ab53e5b28e48a836540/ios/chrome/browser/metrics/new_tab_page_uma.h
[modify] https://crrev.com/a3bf246c04d29c2435ee0ab53e5b28e48a836540/ios/chrome/browser/ui/reading_list/BUILD.gn
[modify] https://crrev.com/a3bf246c04d29c2435ee0ab53e5b28e48a836540/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm
[modify] https://crrev.com/a3bf246c04d29c2435ee0ab53e5b28e48a836540/ios/chrome/browser/ui/reading_list/reading_list_side_swipe_provider.mm
[modify] https://crrev.com/a3bf246c04d29c2435ee0ab53e5b28e48a836540/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/a3bf246c04d29c2435ee0ab53e5b28e48a836540/tools/metrics/histograms/histograms.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dda63ca13d1b98ca34f0cd52c4135bf9ffc5dfd

commit 8dda63ca13d1b98ca34f0cd52c4135bf9ffc5dfd
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Aug 25 12:58:06 2017

Record metrics when the user toggles suggestions

As new suggestions are added to the NTP, it is possible that users
disable them. A metric need to be added to measure it.

Bug:  691979 
Change-Id: I781aee05d8a8db8a30aaa63eb5793dc4c4c6068e
Reviewed-on: https://chromium-review.googlesource.com/635283
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497384}
[modify] https://crrev.com/8dda63ca13d1b98ca34f0cd52c4135bf9ffc5dfd/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7261b7d4181ce398889ed3fc1f56e546daca2bc0

commit 7261b7d4181ce398889ed3fc1f56e546daca2bc0
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Aug 25 14:40:21 2017

Add metrics for ContentSuggestions

Metrics for Content Suggestions need to be recorded for iOS.
This CL adds a way to record them.

Bug:  691979 
Change-Id: I0f9affaaac3cf8bf49ccb9ad60d269385bad842d
Reviewed-on: https://chromium-review.googlesource.com/626057
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497404}
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/content_suggestions/BUILD.gn
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/content_suggestions/content_suggestions_alert_factory.mm
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[add] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/content_suggestions/content_suggestions_metrics_recorder.h
[add] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/content_suggestions/content_suggestions_metrics_recorder.mm
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/content_suggestions/mediator_util.mm
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.h
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_learn_more_item.mm
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_whats_new_item.mm
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ui/content_suggestions/cells/suggested_content.h
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h
[add] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ui/content_suggestions/content_suggestions_metrics_recording.h
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/showcase/content_suggestions/sc_content_suggestions_item.mm
[modify] https://crrev.com/7261b7d4181ce398889ed3fc1f56e546daca2bc0/ios/showcase/content_suggestions/sc_content_suggestions_most_visited_item.mm

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bde69acf1d28947f2fe3ed06e525937da9ba8ed

commit 4bde69acf1d28947f2fe3ed06e525937da9ba8ed
Author: Eugene But <eugenebut@chromium.org>
Date: Fri Aug 25 22:36:12 2017

Revert "Add metrics for ContentSuggestions"

This reverts commit 7261b7d4181ce398889ed3fc1f56e546daca2bc0.

Reason for revert:

Breaks SCContentSuggestionsTestCase:
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone10-simulator/builds/7242

Original change's description:
> Add metrics for ContentSuggestions
> 
> Metrics for Content Suggestions need to be recorded for iOS.
> This CL adds a way to record them.
> 
> Bug:  691979 
> Change-Id: I0f9affaaac3cf8bf49ccb9ad60d269385bad842d
> Reviewed-on: https://chromium-review.googlesource.com/626057
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
> Reviewed-by: edchin <edchin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497404}

TBR=treib@chromium.org,olivierrobin@chromium.org,edchin@chromium.org,gambard@chromium.org,gchatz@chromium.org

Change-Id: Iced479e2095063e7e6867248595b3a00a8c8fdb0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  691979 
Reviewed-on: https://chromium-review.googlesource.com/636228
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497568}
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/content_suggestions/BUILD.gn
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/content_suggestions/content_suggestions_alert_factory.mm
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[delete] https://crrev.com/9c9b713124428e1b7e2fb967904fba857ebac291/ios/chrome/browser/content_suggestions/content_suggestions_metrics_recorder.h
[delete] https://crrev.com/9c9b713124428e1b7e2fb967904fba857ebac291/ios/chrome/browser/content_suggestions/content_suggestions_metrics_recorder.mm
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/content_suggestions/mediator_util.mm
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.h
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_learn_more_item.mm
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_whats_new_item.mm
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/ui/content_suggestions/cells/suggested_content.h
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h
[delete] https://crrev.com/9c9b713124428e1b7e2fb967904fba857ebac291/ios/chrome/browser/ui/content_suggestions/content_suggestions_metrics_recording.h
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/showcase/content_suggestions/sc_content_suggestions_item.mm
[modify] https://crrev.com/4bde69acf1d28947f2fe3ed06e525937da9ba8ed/ios/showcase/content_suggestions/sc_content_suggestions_most_visited_item.mm

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4337a964248a07077162ee2f912689345a7aa5b8

commit 4337a964248a07077162ee2f912689345a7aa5b8
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Aug 29 09:43:44 2017

Reland "Add metrics for ContentSuggestions"

Metrics for Content Suggestions need to be recorded for iOS.
This CL adds a way to record them.

Bug:  691979 
Change-Id: I19d90c53396b51942a7577921f0455d354cf1d91
Reviewed-on: https://chromium-review.googlesource.com/636372
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498063}
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/content_suggestions/BUILD.gn
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/content_suggestions/content_suggestions_alert_factory.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[add] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/content_suggestions/content_suggestions_metrics_recorder.h
[add] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/content_suggestions/content_suggestions_metrics_recorder.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/content_suggestions/mediator_util.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.h
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_learn_more_item.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_whats_new_item.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ui/content_suggestions/cells/suggested_content.h
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h
[add] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ui/content_suggestions/content_suggestions_metrics_recording.h
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/showcase/content_suggestions/sc_content_suggestions_egtest.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/showcase/content_suggestions/sc_content_suggestions_item.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/showcase/content_suggestions/sc_content_suggestions_most_visited_item.mm
[modify] https://crrev.com/4337a964248a07077162ee2f912689345a7aa5b8/ios/showcase/test/showcase_eg_utils.mm

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01924a2f4e741645ea3f9de01a0dc229d12502fc

commit 01924a2f4e741645ea3f9de01a0dc229d12502fc
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Aug 29 11:33:02 2017

Record metrics only for ContentSuggestionsItem

The metric recorded when a Suggested item is shown should only be
recorded for the ContentSuggestionsItem.

Bug:  691979 
Change-Id: I4191325821001d5eecad90ae21991bd859d8fa70
Reviewed-on: https://chromium-review.googlesource.com/640707
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498074}
[modify] https://crrev.com/01924a2f4e741645ea3f9de01a0dc229d12502fc/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Labels: -Type-Bug Type-Task
Status: Fixed (was: Assigned)

Sign in to add a comment