New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691978 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

content_unittests compile failure in non WebRTC enabled builds

Project Member Reported by grunell@chromium.org, Feb 14 2017

Issue description

Build with
enable_webrtc = false

In file included from ../../content/browser/media/capture/web_contents_video_capture_device_unittest.cc:44:
In file included from ../../third_party/libyuv/include/libyuv.h:15:
../../third_party/libyuv/include/libyuv/compare.h:14:10: fatal error: 'libyuv/basic_types.h' file not found
#include "libyuv/basic_types.h"

It's due to https://chromium.googlesource.com/chromium/src/+/6e361a1ded1c63b390f686fdab4903e18cbab35b
 
It doesn't seem right that the webrtc flag should affect this code and build setup. Dale, it seems your CL didn't touch anything WebRTC related. Do you have any clues to this? Otherwise hand it back and I'll re-assign.
Cc: kjellander@chromium.org
CC kjellander do you have any ideas?

"It's due to" in the report should be "It started with".
Can you provide links to failing bots? Our bots in chromium.webrtc and chromium.webrtc.fyi builds that test and they're all green.
There are no bots building with WebRTC disabled. This was a local test build I did working on something unrelated.
Ah, I managed to invert the meaning of "enable_webrtc = false" in my head when reading. 

As you say we don't have any bots that build with WebRTC disabled. In general, I'm not sure it is our responsibility to ensure the build is green when our code is disabled - should we own that? I'd vote for getting rid of the variable entirely instead.
The build dependencies file is missing a //third_party/libyuv link which it previously got transitively from media. Will fix the build fine.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b747aadfaf157b30dff0d5eb499c39d3f45c5b9

commit 4b747aadfaf157b30dff0d5eb499c39d3f45c5b9
Author: dalecurtis <dalecurtis@chromium.org>
Date: Tue Feb 14 23:26:46 2017

Fix missing libyuv dependency on WebRTC unittests.

BUG= 691978 
TEST=gn

Review-Url: https://codereview.chromium.org/2695123002
Cr-Commit-Position: refs/heads/master@{#450510}

[modify] https://crrev.com/4b747aadfaf157b30dff0d5eb499c39d3f45c5b9/content/test/BUILD.gn

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Builds fine now. Thanks for the quick fix.
Re comment #5: I don't know who (if any) builds with WebRTC disabled nowadays. Could be worth finding out if it can be removed. I don't think we need to own it if kept, but in my case I added conditional code using the flag and had to do extra work (find the culprit CL, revert locally and temporarily) to be able to verify my changes. Minor extra work in this case, doesn't motivate infrastructure for this.

Sign in to add a comment