New issue
Advanced search Search tips

Issue 691965 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 673825



Sign in to add a comment

CrSettingsLanguagesTest.Languages and CrSettingsRouteTest.All of browser_tests is flaky on Win7 bots

Project Member Reported by tyoshino@chromium.org, Feb 14 2017

Issue description

Maybe caused by https://codereview.chromium.org/2573943002 ?
Summary: CrSettingsLanguagesTest.Languages and CrSettingsRouteTest.All of browser_tests is flaky on Win7 bots (was: CrSettingsLanguagesTest.Languages of browser_tests is flaky on Win7 bots)
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CrSettingsRouteTest

CrSettingsRouteTest.All is also flaky after the patch (comment #1) on "Linux ChromiumOS Tests (dbg)(1)" bot and "Win7 Tests (dbg)(1)" bot.
Components: Tests>Flaky
CRSettingsRouteTest.All now flaked on ChromiumOS Linux ASan/LSan as well.

Here's the stderr: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/19541/steps/browser_tests/logs/CrSettingsRouteTest.All

But it seems to be a different problem; this one seems to be in ResourceProvider::GetResource() not being CalledOnValidThread(). The Win7 failures are accessibility.

Comment 5 by dpa...@chromium.org, Feb 14 2017

Cc: dbeam@chromium.org
Labels: -Pri-3 Proj-MaterialDesign-WebUI Pri-2

Comment 7 by dpa...@chromium.org, Feb 14 2017

Blocking: 673825
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7034ccc67cda1cb860cf0fa236c1fad2ad8409a

commit e7034ccc67cda1cb860cf0fa236c1fad2ad8409a
Author: dpapad <dpapad@chromium.org>
Date: Wed Feb 15 07:54:14 2017

MD Settings: Disable tests for ASAN bots.

JS unit tests do not exercise the C++ handlers, so there is no value in running
them in ASAN bots.

BUG=691965

Review-Url: https://codereview.chromium.org/2690303003
Cr-Commit-Position: refs/heads/master@{#450632}

[modify] https://crrev.com/e7034ccc67cda1cb860cf0fa236c1fad2ad8409a/chrome/test/BUILD.gn
[modify] https://crrev.com/e7034ccc67cda1cb860cf0fa236c1fad2ad8409a/chrome/test/data/webui/settings/cr_settings_browsertest.js

Comment 9 by perkj@chromium.org, Feb 15 2017

Labels: -Hotlist-Sheriff-Chromium
Diabled CrSettingsRouteTest.Languages here https://codereview.chromium.org/2695213002/
Was this flaking even after rolling back (https://codereview.chromium.org/2693113002/)?
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd4c19f45d6e2bba69f9668516a829f39ca9a1f

commit 6bd4c19f45d6e2bba69f9668516a829f39ca9a1f
Author: dbeam <dbeam@chromium.org>
Date: Fri Feb 17 06:15:07 2017

WebUI: disable optimizations (vulcanize) in debug builds

When enable_vulcanize = true, HTML/CSS and JS are combined and optimized.
This takes a little more build-time work, but produces faster pages
for users but also munges the code a bunch.

Let's disable the extra compile-time stuff and make the code cleaner
for developers (i.e. in debug builds by default).

R=sky@chromium.org
BUG= 673825 ,691965

Review-Url: https://codereview.chromium.org/2654723002
Cr-Commit-Position: refs/heads/master@{#451240}

[modify] https://crrev.com/6bd4c19f45d6e2bba69f9668516a829f39ca9a1f/chrome/common/features.gni

Labels: Hotlist-MD-Settings-Tests

Sign in to add a comment