New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691959 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Regression: Grey focus highlight is seen chopped on chrome://md-settings

Reported by jshan...@etouch.net, Feb 14 2017

Issue description

Chrome Version:58.0.3012.0 (Official Build) 66847e854d3acd13965764bcbc72d38f455c463c-refs/heads/master@{#450199}(32/64-bit)
OS : Mac(10.12.1, 10.11.6, 10.12), Windows(7,8,10),(Linux 14.04)

Steps:
1. Launch Chrome and navigate to chrome://md-settings/help
2. Press tab key until round grey focus is seen on 'Report an issue'
3. Observe

Actual: Grey focus highlight is seen chopped 

Expected: Grey focus highlight should not be seen chopped

This is a Regression issue broken in M-58,will soon update other info.

Good build:58.0.3009.0 
Bad build:58.0.3010.0 

Note: Above issue is seen at many place on chrome://md-settings, ex. Spell check, Import bookmarks and settings etc.
 
Actual_result.jpg
82.5 KB View Download
Expected_result.jpg
84.6 KB View Download
Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: chrishtr@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build -- 58.0.3009.0 (revision : 449802)
Bad Build  -- 58.0.3011.0 (revision : 450199)

You are probably looking for a change made after 449898 (known good), but no later than 449899 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/09885722cd8637e59680a1996bac98454cad4bf7..56850c99e856e368af5f440d75d8e8bdb13608f1

@chirshtr -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You.
 Issue 691960  has been merged into this issue.
Labels: -Pri-3 ReleaseBlock-Stable Pri-2
With the GeometryMapper code path, the background rect for 
DIV class='wave' is ,0 39.5x39.5 instead of 0,0 40x40. It appears
there is either a rounding or subpixel issue. Digging
further.
Components: Blink>Paint
The problem is incorrect pixel-snapping in PaintPropertyTreebuilder::updateOverflowClip.
Cc: chrishtr@chromium.org kavvaru@chromium.org durga.behera@chromium.org brajkumar@chromium.org ajha@chromium.org
 Issue 691963  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19b6d116165378bc06ae204d74b5b1da58caa9ab

commit 19b6d116165378bc06ae204d74b5b1da58caa9ab
Author: chrishtr <chrishtr@chromium.org>
Date: Fri Feb 17 02:28:24 2017

Don't pixel-snap overflow clips in clip paint property nodes.

Pixel-snapping should be applied at "paint" time instead, based on context
which includes subpixel accumulation.

Also, adds code to apply subpixel accumulation for overflow clip rects applied
to background clip rects.

BUG= 691959 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2701523003
Cr-Commit-Position: refs/heads/master@{#451189}

[modify] https://crrev.com/19b6d116165378bc06ae204d74b5b1da58caa9ab/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/19b6d116165378bc06ae204d74b5b1da58caa9ab/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/19b6d116165378bc06ae204d74b5b1da58caa9ab/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
[modify] https://crrev.com/19b6d116165378bc06ae204d74b5b1da58caa9ab/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/19b6d116165378bc06ae204d74b5b1da58caa9ab/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Status: Fixed (was: Started)
Cc: rbasuvula@chromium.org
 Issue 693394  has been merged into this issue.
Labels: TE-Verified-M58 TE-Verified-58.0.3018.0
Verified this issue on Windows 10, Mac 10.12.3 and Ubuntu 14.04 with chrome dev #58.0.3018.0

Didn't observe any chopping on grey focus, attached the screen-cast for reference.

Hence Adding TE-Verified labels.
Issue 691959.png
78.1 KB View Download

Sign in to add a comment