Regression: Grey focus highlight is seen chopped on chrome://md-settings
Reported by
jshan...@etouch.net,
Feb 14 2017
|
|||||||
Issue descriptionChrome Version:58.0.3012.0 (Official Build) 66847e854d3acd13965764bcbc72d38f455c463c-refs/heads/master@{#450199}(32/64-bit) OS : Mac(10.12.1, 10.11.6, 10.12), Windows(7,8,10),(Linux 14.04) Steps: 1. Launch Chrome and navigate to chrome://md-settings/help 2. Press tab key until round grey focus is seen on 'Report an issue' 3. Observe Actual: Grey focus highlight is seen chopped Expected: Grey focus highlight should not be seen chopped This is a Regression issue broken in M-58,will soon update other info. Good build:58.0.3009.0 Bad build:58.0.3010.0 Note: Above issue is seen at many place on chrome://md-settings, ex. Spell check, Import bookmarks and settings etc.
,
Feb 14 2017
Issue 691960 has been merged into this issue.
,
Feb 15 2017
,
Feb 15 2017
With the GeometryMapper code path, the background rect for DIV class='wave' is ,0 39.5x39.5 instead of 0,0 40x40. It appears there is either a rounding or subpixel issue. Digging further.
,
Feb 16 2017
The problem is incorrect pixel-snapping in PaintPropertyTreebuilder::updateOverflowClip.
,
Feb 16 2017
Issue 691963 has been merged into this issue.
,
Feb 16 2017
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19b6d116165378bc06ae204d74b5b1da58caa9ab commit 19b6d116165378bc06ae204d74b5b1da58caa9ab Author: chrishtr <chrishtr@chromium.org> Date: Fri Feb 17 02:28:24 2017 Don't pixel-snap overflow clips in clip paint property nodes. Pixel-snapping should be applied at "paint" time instead, based on context which includes subpixel accumulation. Also, adds code to apply subpixel accumulation for overflow clip rects applied to background clip rects. BUG= 691959 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2701523003 Cr-Commit-Position: refs/heads/master@{#451189} [modify] https://crrev.com/19b6d116165378bc06ae204d74b5b1da58caa9ab/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/19b6d116165378bc06ae204d74b5b1da58caa9ab/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp [modify] https://crrev.com/19b6d116165378bc06ae204d74b5b1da58caa9ab/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp [modify] https://crrev.com/19b6d116165378bc06ae204d74b5b1da58caa9ab/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/19b6d116165378bc06ae204d74b5b1da58caa9ab/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/029bc0cf9e019f9c3c1281e89a1970ca57fe62f9 commit 029bc0cf9e019f9c3c1281e89a1970ca57fe62f9 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Fri Feb 17 03:49:43 2017 Auto-rebaseline for r451189 Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/607307 https://chromium.googlesource.com/chromium/src/+/19b6d11616537 BUG= 691959 TBR=chrishtr@chromium.org Review-Url: https://codereview.chromium.org/2706483002 . Cr-Commit-Position: refs/heads/master@{#451203} [modify] https://crrev.com/029bc0cf9e019f9c3c1281e89a1970ca57fe62f9/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/029bc0cf9e019f9c3c1281e89a1970ca57fe62f9/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/control-clip-expected.txt [modify] https://crrev.com/029bc0cf9e019f9c3c1281e89a1970ca57fe62f9/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/control-clip-expected.txt [modify] https://crrev.com/029bc0cf9e019f9c3c1281e89a1970ca57fe62f9/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/control-clip-expected.txt
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bb957fdd7376485034caeeaad8bc3d3413aa23c commit 6bb957fdd7376485034caeeaad8bc3d3413aa23c Author: wangxianzhu <wangxianzhu@chromium.org> Date: Fri Feb 17 04:13:14 2017 Rebaseline paint/invalidation/select-option-background-color.html on Mac BUG= 691959 TBR=mgiuca@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2694623015 Cr-Commit-Position: refs/heads/master@{#451205} [delete] https://crrev.com/4f5cea4f7970a0e79f88c94959126187ef0be744/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/select-option-background-color-expected.txt [modify] https://crrev.com/6bb957fdd7376485034caeeaad8bc3d3413aa23c/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/select-option-background-color-expected.txt
,
Feb 17 2017
,
Feb 17 2017
,
Feb 21 2017
Verified this issue on Windows 10, Mac 10.12.3 and Ubuntu 14.04 with chrome dev #58.0.3018.0 Didn't observe any chopping on grey focus, attached the screen-cast for reference. Hence Adding TE-Verified labels. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by msrchandra@chromium.org
, Feb 14 2017Owner: chrishtr@chromium.org
Status: Assigned (was: Unconfirmed)