New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691957 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to sign in to the browser after clicking on ‘Ok Got it’ button.

Reported by dmascare...@etouch.net, Feb 14 2017

Issue description

Chrome Version:58.0.3012.0 (Official Build) 66847e854d3acd13965764bcbc72d38f455c463c-refs/heads/master@{#450199}(32/64-bit)
OS : Mac(10.12.1, 10.11.6, 10.12), Windows(7,8,10),Linux

What steps will reproduce the problem?
1. Launch Chrome, navigate chrome://settings and click on 'Sign in to Chrome' button
2. Enter valid email id and password and proceed till ‘Sync confirmation’ overlay appears
3. Drag the 'Settings' links to NTP, ‘Sync confirmation’ overlay opens on NTP and click on ‘Ok Got it’ button 
4. Click on close icon of the dragged tab and then Add new profile/user ,remove the old profile/profile 1 from switch person overlay
5. Repeat steps 1-3 after clicking on ‘Ok Got it’ button such that dragged page should automatically gets closed.
6. Navigate to chrome://settings/ or press ’Ctrl+Shift+M’ to open Switch person overlay and observe.

Actual: Unable to sign in to the browser after clicking on ‘Ok Got it’ button.
Expected: Able to sign in to the browser.

This is regression issue, broken in ‘M 58’ and below is manual bisect info:
Good build:58.0.3011.0
bad build:58.0.3012.0

 
actual_signin.mov
10.9 MB Download
Cc: -msarda@chromium.org
Labels: hasbisect
Owner: msarda@chromium.org
Status: Assigned (was: Unconfirmed)
Unable to sign in the chromium builds, hence providing ChangeLog
https://chromium.googlesource.com/chromium/src/+log/58.0.3011.0..58.0.3012.0?pretty=fuller&n=10000

Suspecting: r450112

Kindly help to re-assign, if your changes are not cause for this issue.

Comment 3 by msarda@chromium.org, Feb 14 2017

Does this work if you just hit "Ok, got it" in the Sync Confirmation dialog (without drag-an-drop the Settings link)?

Comment 4 by msarda@chromium.org, Feb 14 2017

Status: Started (was: Assigned)

Comment 5 by msarda@chromium.org, Feb 14 2017

I can reproduce this.

Comment 6 by gov...@chromium.org, Feb 14 2017

Cc: manoranj...@chromium.org abdulsyed@chromium.org
Labels: ReleaseBlock-Beta
Adding blocker label, since this is a recent regression. Please remove if not the case.

Thanks.!
msarda@ since this marked as releaseBlock-Beta, could you please provide an latest update to this issue.

Thank You...

Comment 9 by msarda@chromium.org, Feb 22 2017

CLs are ready (see https://codereview.chromium.org/2699443005/). They are waiting in review.
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/028db2b1bf62a5ce0574b3c1e7f42e42607cb242

commit 028db2b1bf62a5ce0574b3c1e7f42e42607cb242
Author: msarda <msarda@chromium.org>
Date: Wed Feb 22 16:06:16 2017

Make the settings link in the sync confirmation dialog point to Chrome settings.

This CL changes the settings link in the confirmation dialog to point to
Chrome settings. This ensures that if the user drags and drops this link
in the Chrome tab strip, then the Chrome settings will open (which is
the right approach).

BUG= 691957 

Review-Url: https://codereview.chromium.org/2699443005
Cr-Commit-Position: refs/heads/master@{#452073}

[modify] https://crrev.com/028db2b1bf62a5ce0574b3c1e7f42e42607cb242/chrome/app/generated_resources.grd

Comment 11 by ajha@chromium.org, Feb 27 2017

Labels: TE-Verified-M58 TE-Verified-58.0.3025.0
As per the CL in C#10, dragging and dropping the Settings link from the sync confirmation dialog to new tab, opens chrome://settings page. Tested the same on Windows-10, Mac OS 10.12.3 and Linux Ubuntu 14.04 using chrome version: 58.0.3025.0.

msarda@: Could you please close the issue if there is no further work to be done here.
Status: Fixed (was: Started)
Cc: msarda@chromium.org
 Issue 687102  has been merged into this issue.

Sign in to add a comment