New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 691926 link

Starred by 6 users
Status: Fixed
Owner:
█ chenwilliam@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
ajha@chromium.org
tkent@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Unable to add watch expression after clicking on add expressison

Project Member Reported by sahitya....@techmahindra.com, Feb 14 2017 
Chrome Version: 58.0.3012.0
OS: Windows

What steps will reproduce the problem?
(1)Launch chrome, Open Devtools>>settings>change panel layout to -->vertical
(2)Click on sources section of dev tools.
(3)Click on add expression under watch section of sources and observe

Actual Result: Should be able to add the expression in  watch section 
Expected Result: Unable to add expression in the watch section of sources

This is a Regression issue broken in M-58

Manual Bisect Info:
---------------------
Good Build:58.0.3011.0 
Bad Build:58.0.3012.0

Note: will update the linux behaviour once build exist

Comment 1 by sahitya....@techmahindra.com, Feb 14 2017

Labels: OS-Linux
Issue exist in linux os as well
Sources issue Expected.ogv
1.2 MB View Download
Sources actual.ogv
1.2 MB View Download

Comment 2 by ajha@chromium.org, Feb 14 2017

Labels: ReleaseBlock-Stable OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on the latest canary(58.0.3012.0) of Mac OS 10.12.2 as well.

Comment 3 by brajkumar@chromium.org, Feb 14 2017

Labels: -Needs-Bisect hasbisect-per-revision
Owner: tkent@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,

You are probably looking for a change made after 450005 (known good), but no later than 450006 (first known bad).

CHANGE-LOG URL:
---------------------------------------
https://chromium.googlesource.com/chromium/src/+log/f212cc56820dda5e8b5d902a15e39bcb09c37df5..66f70447e561ce2d850be2e2ef4d1a1be4364ac7

From the CL above, assigning the issue to the concern owner
Review-Url: https://codereview.chromium.org/2693813002

tkent@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 4 by tkent@chromium.org, Feb 14 2017

Status: Started (was: Assigned)
If we inspect DevTools, it shows:

❎ Uncaught DOMException: Failed to execute 'setBaseAndExtent' on 'Selection': There is no child at offset 1.
    at Sources.WatchExpression.startEditing (chrome-devtools://devtools/bundled/sources/sources_module.js:1033:551)
    at Sources.WatchExpressionsSidebarPane._addButtonClicked (chrome-devtools://devtools/bundled/sources/sources_module.js:1012:96)
    at UI.ToolbarButton.dispatchEventToListeners (chrome-devtools://devtools/bundled/inspector.js:391:23)
    at UI.ToolbarButton._clicked (chrome-devtools://devtools/bundled/inspector.js:2489:22)

Yeah, my CL exposed existing bugs.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3e70ddf82a6c476f094c9d9c641041135b40171

commit f3e70ddf82a6c476f094c9d9c641041135b40171
Author: tkent <tkent@chromium.org>
Date: Wed Feb 15 05:54:33 2017

DevTools: Fix an exception on adding watch expression.

Also, fix all of suspicious usage of Selection.setBaseAndExtent() in DevTools.

BUG= 691926 

Review-Url: https://codereview.chromium.org/2697603006
Cr-Commit-Position: refs/heads/master@{#450573}

[modify] https://crrev.com/f3e70ddf82a6c476f094c9d9c641041135b40171/third_party/WebKit/Source/devtools/front_end/accessibility/ARIAAttributesView.js
[modify] https://crrev.com/f3e70ddf82a6c476f094c9d9c641041135b40171/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js
[modify] https://crrev.com/f3e70ddf82a6c476f094c9d9c641041135b40171/third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js
[modify] https://crrev.com/f3e70ddf82a6c476f094c9d9c641041135b40171/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
[modify] https://crrev.com/f3e70ddf82a6c476f094c9d9c641041135b40171/third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js
[modify] https://crrev.com/f3e70ddf82a6c476f094c9d9c641041135b40171/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
[modify] https://crrev.com/f3e70ddf82a6c476f094c9d9c641041135b40171/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js
[modify] https://crrev.com/f3e70ddf82a6c476f094c9d9c641041135b40171/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js

Comment 6 by tkent@chromium.org, Feb 15 2017

Cc: tkent@chromium.org
Labels: -Pri-1 -ReleaseBlock-Stable -M-58 Pri-2
Owner: ----
Status: Untriaged (was: Started)
Can someone in DevTools team add tests for r450573?

Comment 7 by l...@chromium.org, Feb 15 2017

Owner: chenwilliam@chromium.org
Status: Assigned (was: Untriaged)
chenwilliam@, would you like to take a look?

Comment 8 by jankucer...@gmail.com, May 31 2017 

This bug seems to have been fixed within the standard devtools but is still present when debugging mobile device via chrome://inspect/#devices (debugging Cordova javascript application). Can someone fix this too? Or has separate bug report been filled for this one?

Using 58.0.3029.96 (64-bit) on Win7

Comment 9 by chenwilliam@chromium.org, Dec 15 2017

Status: Fixed (was: Assigned)
I believe this is fixed based on @tkent's revision in r450573.
►

Sign in to add a comment