New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 691917 link

Starred by 4 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Feb 2017
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
rbasuvula@chromium.org
█ brajkumar@chromium.org
est...@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Omnibox border is missing on using ctrl+e and esc

Project Member Reported by sc00335...@techmahindra.com, Feb 14 2017 
Chrome Version: 58.0.3012.0 dev
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome and open any chrome internal pages like chrome://about,chrome://welcome so that chrome logo is seen in omnibox
(2)Now hit ctrl+e and hit esc and observe left border of omnibox.

Expected: Border should be seen on hitting esc.
Actual: Instead border is missing in omnibox.

This is a regression issue broken in M58.

Manual Bisect Info:
===================
Good Build: 58.0.2992.0 dev
Bad Build: 58.0.2993.0 dev
Expected_chop.png
7.1 KB View Download
Actual_chop.png
22.1 KB View Download

Comment 1 by msrchandra@chromium.org, Feb 14 2017

Labels: -Needs-Bisect hasbisect-per-revision
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build -- 58.0.2992.0 (revision : 445908)
Bad Build  -- 58.0.2993.0 (revision : 446204)

You are probably looking for a change made after 446198 (known good), but no later than 446199 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/22d3bc7d75a5f9180bca7860ee23c3f731607eda..39f5ad11373872bbb7e398fb7943b289cc790c39

@estade -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You.

Comment 2 by est...@chromium.org, Feb 15 2017 

I think the actual bug here is that ctrl+e + escape should restore the chromium icon / label
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8d55fefdb0bcf5b7d25b7a4fb673731ac6a8b9a

commit d8d55fefdb0bcf5b7d25b7a4fb673731ac6a8b9a
Author: estade <estade@chromium.org>
Date: Thu Feb 16 20:17:29 2017

Re-display chrome:// page location icon label after aborted search

This changes the behavior of chrome:// (and extension pages) to match
the behavior of secure pages (showing ev certs). input_in_progress()
matches what we do for the security chip, i.e. is used as the check
inside GetToolbarModel()->GetSecurityLevel(false).

BUG= 691917 

Review-Url: https://codereview.chromium.org/2702463004
Cr-Commit-Position: refs/heads/master@{#451078}

[modify] https://crrev.com/d8d55fefdb0bcf5b7d25b7a4fb673731ac6a8b9a/chrome/browser/ui/views/location_bar/location_bar_view.cc

Comment 4 by est...@chromium.org, Feb 16 2017

Labels: Merge-Request-58
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 16 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: We don't branch M58 until 2017-03-02.
Please contact the milestone owner if you have questions.
Owners: @(clank), @(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by est...@chromium.org, Feb 16 2017

Labels: -Hotlist-Merge-Review -Merge-Review-58
Status: Fixed (was: Assigned)
heh, well then...

Comment 7 by kavvaru@chromium.org, Feb 21 2017

Cc: est...@chromium.org rbasuvula@chromium.org
 Issue 694152  has been merged into this issue.

Comment 8 by kkaluri@chromium.org, Feb 21 2017

Labels: TE-Verified-M58 TE-Verified-58.0.3018.0
Verified this issue on Windows 10 and Ubuntu 14.04 with chrome dev #58.0.3018.0, as steps mentioned in the comment #0

Observed the border is visible in omnibox on hitting Esc button , attached the screen-shot for reference.

Hence Adding TE-Verified labels.
Issue 691917.PNG
46.0 KB View Download
►

Sign in to add a comment