New issue
Advanced search Search tips

Issue 691913 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

NotificationsApiTest.TestBasicUsage in interactive_ui_tests flaky on chromium.linux/Linux Tests (dbg)(1)(32)

Project Member Reported by tyoshino@chromium.org, Feb 14 2017

Issue description

interactive_ui_tests failing on chromium.linux/Linux Tests (dbg)(1)(32)

Builders failed on: 
- Linux Tests (dbg)(1)(32): 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29



 
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a14d8c2c37cfedf9a35d12dbb79bb9f22e967f1

commit 5a14d8c2c37cfedf9a35d12dbb79bb9f22e967f1
Author: tyoshino <tyoshino@chromium.org>
Date: Tue Feb 14 06:36:29 2017

Disable NotificationsApiTest.TestBasicUsage for Linux debug build

BUG=691913
TBR=dewittj

Review-Url: https://codereview.chromium.org/2691953004
Cr-Commit-Position: refs/heads/master@{#450281}

[modify] https://crrev.com/5a14d8c2c37cfedf9a35d12dbb79bb9f22e967f1/chrome/browser/extensions/api/notifications/notifications_apitest.cc

Labels: -Hotlist-Sheriff-Chromium
Removing Hotlist-Sheriff-Chromium label as it no longer needs attention by the sheriffs.
Flakiness dashboard shows all green except for one run.  Is that enough to warrant disabling the test?  That run has a crash stack, was anything else reverted or rolled that might cause this problem?
Usually, I don't disable a test because of flakiness unless there I see at least 2 failures at close positions. But it's possible that I recognized it as flaky by mistake.

I have no idea about the cause. I took this action following the tree sheriffing guideline (though it might be a mistake, sorry in that case). Feel free to re-enable it if you think you need.

Comment 6 Deleted

Comment 7 by fdoray@chromium.org, Feb 21 2017

cc-ing estade@ who added the DCHECK in https://codereview.chromium.org/2661313005.

Sample failure:

[396:2756:0221/073929.929:FATAL:label.cc(471)] Check failed: view->layer()->fills_bounds_opaquely().  Ancestor view has a non-opaque layer: View with ID 0
Backtrace:
	base::debug::StackTrace::StackTrace [0x068C5AD7+55]
	base::debug::StackTrace::StackTrace [0x068C56B1+17]
	logging::LogMessage::~LogMessage [0x06912EBB+59]
	views::Label::PaintText [0x080A1B95+453]
	views::Label::OnPaint [0x080A1932+98]
	views::View::Paint [0x08170E7F+2095]
	views::View::PaintChildren [0x081712DE+446]
	views::View::Paint [0x08170EB4+2148]
	views::View::PaintChildren [0x081712DE+446]
	views::View::Paint [0x08170EB4+2148]
	views::View::PaintChildren [0x081712DE+446]
	views::View::Paint [0x08170EB4+2148]
	views::View::OnPaintLayer [0x08170413+19]
	ui::Layer::PaintContentsToDisplayList [0x08C57CA8+392]
	cc::PictureLayer::Update [0x08DC9B46+662]
	cc::LayerTreeHost::UpdateLayers [0x0903F68E+126]
	cc::LayerTreeHost::DoUpdateLayers [0x0903B47E+1422]
	cc::LayerTreeHost::UpdateLayers [0x0903F7F7+199]
	cc::SingleThreadProxy::DoBeginMainFrame [0x0912755B+283]
	cc::SingleThreadProxy::BeginMainFrame [0x091263B2+402]
	base::internal::FunctorTraits<void (__thiscall cc::SingleThreadProxy::*)(cc::BeginFrameArgs const &),void>::Invoke<base::WeakPtr<cc::SingleThreadProxy> const &,cc::BeginFrameArgs const &> [0x09124F25+37]
	base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall cc::SingleThreadProxy::*const &)(cc::BeginFrameArgs const &),base::WeakPtr<cc::SingleThreadProxy> const &,cc::BeginFrameArgs const &> [0x091250C6+70]
	base::internal::Invoker<base::internal::BindState<void (__thiscall cc::SingleThreadProxy::*)(cc::BeginFrameArgs const &),base::WeakPtr<cc::SingleThreadProxy>,cc::BeginFrameArgs>,void __cdecl(void)>::RunImpl<void (__thiscall cc::SingleThreadProxy::*const & [0x09125183+83]
	base::internal::Invoker<base::internal::BindState<void (__thiscall cc::SingleThreadProxy::*)(cc::BeginFrameArgs const &),base::WeakPtr<cc::SingleThreadProxy>,cc::BeginFrameArgs>,void __cdecl(void)>::Run [0x09128674+36]
	base::internal::RunMixin<base::Callback<void __cdecl(void),0,0> >::Run [0x068CC314+68]
	base::debug::TaskAnnotator::RunTask [0x068CC51F+479]
	base::MessageLoop::RunTask [0x06942D32+626]
	base::MessageLoop::DeferOrRunPendingTask [0x06940DCC+44]
	base::MessageLoop::DoWork [0x069413A2+242]
	base::MessagePumpForUI::DoRunLoop [0x0694AC63+67]
	base::MessagePumpWin::Run [0x0694BBFB+123]
	base::MessageLoop::RunHandler [0x06942A4E+398]
	base::RunLoop::Run [0x069F6396+166]
	content::RunThisRunLoop [0x02457CFE+30]
	extensions::ResultCatcher::GetNextResult [0x04A0D20B+91]
	ExtensionApiTest::RunExtensionTestImpl [0x00524E95+1205]
	ExtensionApiTest::RunExtensionTest [0x0052491C+44]
	NotificationsApiTest_TestBasicUsage_Test::RunTestOnMainThread [0x00513C89+57]
	InProcessBrowserTest::RunTestOnMainThreadLoop [0x0169D8FD+605]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x02478BE0+224]
	??$Invoke@PAVBrowserTestBase@content@@$$V@?$FunctorTraits@P8BrowserTestBase@content@@AEXXZX@internal@base@@SAXP8BrowserTestBase@content@@AEXXZ$$QAPAV34@@Z [0x02477F22+18]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall content::BrowserTestBase::*const &)(void),content::BrowserTestBase *> [0x02478064+36]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::RunImpl<void (__thiscall content::BrowserTestBase::*const &)(void),std [0x0247816B+59]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::Run [0x02478F84+36]
	base::internal::RunMixin<base::Callback<void __cdecl(void),1,1> >::Run [0x005947BF+63]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x01CA92B2+5794]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x01CA7BB4+244]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x0C81F7D7+215]
	??$Invoke@PAVBrowserMainLoop@content@@$$V@?$FunctorTraits@P8BrowserMainLoop@content@@AEHXZX@internal@base@@SAHP8BrowserMainLoop@content@@AEHXZ$$QAPAV34@@Z [0x0C813982+18]
	base::internal::InvokeHelper<0,int>::MakeItSo<int (__thiscall content::BrowserMainLoop::*const &)(void),content::BrowserMainLoop *> [0x0C813F54+36]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::RunImpl<int (__thiscall content::BrowserMainLoop::*const &)(void),std::t [0x0C8143CB+59]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::Run [0x0C81FE14+36]
	base::internal::RunMixin<base::Callback<int __cdecl(void),1,1> >::Run [0x0D45C2CF+63]
	content::StartupTaskRunner::RunAllTasksNow [0x0D49DCBE+110]
	content::BrowserMainLoop::CreateStartupTasks [0x0C81B8C9+569]
	content::BrowserMainRunnerImpl::Initialize [0x0C826135+981]
	content::BrowserMain [0x0C810D4F+95]
	content::RunNamedProcessTypeMain [0x0E120467+135]
	content::ContentMainRunnerImpl::Run [0x0E120345+405]
	content::ContentMain [0x0E11E584+100]
	content::BrowserTestBase::SetUp [0x02479576+1430]
	InProcessBrowserTest::SetUp [0x0169DDE5+741]

Comment 8 by est...@chromium.org, Feb 21 2017

I could not repro this failure in 50 runs on my local machine (linux). I also couldn't repro by running Chrome and showing an extension notification.

Comment 9 by fdoray@chromium.org, Feb 21 2017

Still failing https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/57515

I'll create a CL to disable the test.
CL to disable on Win in the CQ: https://codereview.chromium.org/2708093003
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59bef6e2cbf1b3058d14de15b4614a88fefc01ea

commit 59bef6e2cbf1b3058d14de15b4614a88fefc01ea
Author: fdoray <fdoray@chromium.org>
Date: Wed Feb 22 15:21:20 2017

Disable NotificationsApiTest.TestBasicUsage for Win debug build

BUG=691913
TBR=dewittj@chromium.org

Review-Url: https://codereview.chromium.org/2708093003
Cr-Commit-Position: refs/heads/master@{#452056}

[modify] https://crrev.com/59bef6e2cbf1b3058d14de15b4614a88fefc01ea/chrome/browser/extensions/api/notifications/notifications_apitest.cc

Labels: Sheriff-Chromium
Please use Sheriff-Chromium label instead of Hotlist-Sheriff-Chromium. Issues with Sheriff-Chromium label are shown in Sheriff-o-Matic and are tried by sheriffs directly.
Labels: -Sheriff-Chromium
Turns out search on Monorail is eventually consistent. Removing Sheriff-Chromium from this issue since Hotlist-Sheriff-Chromium was removed earlier.

Comment 14 by peter@chromium.org, Apr 11 2017

Cc: dewittj@chromium.org
Components: UI>Notifications
Owner: peter@chromium.org
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked
*** UI Mass Triage***
Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment