New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691904 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 692769



Sign in to add a comment

ChromeOS OOBE: $i18n{} not changing on language switch.

Project Member Reported by alemate@chromium.org, Feb 14 2017

Issue description

https://codereview.chromium.org/2626123002 broke ChromeOS OOBE.

After language switching all strings remain the same.
Only input elements are updated.
 
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Expected:
1: choose a language.
2: Language changes.

Actual:
1: Choose a language.
2: Language shows selected in the control, but no other change.

After reboot:
Language is changed
*Language selector now shows English*

What should change:
Ideally we should switch languages immediately.
After a restart the language selector should list the current language.
CL 2626123002 should be safe to revert.
We are transitioning i18n localization and have both the old and new systems running during the transition. Reverting that CL should snap us right back into the old i18n localization. I can then look into this issue at a later date.
I've started a revert in CL 2694353002
Revert will help M57.
But for M58 we need to either make $i18n{} work or find another way of handling strings for OOBE.

Comment 6 by dbeam@chromium.org, Feb 14 2017

do we just need to rebuild the data source with new translations, maybe?
OOBE is using reloadContent JS method to update strings:

https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc?rcl=850f6feb8d0dc1a39dcc8ac63a91918a5c72a71d&l=282

it is called from NetworkScreenHandler::ReloadLocalizedContent() which is called from NetworkScreen::OnLanguageListResolved(), which is called as callback from locale_util::SwitchLanguage().

We need $i18n{} to update strings somewhere on this path.
I seem to be able to update the strings, but I have yet to find where to get the page reloaded so that that the template (i18n) replacements occur. At some point ReplaceTemplateExpressions must be called again.
As far as I understand, the point of using i18n-content was NOT to reload web page. Users should not see page refresh, so the strings must be replaced in-place.
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f21fb41278cc936a74fa33148ca01d394dd54a9

commit 8f21fb41278cc936a74fa33148ca01d394dd54a9
Author: dschuyler <dschuyler@chromium.org>
Date: Wed Feb 15 19:18:12 2017

Revert of [i18n] chromeos login i18n-content to $i18n{} (patchset #4 id:80001 of https://codereview.chromium.org/2626123002/ )

Reason for revert:
crbug/691904 reports that when changing the language, the pages are not redrawn in the newly selected language. This CL is not critical to get into M-57 so I'm reverting it to get a M-57 working asap. I can look into it further for a later milestone.

Original issue's description:
> [i18n] chromeos login i18n-content to $i18n{}
>
> This is a semi-mechanical change to convert i18n-content to $i18n{}. The
> Non-mechancal changes are some formatting adjustments.
>
> BUG=677338
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2626123002
> Cr-Commit-Position: refs/heads/master@{#443327}
> Committed: https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d7f8bceebea99

TBR=tommycli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 691904 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2694353002
Cr-Commit-Position: refs/heads/master@{#450762}

[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/accessibility_menu.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/api_keys_notice.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/arc_terms_of_service.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/controller-pairing-screen.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/demo_user_login.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/gaia_password_changed.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/header_bar.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/host-pairing-screen.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/lock.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/login.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_eula.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_hid_detection.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_auto_enrollment_check.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_autolaunch.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_enable_debugging.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_enable_kiosk.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_eula.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_eula_installation_settings_overlay.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_network.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_reset.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_reset_confirmation_overlay.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_update.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_update.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/saml_confirm_password.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/saml_interstitial.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/screen_app_launch_splash.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/screen_device_disabled.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/screen_error_message.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/screen_tpm_error.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/screen_wrong_hwid.html
[modify] https://crrev.com/8f21fb41278cc936a74fa33148ca01d394dd54a9/chrome/browser/resources/chromeos/login/unrecoverable_cryptohome_error_card.html

Status: Fixed (was: Assigned)
Summary: ChromeOS OOBE: $i18n{} not changing on language switch. (was: ChromeOS OOBE: $i18n{} doesn't support language switching.)
I'll revisit this at a later time. For now, reverting the change is simple and effective.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
Blocking: 692769
Labels: Merge-Request-57
Ok, I think this has made it onto Canary, and IIUC the next step is to ask for permission to merge.
Project Member

Comment 15 by sheriffbot@chromium.org, Feb 18 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-57 Merge-Approved-57
Approving merge to M57 Chrome OS.
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 24 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c44008f48f84975c104f58b54765a3b687c74b22

commit c44008f48f84975c104f58b54765a3b687c74b22
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Fri Feb 24 01:14:12 2017

Revert of [i18n] chromeos login i18n-content to $i18n{} (patchset #4 id:80001 of https://codereview.chromium.org/2626123002/ )

Reason for revert:
crbug/691904 reports that when changing the language, the pages are not redrawn in the newly selected language. This CL is not critical to get into M-57 so I'm reverting it to get a M-57 working asap. I can look into it further for a later milestone.

Original issue's description:
> [i18n] chromeos login i18n-content to $i18n{}
>
> This is a semi-mechanical change to convert i18n-content to $i18n{}. The
> Non-mechancal changes are some formatting adjustments.
>
> BUG=677338
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2626123002
> Cr-Commit-Position: refs/heads/master@{#443327}
> Committed: https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d7f8bceebea99

TBR=tommycli@chromium.org
BUG= 691904 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2694353002
Cr-Commit-Position: refs/heads/master@{#450762}
(cherry picked from commit 8f21fb41278cc936a74fa33148ca01d394dd54a9)

Review-Url: https://codereview.chromium.org/2718563003 .
Cr-Commit-Position: refs/branch-heads/2987@{#673}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/accessibility_menu.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/api_keys_notice.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/controller-pairing-screen.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/demo_user_login.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/gaia_password_changed.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/header_bar.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/host-pairing-screen.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/lock.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/login.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_eula.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_hid_detection.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_auto_enrollment_check.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_autolaunch.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_enable_debugging.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_enable_kiosk.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_eula.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_eula_installation_settings_overlay.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_network.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_reset.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_reset_confirmation_overlay.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_update.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_update.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/saml_confirm_password.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/saml_interstitial.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/screen_app_launch_splash.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/screen_device_disabled.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/screen_error_message.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/screen_tpm_error.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/screen_wrong_hwid.html
[modify] https://crrev.com/c44008f48f84975c104f58b54765a3b687c74b22/chrome/browser/resources/chromeos/login/unrecoverable_cryptohome_error_card.html

Owner: keta...@chromium.org
Cc: r...@chromium.org
Cc: -st...@chromium.org
Project Member

Comment 21 by sheriffbot@chromium.org, Apr 17 2017

Labels: -Merge-TBD
Components: UI>Shell>OOBE
Status: Verified (was: Fixed)
9334.58.2, 58.0.3029.89

Sign in to add a comment