New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691902 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Crash in TessellatingPathOp::drawAA

Project Member Reported by ClusterFuzz, Feb 14 2017

Issue description

Cc: msrchandra@chromium.org
Components: Internals>GPU>Rasterization
Labels: Test-Predator-Wrong-CLs
Owner: halcanary@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL did not find any possible suspects.
Using Code Search for the file, "GrTessellatingPathRenderer.cpp" assigning to the concern owner.
Suspecting Commit#
https://skia.git.corp.google.com/skia.git/+/6f6961ebad65c582318564b3688e78e5c99f3935

@Hal Canary -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by bsalo...@google.com, Feb 15 2017

Owner: senorblanco@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/cc70083fbf76fd86b901fffdcce40d0f53787fc8

commit cc70083fbf76fd86b901fffdcce40d0f53787fc8
Author: Stephen White <senorblanco@chromium.org>
Date: Wed Feb 15 17:42:26 2017

GrTessellator (AA): null GrGeometryProcessor crash fix.

Add a null-check on geometry processor creation.

Add a test which exercises it: AA tessellator, with a non-invertible
matrix and a fragment processor which needs local coords (e.g., linear
gradient).

BUG= 691902 

Change-Id: I005b893aed58d3ad2500c41501045ac94b0b4b95
Reviewed-on: https://skia-review.googlesource.com/8462
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>

[modify] https://crrev.com/cc70083fbf76fd86b901fffdcce40d0f53787fc8/tests/TessellatingPathRendererTests.cpp
[modify] https://crrev.com/cc70083fbf76fd86b901fffdcce40d0f53787fc8/src/gpu/ops/GrTessellatingPathRenderer.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b05e107a3d28faf33ee6a3f4fc39aa4b560dc62e

commit b05e107a3d28faf33ee6a3f4fc39aa4b560dc62e
Author: skia-deps-roller <skia-deps-roller@chromium.org>
Date: Thu Feb 16 09:12:03 2017

Roll src/third_party/skia/ 2b512d00e..394d41445 (19 commits).

https://skia.googlesource.com/skia.git/+log/2b512d00ef8d..394d414452a5

$ git log 2b512d00e..394d41445 --date=short --no-merges --format='%ad %ae %s'
2017-02-14 dmazzoni Implement SkHighContrastFilter
2017-02-15 mtklein SkJumper
2017-02-15 bungeman Work around Mac x- and cap-height calculation.
2017-02-15 msarett Use non-linear blending flag in raster pipeline blitter
2017-02-15 mtklein Clean up SkSplicer.
2017-02-15 egdaniel Update intel linux vulkan driver
2017-02-15 reed return and take SkImageGenerator as unique_ptr
2017-02-15 bsalomon Check that coverage FPs are compatible with alpha as coverage
2017-02-15 robertphillips Tighten up GrSurfaceProxy typing
2017-02-15 jcgregorio Move documentation to use the embedded fiddle elements.
2017-02-15 ethannicholas improved performance of parsing SkSLLayout flags
2017-02-15 halcanary fiddle: use sstream for text, code cleanup
2017-02-15 reed Revert "Revert "make SkClipStack.h private (in src)""
2017-02-15 robertphillips Add GrMakeCachedBitmapProxy
2017-02-14 chet Avoid constant view inflation on viewer sample app
2017-02-15 mtklein Disable SkSplicer.
2017-02-15 senorblanco GrTessellator (AA): null GrGeometryProcessor crash fix.
2017-02-15 reed Revert "make SkClipStack.h private (in src)"
2017-02-15 bsalomon Clarify when tweak alpha for coverage optimizaton can occur.

Created with:
  roll-dep src/third_party/skia
BUG= 691902 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=bungeman@google.com

Review-Url: https://codereview.chromium.org/2698063004
Cr-Commit-Position: refs/heads/master@{#450909}

[modify] https://crrev.com/b05e107a3d28faf33ee6a3f4fc39aa4b560dc62e/DEPS

This should be fixed by the change which rolled in in r450909.

I'll wait for ClusterFuzz to close it, though.
Project Member

Comment 6 by ClusterFuzz, Mar 1 2017

Project Member

Comment 7 by ClusterFuzz, Mar 1 2017

Status: Fixed (was: Assigned)

Sign in to add a comment