New issue
Advanced search Search tips

Issue 691894 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Remove null checks of ViewsDelegate

Project Member Reported by pkasting@chromium.org, Feb 14 2017

Issue description

Per sky, let's assume this is always non-null, and remove all existing null-checks.

(I don't know if there are exceptions to this, e.g. during some part of startup or shutdown.)
 
Cc: kylixrd@chromium.org
We should also try to move ViewsDelegate creation to PreCreateThreads(), which is after the material design controller has been initialized.

I suggest doing this after removing these null checks, since that will make it more obvious if this isn't really safe (the null checks would serve to paper over real issues).  If it's not safe, that calls into question the safety of initializing the LayoutProvider there too.
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked
*** UI Mass Triage***

Status: WontFix (was: Available)
I THINK we actually did this, but it must have been associated with a different bug.
Status: Available (was: WontFix)
Nah, there are still a number of "if (ViewsDelegate::GetInstance())" and the like in the codebase.

Sign in to add a comment