New issue
Advanced search Search tips

Issue 691893 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Remove last usage functions from HostContentSettingsMap and Prefs

Project Member Reported by timloh@chromium.org, Feb 14 2017

Issue description

Last usage has been unused for over two years. Raymes previously had a patch up at https://codereview.chromium.org/1411653004 to remove these. Since there are still no concrete plans to actually use this, we should remove it and clean up the last_usage prefs.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/625ec633bc9592783a2ac98c55e5253189221eed

commit 625ec633bc9592783a2ac98c55e5253189221eed
Author: timloh <timloh@chromium.org>
Date: Tue Feb 21 03:33:14 2017

Remove last usage functions from HostContentSettingsMap and clean up prefs

The last usage functions are:
1) Unused and have been for over 2.5 years. There is no concrete plan
to use them.
2) Not implemented in a very clean way, e.g.:
- There are 5 functions in HostContentSettingsMap for this functionality
making the interface more complex. It's unclear whether this should even
be in HostContentSettingsMap.
- There is special casing in SetContentSettingCustomScope for some
permissions which shouldn't be there.

This patch a rebase of raymes@'s patch crrev.com/1411653004 with
RegisterPermissionUsage and prefs logic also removed, and code to clean
up the existing saved prefs added.

BUG= 691893 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=torne, sergeyu, alokp, nasko, timvolodine

Review-Url: https://codereview.chromium.org/2697473002
Cr-Commit-Position: refs/heads/master@{#451693}

[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/android_webview/browser/aw_permission_manager.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/android_webview/browser/aw_permission_manager.h
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/chrome/browser/media/webrtc/media_stream_devices_controller.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/chrome/browser/notifications/notification_interactive_uitest.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/chrome/browser/permissions/permission_manager.h
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/chromecast/browser/cast_permission_manager.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/chromecast/browser/cast_permission_manager.h
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/components/content_settings/core/browser/content_settings_pref.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/components/content_settings/core/browser/content_settings_pref.h
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/components/content_settings/core/browser/content_settings_pref_provider.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/components/content_settings/core/browser/content_settings_pref_provider.h
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/components/content_settings/core/browser/host_content_settings_map.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/components/content_settings/core/browser/host_content_settings_map.h
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/content/public/browser/permission_manager.h
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/content/shell/browser/layout_test/layout_test_permission_manager.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/content/shell/browser/layout_test/layout_test_permission_manager.h
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/content/shell/browser/shell_permission_manager.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/content/shell/browser/shell_permission_manager.h
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/content/test/mock_permission_manager.h
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/device/geolocation/geolocation_service_context.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/device/geolocation/geolocation_service_context.h
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/device/geolocation/geolocation_service_impl.cc
[modify] https://crrev.com/625ec633bc9592783a2ac98c55e5253189221eed/device/geolocation/geolocation_service_impl.h

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e369fbdecbe1d12a2665218c5c9e3ae1d2e563d9

commit e369fbdecbe1d12a2665218c5c9e3ae1d2e563d9
Author: Timothy Loh <timloh@chromium.org>
Date: Thu Jul 06 00:21:20 2017

Remove last usage pref clean-up

This patch removes code for cleaning up last usage prefs. This code was
around in M58/59/60, so any active user of Chrome will have had these
prefs cleaned up.

Bug:  691893 
Change-Id: I6abf643c78636d6eb5cfb71d531a98dbee8edf63
Reviewed-on: https://chromium-review.googlesource.com/558842
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484405}
[modify] https://crrev.com/e369fbdecbe1d12a2665218c5c9e3ae1d2e563d9/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
[modify] https://crrev.com/e369fbdecbe1d12a2665218c5c9e3ae1d2e563d9/components/content_settings/core/browser/content_settings_pref_provider.cc

Sign in to add a comment