Chrome Version: ToT OS: All This is a follow-up of Issue 490206 . Now we keep a reference of a registered Range, so IDL attributes of Selection should be computed with the Range instead of normalized selection.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94fcc3a62bdcbf2c1342612702b00dae8359ebcc commit 94fcc3a62bdcbf2c1342612702b00dae8359ebcc Author: tkent <tkent@chromium.org> Date: Tue Feb 14 05:30:02 2017 Selection API: anchorNode, anchorOffset, focusNode, focusOffset, isCollapsed, and type should be based on a registered Range. We computed them with normalized selection, a.k.a. VisibleSelection. This CL improves external/wpt/selection/isCollapsed.html. Total new PASS: 116 Total new FAIL: 77 Following CLs will resolve FAILs which this CL introduces. BUG= 691887 Review-Url: https://codereview.chromium.org/2694043004 Cr-Commit-Position: refs/heads/master@{#450266} [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/SlowTests [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/editing/deleting/delete-br-001-expected.txt [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/editing/deleting/delete-br-001.html [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/editing/deleting/delete-character-003-expected.txt [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/editing/deleting/delete-character-003.html [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/editing/deleting/forward-delete-empty-table-cell-expected.txt [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/external/wpt/selection/collapse-00-expected.txt [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/external/wpt/selection/collapse-30-expected.txt [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/external/wpt/selection/collapseToStartEnd-expected.txt [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/external/wpt/selection/extend-00-expected.txt [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/external/wpt/selection/extend-20-expected.txt [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/external/wpt/selection/extend-40-expected.txt [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/external/wpt/selection/isCollapsed-expected.txt [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/external/wpt/selection/removeAllRanges-expected.txt [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/external/wpt/selection/selectAllChildren-expected.txt [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure-expected.txt [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/LayoutTests/fast/forms/shadow-tree-exposure.html [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/Source/core/editing/DOMSelection.cpp [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/Source/core/editing/DOMSelection.h [modify] https://crrev.com/94fcc3a62bdcbf2c1342612702b00dae8359ebcc/third_party/WebKit/Source/core/editing/VisibleSelection.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/226674d91af605cbac623ef70b4a5a74edb65978 commit 226674d91af605cbac623ef70b4a5a74edb65978 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Tue Feb 14 10:52:21 2017 Auto-rebaseline for r450266 Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/604903 https://chromium.googlesource.com/chromium/src/+/94fcc3a62bdcb BUG= 691887 TBR=tkent@chromium.org Review-Url: https://codereview.chromium.org/2692793005 . Cr-Commit-Position: refs/heads/master@{#450319} [modify] https://crrev.com/226674d91af605cbac623ef70b4a5a74edb65978/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42098d2b51a7b48696bc664bfe840186926f1575 commit 42098d2b51a7b48696bc664bfe840186926f1575 Author: Kent Tamura <tkent@chromium.org> Date: Tue Feb 14 13:33:06 2017 Manual rebaseline for extend-NN.html and selectAllChildren.html. An auto-rebaseline, https://codereview.chromium.org/2692793005, failed. BUG= 691887 TBR=yosin@chromium.org Review-Url: https://codereview.chromium.org/2698443002 . Cr-Commit-Position: refs/heads/master@{#450336} [add] https://crrev.com/42098d2b51a7b48696bc664bfe840186926f1575/third_party/WebKit/LayoutTests/platform/win/external/wpt/selection/extend-00-expected.txt [add] https://crrev.com/42098d2b51a7b48696bc664bfe840186926f1575/third_party/WebKit/LayoutTests/platform/win/external/wpt/selection/extend-20-expected.txt [add] https://crrev.com/42098d2b51a7b48696bc664bfe840186926f1575/third_party/WebKit/LayoutTests/platform/win/external/wpt/selection/extend-40-expected.txt [add] https://crrev.com/42098d2b51a7b48696bc664bfe840186926f1575/third_party/WebKit/LayoutTests/platform/win/external/wpt/selection/selectAllChildren-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b7660a8c98d3776aa9834e4f35470d1f8919376 commit 8b7660a8c98d3776aa9834e4f35470d1f8919376 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Tue Feb 14 17:24:24 2017 Auto-rebaseline for r450370 Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/605173 https://chromium.googlesource.com/chromium/src/+/d892f95928606 BUG= 691887 , 625533 TBR=yosin@chromium.org Review-Url: https://codereview.chromium.org/2690113009 . Cr-Commit-Position: refs/heads/master@{#450393} [modify] https://crrev.com/8b7660a8c98d3776aa9834e4f35470d1f8919376/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/8b7660a8c98d3776aa9834e4f35470d1f8919376/third_party/WebKit/LayoutTests/platform/win/external/wpt/selection/extend-00-expected.txt [modify] https://crrev.com/8b7660a8c98d3776aa9834e4f35470d1f8919376/third_party/WebKit/LayoutTests/platform/win/external/wpt/selection/extend-20-expected.txt [delete] https://crrev.com/5c881c966c106de42f6e3b142d555a02771c1913/third_party/WebKit/LayoutTests/platform/win/external/wpt/selection/extend-40-expected.txt [modify] https://crrev.com/8b7660a8c98d3776aa9834e4f35470d1f8919376/third_party/WebKit/LayoutTests/platform/win/external/wpt/selection/selectAllChildren-expected.txt
Comment 1 by tkent@chromium.org
, Feb 14 2017