https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9bzI/edit#heading=h.nd04pawlhiy
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33 commit f4729b0eccefc8bd9f46d4e36144b9a53cd02e33 Author: oysteine <oysteine@chromium.org> Date: Tue Feb 14 21:35:46 2017 Renamed /services/memory_infrastructure to /services/resource_coordinator The memory_infra bindings are now in a subfolder of this service, in preparation for more functionality being added. Also changed the OWNERS file from pointing to /base/trace_event/OWNERS to a reasonable set of people involved who are also owners elsewhere. R=chiniforooshan@chromium.org,jam@chromium.org BUG= 691886 Review-Url: https://codereview.chromium.org/2693063002 Cr-Commit-Position: refs/heads/master@{#450482} [modify] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/base/trace_event/memory_dump_request_args.h [modify] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/mojo/public/tools/bindings/chromium_bindings_configuration.gni [modify] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/BUILD.gn [delete] https://crrev.com/7832d67481ad51c31126552301df007efb57fa8a/services/memory_instrumentation/OWNERS [delete] https://crrev.com/7832d67481ad51c31126552301df007efb57fa8a/services/memory_instrumentation/public/cpp/BUILD.gn [rename] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/BUILD.gn [add] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/OWNERS [rename] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/memory/coordinator/coordinator_impl.cc [rename] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/memory/coordinator/coordinator_impl.h [rename] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc [add] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/public/cpp/BUILD.gn [add] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/public/cpp/memory/OWNERS [rename] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/public/cpp/memory/coordinator.h [rename] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.cc [rename] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h [rename] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/public/cpp/memory/memory_instrumentation.typemap [rename] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc [rename] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h [rename] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/public/cpp/typemaps.gni [rename] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/public/interfaces/BUILD.gn [rename] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/public/interfaces/OWNERS [copy] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/public/interfaces/memory/OWNERS [rename] https://crrev.com/f4729b0eccefc8bd9f46d4e36144b9a53cd02e33/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de0f39d2a625433e60b5e22e1d2d3803f3d219e5 commit de0f39d2a625433e60b5e22e1d2d3803f3d219e5 Author: oysteine <oysteine@chromium.org> Date: Fri Apr 28 15:21:17 2017 Global Resource Coordinator: Basic service internals This adds the basic internals of the GRC; CoordinationUnits which can form a DAG, receive events, and send back updated resource usage policies. A full prototype of GRC usage can be seen here: https://codereview.chromium.org/2710823003 Service architecture doc: https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9bzI/edit# GRC parent doc (internal only): https://docs.google.com/document/d/1dx4KDbDFvP-GWwwrSPg8Gxx4kboIoPi8kDKTSXoTbC4/edit#heading=h.td4yhfm12fe3 R=primiano@chromium.org,skyostil@chromium.org,fmeawad@chromium.org,rockot@chromium.org BUG= 691886 Review-Url: https://codereview.chromium.org/2798713002 Cr-Commit-Position: refs/heads/master@{#468002} [modify] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/BUILD.gn [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/DEPS [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/coordination_unit/coordination_unit_impl.h [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.h [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/manifest.json [modify] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/cpp/BUILD.gn [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/cpp/OWNERS [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/cpp/coordination_unit.typemap [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/cpp/coordination_unit_id.cc [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/cpp/coordination_unit_id.h [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/cpp/coordination_unit_struct_traits.cc [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/cpp/coordination_unit_struct_traits.h [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/cpp/coordination_unit_types.h [delete] https://crrev.com/611639da9364de0f00eb0136523482a9b7b394b7/services/resource_coordinator/public/cpp/memory/memory_export.h [modify] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h [modify] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl.h [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/cpp/resource_coordinator_export.h [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/cpp/resource_coordinator_interface.cc [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/cpp/resource_coordinator_interface.h [modify] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/cpp/typemaps.gni [modify] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/interfaces/BUILD.gn [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/interfaces/coordination_unit.mojom [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/interfaces/coordination_unit_provider.mojom [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/interfaces/events.mojom [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/public/interfaces/service_constants.mojom [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/resource_coordinator_service.cc [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/resource_coordinator_service.h [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/resource_coordinator_service_unittest.cc [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/service_main.cc [add] https://crrev.com/de0f39d2a625433e60b5e22e1d2d3803f3d219e5/services/resource_coordinator/unittest_manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d19b802b839f71f5d077fe3edb92e7902f4db52 commit 1d19b802b839f71f5d077fe3edb92e7902f4db52 Author: sky <sky@chromium.org> Date: Fri Apr 28 18:15:41 2017 Revert of Global Resource Coordinator: Basic service internals (patchset #30 id:560001 of https://codereview.chromium.org/2798713002/ ) Reason for revert: Reverting as CoordinationUnitImplTest.CyclicGraphUnits is crashing on windows dbg. The output isn't very helpful: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F59514%2F%2B%2Frecipes%2Fsteps%2Fservice_unittests%2F0%2Fstdout RUN ] CoordinationUnitImplTest.CyclicGraphUnits [114/116] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED) [115/116] CoordinatorImplTest.NoProcessLocalManagers (1 ms) [116/116] CoordinatorImplTest.SeveralProcessLocalManagers (4 ms) Retrying 1 test (retry #1) [ RUN ] CoordinationUnitImplTest.CyclicGraphUnits [117/117] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED) Retrying 1 test (retry #2) [ RUN ] CoordinationUnitImplTest.CyclicGraphUnits [118/118] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED) Retrying 1 test (retry #3) [ RUN ] CoordinationUnitImplTest.CyclicGraphUnits [119/119] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED) Original issue's description: > Global Resource Coordinator: Basic service internals > > This adds the basic internals of the GRC; CoordinationUnits which can form a DAG, receive events, and send back updated resource usage policies. > > A full prototype of GRC usage can be seen here: https://codereview.chromium.org/2710823003 > > Service architecture doc: https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9bzI/edit# > > GRC parent doc (internal only): https://docs.google.com/document/d/1dx4KDbDFvP-GWwwrSPg8Gxx4kboIoPi8kDKTSXoTbC4/edit#heading=h.td4yhfm12fe3 > > R=primiano@chromium.org,skyostil@chromium.org,fmeawad@chromium.org,rockot@chromium.org > BUG= 691886 > > Review-Url: https://codereview.chromium.org/2798713002 > Cr-Commit-Position: refs/heads/master@{#468002} > Committed: https://chromium.googlesource.com/chromium/src/+/de0f39d2a625433e60b5e22e1d2d3803f3d219e5 TBR=chrisha@chromium.org,dcheng@chromium.org,fmeawad@chromium.org,jam@chromium.org,nasko@chromium.org,primiano@chromium.org,rockot@chromium.org,skyostil@chromium.org,oysteine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 691886 Review-Url: https://codereview.chromium.org/2851813002 Cr-Commit-Position: refs/heads/master@{#468061} [modify] https://crrev.com/1d19b802b839f71f5d077fe3edb92e7902f4db52/services/resource_coordinator/BUILD.gn [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/DEPS [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/coordination_unit/coordination_unit_impl.h [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.h [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/manifest.json [modify] https://crrev.com/1d19b802b839f71f5d077fe3edb92e7902f4db52/services/resource_coordinator/public/cpp/BUILD.gn [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/public/cpp/OWNERS [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/public/cpp/coordination_unit.typemap [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/public/cpp/coordination_unit_id.cc [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/public/cpp/coordination_unit_id.h [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/public/cpp/coordination_unit_struct_traits.cc [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/public/cpp/coordination_unit_struct_traits.h [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/public/cpp/coordination_unit_types.h [add] https://crrev.com/1d19b802b839f71f5d077fe3edb92e7902f4db52/services/resource_coordinator/public/cpp/memory/memory_export.h [modify] https://crrev.com/1d19b802b839f71f5d077fe3edb92e7902f4db52/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h [modify] https://crrev.com/1d19b802b839f71f5d077fe3edb92e7902f4db52/services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl.h [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/public/cpp/resource_coordinator_export.h [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/public/cpp/resource_coordinator_interface.cc [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/public/cpp/resource_coordinator_interface.h [modify] https://crrev.com/1d19b802b839f71f5d077fe3edb92e7902f4db52/services/resource_coordinator/public/cpp/typemaps.gni [modify] https://crrev.com/1d19b802b839f71f5d077fe3edb92e7902f4db52/services/resource_coordinator/public/interfaces/BUILD.gn [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/public/interfaces/coordination_unit.mojom [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/public/interfaces/coordination_unit_provider.mojom [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/public/interfaces/events.mojom [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/public/interfaces/service_constants.mojom [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/resource_coordinator_service.cc [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/resource_coordinator_service.h [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/resource_coordinator_service_unittest.cc [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/service_main.cc [delete] https://crrev.com/2f0dc80853e042b73036d403c6a9368b94e11e50/services/resource_coordinator/unittest_manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecae763d2aaead2c51cfedd0628ec74be4cad7b2 commit ecae763d2aaead2c51cfedd0628ec74be4cad7b2 Author: oysteine <oysteine@chromium.org> Date: Wed May 03 22:33:44 2017 Revert of Global Resource Coordinator: Basic service internals (patchset #33 id:620001 of https://codereview.chromium.org/2798713002/ ) Reason for revert: Reverting again as this is still breaking https://bugs.chromium.org/p/chromium/issues/detail?id=716553 Original issue's description: > Reland: Global Resource Coordinator: Basic service internals > > This adds the basic internals of the GRC; CoordinationUnits which can form a DAG, receive events, and send back updated resource usage policies. > > A full prototype of GRC usage can be seen here: https://codereview.chromium.org/2710823003 > > Service architecture doc: https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9bzI/edit# > > GRC parent doc (internal only): https://docs.google.com/document/d/1dx4KDbDFvP-GWwwrSPg8Gxx4kboIoPi8kDKTSXoTbC4/edit#heading=h.td4yhfm12fe3 > > R=primiano@chromium.org,skyostil@chromium.org,fmeawad@chromium.org,rockot@chromium.org > BUG= 691886 > > Review-Url: https://codereview.chromium.org/2798713002 > Cr-Original-Commit-Position: refs/heads/master@{#468002} > Committed: https://chromium.googlesource.com/chromium/src/+/de0f39d2a625433e60b5e22e1d2d3803f3d219e5 > Review-Url: https://codereview.chromium.org/2798713002 > Cr-Commit-Position: refs/heads/master@{#469107} > Committed: https://chromium.googlesource.com/chromium/src/+/8b47351be59f0d590d8d5fcffe1c07350ba110f2 TBR=chrisha@chromium.org,dcheng@chromium.org,fmeawad@chromium.org,jam@chromium.org,nasko@chromium.org,primiano@chromium.org,rockot@chromium.org,skyostil@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 691886 Review-Url: https://codereview.chromium.org/2856173003 Cr-Commit-Position: refs/heads/master@{#469172} [modify] https://crrev.com/ecae763d2aaead2c51cfedd0628ec74be4cad7b2/services/resource_coordinator/BUILD.gn [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/DEPS [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/coordination_unit/coordination_unit_impl.h [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.h [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/manifest.json [modify] https://crrev.com/ecae763d2aaead2c51cfedd0628ec74be4cad7b2/services/resource_coordinator/public/cpp/BUILD.gn [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/public/cpp/OWNERS [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/public/cpp/coordination_unit.typemap [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/public/cpp/coordination_unit_id.cc [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/public/cpp/coordination_unit_id.h [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/public/cpp/coordination_unit_struct_traits.cc [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/public/cpp/coordination_unit_struct_traits.h [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/public/cpp/coordination_unit_types.h [add] https://crrev.com/ecae763d2aaead2c51cfedd0628ec74be4cad7b2/services/resource_coordinator/public/cpp/memory/memory_export.h [modify] https://crrev.com/ecae763d2aaead2c51cfedd0628ec74be4cad7b2/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h [modify] https://crrev.com/ecae763d2aaead2c51cfedd0628ec74be4cad7b2/services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl.h [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/public/cpp/resource_coordinator_export.h [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/public/cpp/resource_coordinator_interface.cc [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/public/cpp/resource_coordinator_interface.h [modify] https://crrev.com/ecae763d2aaead2c51cfedd0628ec74be4cad7b2/services/resource_coordinator/public/cpp/typemaps.gni [modify] https://crrev.com/ecae763d2aaead2c51cfedd0628ec74be4cad7b2/services/resource_coordinator/public/interfaces/BUILD.gn [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/public/interfaces/coordination_unit.mojom [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/public/interfaces/coordination_unit_provider.mojom [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/public/interfaces/events.mojom [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/public/interfaces/service_constants.mojom [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/resource_coordinator_service.cc [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/resource_coordinator_service.h [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/resource_coordinator_service_unittest.cc [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/service_main.cc [delete] https://crrev.com/30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0/services/resource_coordinator/unittest_manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea57f11806604d841b31336cb4da7dda36c8b1b7 commit ea57f11806604d841b31336cb4da7dda36c8b1b7 Author: oysteine <oysteine@chromium.org> Date: Fri May 05 17:52:44 2017 Reland: Global Resource Coordinator: Basic service internals This adds the basic internals of the GRC; CoordinationUnits which can form a DAG, receive events, and send back updated resource usage policies. A full prototype of GRC usage can be seen here: https://codereview.chromium.org/2710823003 Service architecture doc: https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9bzI/edit# GRC parent doc (internal only): https://docs.google.com/document/d/1dx4KDbDFvP-GWwwrSPg8Gxx4kboIoPi8kDKTSXoTbC4/edit#heading=h.td4yhfm12fe3 R=primiano@chromium.org,skyostil@chromium.org,fmeawad@chromium.org,rockot@chromium.org BUG= 691886 Review-Url: https://codereview.chromium.org/2798713002 Cr-Original-Original-Commit-Position: refs/heads/master@{#468002} Committed: https://chromium.googlesource.com/chromium/src/+/de0f39d2a625433e60b5e22e1d2d3803f3d219e5 Review-Url: https://codereview.chromium.org/2798713002 Cr-Original-Commit-Position: refs/heads/master@{#469107} Committed: https://chromium.googlesource.com/chromium/src/+/8b47351be59f0d590d8d5fcffe1c07350ba110f2 Review-Url: https://codereview.chromium.org/2798713002 Cr-Commit-Position: refs/heads/master@{#469713} [modify] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/BUILD.gn [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/DEPS [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/coordination_unit/coordination_unit_impl.h [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.h [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/manifest.json [modify] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/cpp/BUILD.gn [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/cpp/OWNERS [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/cpp/coordination_unit.typemap [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/cpp/coordination_unit_id.cc [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/cpp/coordination_unit_id.h [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/cpp/coordination_unit_struct_traits.cc [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/cpp/coordination_unit_struct_traits.h [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/cpp/coordination_unit_types.h [delete] https://crrev.com/1290a798ea209beefb9c00e8836aa91e0cf8b87f/services/resource_coordinator/public/cpp/memory/memory_export.h [modify] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h [modify] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl.h [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/cpp/resource_coordinator_export.h [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/cpp/resource_coordinator_interface.cc [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/cpp/resource_coordinator_interface.h [modify] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/cpp/typemaps.gni [modify] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/interfaces/BUILD.gn [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/interfaces/coordination_unit.mojom [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/interfaces/coordination_unit_provider.mojom [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/interfaces/events.mojom [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/public/interfaces/service_constants.mojom [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/resource_coordinator_service.cc [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/resource_coordinator_service.h [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/resource_coordinator_service_unittest.cc [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/service_main.cc [add] https://crrev.com/ea57f11806604d841b31336cb4da7dda36c8b1b7/services/resource_coordinator/unittest_manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5 commit 8c8d3b706a58e5772fd8ff31001abeccc94a3fa5 Author: oysteine <oysteine@chromium.org> Date: Thu May 18 15:18:17 2017 GRC: Added Tab coordination units behind a feature flag This also hooks up the GRC service itself, and sends tab visibility signals through. BUG= 691886 Review-Url: https://codereview.chromium.org/2871353002 Cr-Commit-Position: refs/heads/master@{#472817} [modify] https://crrev.com/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5/chrome/browser/BUILD.gn [modify] https://crrev.com/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5/chrome/browser/DEPS [add] https://crrev.com/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5/chrome/browser/resource_coordinator/OWNERS [add] https://crrev.com/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc [add] https://crrev.com/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h [modify] https://crrev.com/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5/chrome/browser/ui/tab_helpers.cc [modify] https://crrev.com/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5/content/browser/BUILD.gn [modify] https://crrev.com/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5/content/public/app/BUILD.gn [modify] https://crrev.com/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5/services/resource_coordinator/public/cpp/BUILD.gn [add] https://crrev.com/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5/services/resource_coordinator/public/cpp/resource_coordinator_features.cc [add] https://crrev.com/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5/services/resource_coordinator/public/cpp/resource_coordinator_features.h [modify] https://crrev.com/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5/services/resource_coordinator/public/cpp/resource_coordinator_interface.h
Copied issue chromium:691886 to issue chromium:724303
Copied issue chromium:691886 to issue chromium:724304
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/617fde26d470b3521f465971163b40566bd28520 commit 617fde26d470b3521f465971163b40566bd28520 Author: lpy <lpy@chromium.org> Date: Fri Jun 02 19:35:02 2017 [GRC] Fix BUILD.gn for blink. BUG= 691886 Review-Url: https://codereview.chromium.org/2922763002 Cr-Commit-Position: refs/heads/master@{#476755} [modify] https://crrev.com/617fde26d470b3521f465971163b40566bd28520/services/resource_coordinator/public/interfaces/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b2a1ee8bdcc6ff7e3d31e613964bd883141a5d8 commit 2b2a1ee8bdcc6ff7e3d31e613964bd883141a5d8 Author: oysteine <oysteine@chromium.org> Date: Tue Jun 06 02:29:48 2017 GRC: Hook up the frame-level CoordinationUnit This gets hooked up in the browser process and made available to the renderer process on request. It's created on demand, and currently won't be instantiated without the GlobalResourceCoordinator feature flag. An example of full GRC usage can be seen in https://codereview.chromium.org/2710823003 R=nasko@chromium.org BUG= 691886 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2913253002 Cr-Commit-Position: refs/heads/master@{#477157} [modify] https://crrev.com/2b2a1ee8bdcc6ff7e3d31e613964bd883141a5d8/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc [modify] https://crrev.com/2b2a1ee8bdcc6ff7e3d31e613964bd883141a5d8/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h [modify] https://crrev.com/2b2a1ee8bdcc6ff7e3d31e613964bd883141a5d8/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/2b2a1ee8bdcc6ff7e3d31e613964bd883141a5d8/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/2b2a1ee8bdcc6ff7e3d31e613964bd883141a5d8/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/2b2a1ee8bdcc6ff7e3d31e613964bd883141a5d8/content/public/browser/render_frame_host.h [modify] https://crrev.com/2b2a1ee8bdcc6ff7e3d31e613964bd883141a5d8/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [modify] https://crrev.com/2b2a1ee8bdcc6ff7e3d31e613964bd883141a5d8/services/resource_coordinator/coordination_unit/coordination_unit_impl.h [modify] https://crrev.com/2b2a1ee8bdcc6ff7e3d31e613964bd883141a5d8/services/resource_coordinator/public/interfaces/coordination_unit.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ba96b06da25d3e9e905a3a6d2c22f347ecdc9fe commit 2ba96b06da25d3e9e905a3a6d2c22f347ecdc9fe Author: oysteine <oysteine@chromium.org> Date: Tue Jun 06 06:43:45 2017 GRC: Hook up process-level CoordinationUnits in the browser process It's created on demand, and currently won't be instantiated without the GlobalResourceCoordinator feature flag. An example of full GRC usage can be seen in https://codereview.chromium.org/2710823003 This CL depends on https://codereview.chromium.org/2913253002 R=nasko@chromium.org BUG= 691886 Review-Url: https://codereview.chromium.org/2921663003 Cr-Commit-Position: refs/heads/master@{#477217} [modify] https://crrev.com/2ba96b06da25d3e9e905a3a6d2c22f347ecdc9fe/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc [modify] https://crrev.com/2ba96b06da25d3e9e905a3a6d2c22f347ecdc9fe/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/2ba96b06da25d3e9e905a3a6d2c22f347ecdc9fe/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/2ba96b06da25d3e9e905a3a6d2c22f347ecdc9fe/content/public/browser/render_process_host.h [modify] https://crrev.com/2ba96b06da25d3e9e905a3a6d2c22f347ecdc9fe/content/public/test/mock_render_process_host.cc [modify] https://crrev.com/2ba96b06da25d3e9e905a3a6d2c22f347ecdc9fe/content/public/test/mock_render_process_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c265a308a311a7d65ab37c10cf84830ddea72d5 commit 5c265a308a311a7d65ab37c10cf84830ddea72d5 Author: lpy <lpy@chromium.org> Date: Tue Jun 06 21:51:01 2017 [GRC] GRC service plumbing in Blink. This patch hooks Frame-level CoordinationUnit in Blink up to GRC service behind a flag. This patch depends on https://codereview.chromium.org/2913253002 landing first, or there's nothing providing the CoordinationUnit interface in navigation:frame and will fail run-time (if the feature-flag is enabled). An example of full GRC usage can be seen in https://codereview.chromium.org/2710823003 BUG= 691886 Review-Url: https://codereview.chromium.org/2914243003 Cr-Commit-Position: refs/heads/master@{#477423} [modify] https://crrev.com/5c265a308a311a7d65ab37c10cf84830ddea72d5/services/resource_coordinator/public/cpp/BUILD.gn [modify] https://crrev.com/5c265a308a311a7d65ab37c10cf84830ddea72d5/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/5c265a308a311a7d65ab37c10cf84830ddea72d5/third_party/WebKit/Source/core/frame/LocalFrame.h [modify] https://crrev.com/5c265a308a311a7d65ab37c10cf84830ddea72d5/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/5c265a308a311a7d65ab37c10cf84830ddea72d5/third_party/WebKit/Source/platform/DEPS [add] https://crrev.com/5c265a308a311a7d65ab37c10cf84830ddea72d5/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/DEPS [add] https://crrev.com/5c265a308a311a7d65ab37c10cf84830ddea72d5/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/FrameResourceCoordinator.cpp [add] https://crrev.com/5c265a308a311a7d65ab37c10cf84830ddea72d5/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/FrameResourceCoordinator.h [add] https://crrev.com/5c265a308a311a7d65ab37c10cf84830ddea72d5/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/OWNERS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/817370ae855c288809072aecb07e6063a13eda79 commit 817370ae855c288809072aecb07e6063a13eda79 Author: lpy <lpy@chromium.org> Date: Fri Jun 30 17:51:05 2017 [GRC] Hook up the process-level CoordinationUnit This gets hooked up in the browser process and made available to the renderer process on request. It's created on demand, and currently won't be instantiated without the GlobalResourceCoordinator feature flag. An example of full GRC usage can be seen in https://codereview.chromium.org/2710823003 BUG= 691886 Review-Url: https://codereview.chromium.org/2959383002 Cr-Commit-Position: refs/heads/master@{#483749} [modify] https://crrev.com/817370ae855c288809072aecb07e6063a13eda79/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/817370ae855c288809072aecb07e6063a13eda79/content/public/app/mojo/content_browser_manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0717ce2e90081c6d915dee987153f8d5f3a929c commit e0717ce2e90081c6d915dee987153f8d5f3a929c Author: matthalp <matthalp@google.com> Date: Sat Jul 01 00:52:59 2017 [GRC] Add Tab-scoped Coordination Unit Graph Observer This CL adds a CoordinationUnitGraphObserver scoped to observing activities corresponding to tabs (i.e. WebContents) and enables it to be active within GRC. A drive-by test name change was performed unrelated to the observer. R=lpy@chromium.org,zhenw@chromium.org TBR=oysteine@chromium.org BUG= 691886 Review-Url: https://codereview.chromium.org/2965553002 Cr-Commit-Position: refs/heads/master@{#483878} [modify] https://crrev.com/e0717ce2e90081c6d915dee987153f8d5f3a929c/services/resource_coordinator/BUILD.gn [modify] https://crrev.com/e0717ce2e90081c6d915dee987153f8d5f3a929c/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.h [modify] https://crrev.com/e0717ce2e90081c6d915dee987153f8d5f3a929c/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer_unittest.cc [add] https://crrev.com/e0717ce2e90081c6d915dee987153f8d5f3a929c/services/resource_coordinator/coordination_unit/tab_signal_generator.cc [add] https://crrev.com/e0717ce2e90081c6d915dee987153f8d5f3a929c/services/resource_coordinator/coordination_unit/tab_signal_generator.h [modify] https://crrev.com/e0717ce2e90081c6d915dee987153f8d5f3a929c/services/resource_coordinator/resource_coordinator_service.cc [modify] https://crrev.com/e0717ce2e90081c6d915dee987153f8d5f3a929c/services/resource_coordinator/resource_coordinator_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674 commit 3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674 Author: matthalp <matthalp@google.com> Date: Sat Jul 01 03:39:26 2017 [GRC] Tab-level CPU Attribution This CL enabled CPU usage attribution at a tab-level granularity within GRC. Platform CPU usage metrics can only perform measurements at a process-level granularity. To attribute the measured process-level CPU usage measurements to tabs, the following calculation is performed as follows: 1. A render process's CPU usage is equally attributable to all of it's children tabs (i.e. process_cpu_usage / num_tabs). 2. For a tab that uses multiple render processes (i.e. out-of-process iFrames), it's CPU usage is the sum of (1) for each of these render processes. R=lpy@chromium.org,zhenw@chromium.org TBR=oysteine@chromium.org BUG= 691886 Review-Url: https://codereview.chromium.org/2954413004 Cr-Commit-Position: refs/heads/master@{#483900} [modify] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/BUILD.gn [modify] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/coordination_unit/coordination_unit_factory.cc [modify] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [modify] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/coordination_unit/coordination_unit_impl.h [modify] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc [modify] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest_util.cc [modify] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest_util.h [add] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.cc [add] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.h [modify] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc [modify] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h [modify] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/coordination_unit/process_coordination_unit_impl_unittest.cc [add] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.cc [add] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.h [modify] https://crrev.com/3668e4d71c7cefe86d1edf8a4e01d1bbaeb5d674/services/resource_coordinator/public/interfaces/coordination_unit.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75bf68312a3998a396bbc0a44f88e0b62acb17ec commit 75bf68312a3998a396bbc0a44f88e0b62acb17ec Author: Matthew Halpern <matthalp@google.com> Date: Fri Jul 07 18:35:39 2017 [GRC] Remove ambiguity from CoordinationUnitImpl property operations The following changes address ambiguity regarding the methods related to the CoordinationUnitImpl property store: 1. Eliminate the mojom::Property struct Previously, a mojom::Property struct was used to set properties using the Mojo interface to a particular CoordinationUnit, while a key-value approach was used locally. The latter is the preferred approach, making the mojom::Property unnecessary. 2. Remove CoordinationUnitImpl::ClearProperty (for now) A CoordinationUnitImpl::ClearProperty was added but never actually used for anything. It has been removed for now as its use is unclear. If a valid use case is found it can be added back. Bug: 691886 Change-Id: I2d8fa1478c1bf784b29d9783fca2acddab25062b Reviewed-on: https://chromium-review.googlesource.com/562917 Reviewed-by: Zhen Wang <zhenw@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Matthew Halpern <matthalp@google.com> Cr-Commit-Position: refs/heads/master@{#484994} [modify] https://crrev.com/75bf68312a3998a396bbc0a44f88e0b62acb17ec/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.h [modify] https://crrev.com/75bf68312a3998a396bbc0a44f88e0b62acb17ec/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer_unittest.cc [modify] https://crrev.com/75bf68312a3998a396bbc0a44f88e0b62acb17ec/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [modify] https://crrev.com/75bf68312a3998a396bbc0a44f88e0b62acb17ec/services/resource_coordinator/coordination_unit/coordination_unit_impl.h [modify] https://crrev.com/75bf68312a3998a396bbc0a44f88e0b62acb17ec/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc [modify] https://crrev.com/75bf68312a3998a396bbc0a44f88e0b62acb17ec/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc [modify] https://crrev.com/75bf68312a3998a396bbc0a44f88e0b62acb17ec/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h [modify] https://crrev.com/75bf68312a3998a396bbc0a44f88e0b62acb17ec/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.cc [modify] https://crrev.com/75bf68312a3998a396bbc0a44f88e0b62acb17ec/services/resource_coordinator/public/interfaces/coordination_unit.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3c9a82477256a0f8dd9ee8f803f340cf194cc17 commit b3c9a82477256a0f8dd9ee8f803f340cf194cc17 Author: Matthew Halpern <matthalp@google.com> Date: Fri Jul 07 20:13:43 2017 [GRC] Add Tab-level CPU Usage Attribution Tests This CL adds tab-level CPU usage attribution tests for GRC. Tab-level CPU usage attribution is tested under a variety of different coordination unit graph topologies. A set of mock coordination unit graph topologies has also been added to the code base as a common set of coordination unit graph topologies has emerged across the coordination unit unittests. Bug: 691886 Change-Id: I2e9178ca5454846320add15f9f004ba0d9df2a9f Reviewed-on: https://chromium-review.googlesource.com/562549 Commit-Queue: Matthew Halpern <matthalp@google.com> Reviewed-by: Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#485024} [modify] https://crrev.com/b3c9a82477256a0f8dd9ee8f803f340cf194cc17/services/resource_coordinator/BUILD.gn [modify] https://crrev.com/b3c9a82477256a0f8dd9ee8f803f340cf194cc17/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc [add] https://crrev.com/b3c9a82477256a0f8dd9ee8f803f340cf194cc17/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.cc [add] https://crrev.com/b3c9a82477256a0f8dd9ee8f803f340cf194cc17/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.h [add] https://crrev.com/b3c9a82477256a0f8dd9ee8f803f340cf194cc17/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a39d6098709c2efec55e8832ae3a17ec428350d4 commit a39d6098709c2efec55e8832ae3a17ec428350d4 Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Jul 07 21:14:31 2017 Revert "[GRC] Add Tab-level CPU Usage Attribution Tests" This reverts commit b3c9a82477256a0f8dd9ee8f803f340cf194cc17. Reason for revert: Dependent CL https://chromium-review.googlesource.com/c/562917 is causing failures in services_unittests. I'm reverting both. Original change's description: > [GRC] Add Tab-level CPU Usage Attribution Tests > > This CL adds tab-level CPU usage attribution tests for GRC. Tab-level CPU usage attribution is tested under a variety of different coordination unit graph topologies. > > A set of mock coordination unit graph topologies has also been added to the code base as a common set of coordination unit graph topologies has emerged across the coordination unit unittests. > > Bug: 691886 > Change-Id: I2e9178ca5454846320add15f9f004ba0d9df2a9f > Reviewed-on: https://chromium-review.googlesource.com/562549 > Commit-Queue: Matthew Halpern <matthalp@google.com> > Reviewed-by: Zhen Wang <zhenw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485024} TBR=zhenw@chromium.org,oysteine@chromium.org,lpy@chromium.org,matthalp@google.com Change-Id: Ic498713510edfe2ce741b37b101444f221d990e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 691886 Reviewed-on: https://chromium-review.googlesource.com/564096 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#485048} [modify] https://crrev.com/a39d6098709c2efec55e8832ae3a17ec428350d4/services/resource_coordinator/BUILD.gn [modify] https://crrev.com/a39d6098709c2efec55e8832ae3a17ec428350d4/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc [delete] https://crrev.com/1ad4642b4db1398fd6f9dbb2cbd659a347e60c99/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.cc [delete] https://crrev.com/1ad4642b4db1398fd6f9dbb2cbd659a347e60c99/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.h [delete] https://crrev.com/1ad4642b4db1398fd6f9dbb2cbd659a347e60c99/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d0c9f269cca30c1c410e5656b2b481b5860f20e commit 2d0c9f269cca30c1c410e5656b2b481b5860f20e Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Jul 07 21:19:23 2017 Revert "[GRC] Remove ambiguity from CoordinationUnitImpl property operations" This reverts commit 75bf68312a3998a396bbc0a44f88e0b62acb17ec. Reason for revert: Causing failures in services_unittests on Chrome OS builders. Sample failure: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/27980 Original change's description: > [GRC] Remove ambiguity from CoordinationUnitImpl property operations > > The following changes address ambiguity regarding the methods related > to the CoordinationUnitImpl property store: > > 1. Eliminate the mojom::Property struct > Previously, a mojom::Property struct was used to set properties > using the Mojo interface to a particular CoordinationUnit, while > a key-value approach was used locally. The latter is the preferred > approach, making the mojom::Property unnecessary. > > 2. Remove CoordinationUnitImpl::ClearProperty (for now) > A CoordinationUnitImpl::ClearProperty was added but never actually > used for anything. It has been removed for now as its use is > unclear. If a valid use case is found it can be added back. > > Bug: 691886 > Change-Id: I2d8fa1478c1bf784b29d9783fca2acddab25062b > Reviewed-on: https://chromium-review.googlesource.com/562917 > Reviewed-by: Zhen Wang <zhenw@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Matthew Halpern <matthalp@google.com> > Cr-Commit-Position: refs/heads/master@{#484994} TBR=dcheng@chromium.org,zhenw@chromium.org,oysteine@chromium.org,lpy@chromium.org,matthalp@google.com Change-Id: Ic8f2ea1160f020aea7361cf553e709bee9ef599d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 691886 Reviewed-on: https://chromium-review.googlesource.com/564116 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#485052} [modify] https://crrev.com/2d0c9f269cca30c1c410e5656b2b481b5860f20e/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.h [modify] https://crrev.com/2d0c9f269cca30c1c410e5656b2b481b5860f20e/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer_unittest.cc [modify] https://crrev.com/2d0c9f269cca30c1c410e5656b2b481b5860f20e/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [modify] https://crrev.com/2d0c9f269cca30c1c410e5656b2b481b5860f20e/services/resource_coordinator/coordination_unit/coordination_unit_impl.h [modify] https://crrev.com/2d0c9f269cca30c1c410e5656b2b481b5860f20e/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc [modify] https://crrev.com/2d0c9f269cca30c1c410e5656b2b481b5860f20e/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc [modify] https://crrev.com/2d0c9f269cca30c1c410e5656b2b481b5860f20e/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h [modify] https://crrev.com/2d0c9f269cca30c1c410e5656b2b481b5860f20e/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.cc [modify] https://crrev.com/2d0c9f269cca30c1c410e5656b2b481b5860f20e/services/resource_coordinator/public/interfaces/coordination_unit.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fac6685c5363636ee61637353f5875c5c2db220 commit 1fac6685c5363636ee61637353f5875c5c2db220 Author: Matthew Halpern <matthalp@google.com> Date: Wed Jul 12 02:34:31 2017 Reland "[GRC] Remove ambiguity from CoordinationUnitImpl property operations" This is a reland of 75bf68312a3998a396bbc0a44f88e0b62acb17ec Original change's description: > [GRC] Remove ambiguity from CoordinationUnitImpl property operations > > The following changes address ambiguity regarding the methods related > to the CoordinationUnitImpl property store: > > 1. Eliminate the mojom::Property struct > Previously, a mojom::Property struct was used to set properties > using the Mojo interface to a particular CoordinationUnit, while > a key-value approach was used locally. The latter is the preferred > approach, making the mojom::Property unnecessary. > > 2. Remove CoordinationUnitImpl::ClearProperty (for now) > A CoordinationUnitImpl::ClearProperty was added but never actually > used for anything. It has been removed for now as its use is > unclear. If a valid use case is found it can be added back. > > Bug: 691886 > Change-Id: I2d8fa1478c1bf784b29d9783fca2acddab25062b > Reviewed-on: https://chromium-review.googlesource.com/562917 > Reviewed-by: Zhen Wang <zhenw@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Matthew Halpern <matthalp@google.com> > Cr-Commit-Position: refs/heads/master@{#484994} Bug: 691886 Change-Id: I928ad1aab4000c29345ad3476b09d2584d117af0 Reviewed-on: https://chromium-review.googlesource.com/564090 Commit-Queue: Matthew Halpern <matthalp@google.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#485810} [modify] https://crrev.com/1fac6685c5363636ee61637353f5875c5c2db220/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.h [modify] https://crrev.com/1fac6685c5363636ee61637353f5875c5c2db220/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer_unittest.cc [modify] https://crrev.com/1fac6685c5363636ee61637353f5875c5c2db220/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [modify] https://crrev.com/1fac6685c5363636ee61637353f5875c5c2db220/services/resource_coordinator/coordination_unit/coordination_unit_impl.h [modify] https://crrev.com/1fac6685c5363636ee61637353f5875c5c2db220/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc [modify] https://crrev.com/1fac6685c5363636ee61637353f5875c5c2db220/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc [modify] https://crrev.com/1fac6685c5363636ee61637353f5875c5c2db220/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h [modify] https://crrev.com/1fac6685c5363636ee61637353f5875c5c2db220/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.cc [modify] https://crrev.com/1fac6685c5363636ee61637353f5875c5c2db220/services/resource_coordinator/public/interfaces/coordination_unit.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f0104616de6701d33ea4b7ba2a0a946c66321b1 commit 1f0104616de6701d33ea4b7ba2a0a946c66321b1 Author: Matthew Halpern <matthalp@google.com> Date: Thu Jul 13 03:02:26 2017 Reland "[GRC] Add Tab-level CPU Usage Attribution Tests" This is a reland of b3c9a82477256a0f8dd9ee8f803f340cf194cc17 Original change's description: > [GRC] Add Tab-level CPU Usage Attribution Tests > > This CL adds tab-level CPU usage attribution tests for GRC. Tab-level CPU usage attribution is tested under a variety of different coordination unit graph topologies. > > A set of mock coordination unit graph topologies has also been added to the code base as a common set of coordination unit graph topologies has emerged across the coordination unit unittests. > > Bug: 691886 > Change-Id: I2e9178ca5454846320add15f9f004ba0d9df2a9f > Reviewed-on: https://chromium-review.googlesource.com/562549 > Commit-Queue: Matthew Halpern <matthalp@google.com> > Reviewed-by: Zhen Wang <zhenw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485024} Bug: 691886 Change-Id: I91b5a898c4a9a6cf016a851c3637bebff17962ff Reviewed-on: https://chromium-review.googlesource.com/567239 Commit-Queue: Matthew Halpern <matthalp@google.com> Reviewed-by: Zhen Wang <zhenw@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#486243} [modify] https://crrev.com/1f0104616de6701d33ea4b7ba2a0a946c66321b1/services/resource_coordinator/BUILD.gn [modify] https://crrev.com/1f0104616de6701d33ea4b7ba2a0a946c66321b1/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc [add] https://crrev.com/1f0104616de6701d33ea4b7ba2a0a946c66321b1/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.cc [add] https://crrev.com/1f0104616de6701d33ea4b7ba2a0a946c66321b1/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.h [add] https://crrev.com/1f0104616de6701d33ea4b7ba2a0a946c66321b1/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f commit cd7e31fb911a98c7dc021d543e9dea8c553cdb1f Author: Matthew Halpern <matthalp@google.com> Date: Wed Jul 19 20:50:43 2017 Enable GRC This CL enables GlobalResourceCoordinator (e.g. resource_coordinator service, GRC) by default. Several projects depend on the GRC service. Features using GRC should be guarded by their own feature flag and run their own finch trials. Several fixes needed to occur to make this happen: - Remove buggy GRC process CPU profiling infrastructure. An updated version will be added in: https://chromium-review.googlesource.com/c/565906/ - Improve MockRenderProcessHost to allow GetProcessResourceCoordinator to be called with connections to the test ServiceManager - ResourceCoordinatorWebContentsObserver::IsEnabled checks to make sure ServiceManagerConnection is available to connect to. - Disable FrameResourceCoordinator because WebFrameClient subclasses do not implement GetInterfaceProvider and crash when being called. This CL has been extended and migrated from CodeReview: https://codereview.chromium.org/2958133003 which was originally being landed on behalf of zhenw@: https://codereview.chromium.org/2943563002 R=oysteine@chromium.org, zhenw@chromium.org,lpy@chromium.org,rockot@chromium.org,nasko@chromium.org BUG= 691886 patch from issue 2958133003 at patchset 710001 (http://crrev.com/2958133003#ps710001) Change-Id: Ie6b61e93666ba9e753a218a79e2cff64646e7644 Reviewed-on: https://chromium-review.googlesource.com/572429 Commit-Queue: Matthew Halpern <matthalp@google.com> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Zhen Wang <zhenw@chromium.org> Reviewed-by: Oystein Eftevaag <oysteine@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#487968} [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/chrome/browser/resource_coordinator/tab_manager.cc [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/chrome/browser/resource_coordinator/tab_manager_grc_tab_signal_observer.cc [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/chrome/browser/resource_coordinator/tab_manager_grc_tab_signal_observer.h [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/content/public/test/DEPS [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/content/public/test/mock_render_process_host.cc [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/content/public/test/mock_render_process_host.h [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/services/resource_coordinator/BUILD.gn [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h [delete] https://crrev.com/e4be4c00197b24f8d0c471da9e087b5646a9d7f5/services/resource_coordinator/coordination_unit/process_coordination_unit_impl_unittest.cc [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/services/resource_coordinator/public/cpp/resource_coordinator_features.cc [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/services/resource_coordinator/public/cpp/resource_coordinator_interface.cc [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/services/resource_coordinator/public/cpp/resource_coordinator_interface.h [modify] https://crrev.com/cd7e31fb911a98c7dc021d543e9dea8c553cdb1f/third_party/WebKit/Source/platform/instrumentation/resource_coordinator/FrameResourceCoordinator.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da6644e36aeffbfc5914f255a18f8e82b3e7e691 commit da6644e36aeffbfc5914f255a18f8e82b3e7e691 Author: Matthew Halpern <matthalp@google.com> Date: Thu Jul 20 19:34:46 2017 [GRC] Decouple Render Process CPU Measurement from CU Graph Currently GRC's process CPU measurement mechanisms are tightly integrated with the process coordination unit implementation. This CL moves the CPU usage measurement from the resource_coordinator service to the content_browser service. Decoupling process CPU measurement from the CU model allows the coordination units to focus on representing browser state within GRC, rather than updating it. In GRC terms, the migrated render process CPU measurement infrastructure is a "probe" that externally triggers updates to the CU graph. A new feature flag has been added for enabling render process CPU usage profiling. To do so, run: out/Default/chrome --enable-features=GlobalResourceCoordinator,GRCRenderProcessCPUProfiling \ http://example.com BUG= 691886 ,741768 Change-Id: I2fc7609c6963776a167c5f76abe078dedb0e2efe Reviewed-on: https://chromium-review.googlesource.com/565906 Commit-Queue: Matthew Halpern <matthalp@google.com> Reviewed-by: Zhen Wang <zhenw@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Oystein Eftevaag <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#488352} [modify] https://crrev.com/da6644e36aeffbfc5914f255a18f8e82b3e7e691/chrome/browser/BUILD.gn [modify] https://crrev.com/da6644e36aeffbfc5914f255a18f8e82b3e7e691/chrome/browser/chrome_browser_main.cc [add] https://crrev.com/da6644e36aeffbfc5914f255a18f8e82b3e7e691/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.cc [add] https://crrev.com/da6644e36aeffbfc5914f255a18f8e82b3e7e691/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.h [add] https://crrev.com/da6644e36aeffbfc5914f255a18f8e82b3e7e691/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc [modify] https://crrev.com/da6644e36aeffbfc5914f255a18f8e82b3e7e691/chrome/test/BUILD.gn [modify] https://crrev.com/da6644e36aeffbfc5914f255a18f8e82b3e7e691/services/resource_coordinator/public/cpp/resource_coordinator_features.cc [modify] https://crrev.com/da6644e36aeffbfc5914f255a18f8e82b3e7e691/services/resource_coordinator/public/cpp/resource_coordinator_features.h [modify] https://crrev.com/da6644e36aeffbfc5914f255a18f8e82b3e7e691/services/resource_coordinator/public/cpp/resource_coordinator_interface.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53bda38b0633dffe27371cfb9f06426fc57c5a6d commit 53bda38b0633dffe27371cfb9f06426fc57c5a6d Author: Peiyong Lin <lpy@chromium.org> Date: Tue Jul 25 07:55:11 2017 [GRC] Fix child Frame Resource Coordinator not added correctly. Currently Frame Resource Coordinator is not added correctly to WebContents Resource Coordinator because we do incorrectly check to avoid cyclic reference. This patch fixes this problem and adds a test. BUG= 691886 Change-Id: Iecdb2be73f425414166b1779d4d2147f81a7881f Reviewed-on: https://chromium-review.googlesource.com/578648 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by: Zhen Wang <zhenw@chromium.org> Reviewed-by: Oystein Eftevaag <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#489250} [modify] https://crrev.com/53bda38b0633dffe27371cfb9f06426fc57c5a6d/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [modify] https://crrev.com/53bda38b0633dffe27371cfb9f06426fc57c5a6d/services/resource_coordinator/coordination_unit/coordination_unit_impl.h [modify] https://crrev.com/53bda38b0633dffe27371cfb9f06426fc57c5a6d/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc [modify] https://crrev.com/53bda38b0633dffe27371cfb9f06426fc57c5a6d/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.cc [modify] https://crrev.com/53bda38b0633dffe27371cfb9f06426fc57c5a6d/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.h [modify] https://crrev.com/53bda38b0633dffe27371cfb9f06426fc57c5a6d/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.cc [modify] https://crrev.com/53bda38b0633dffe27371cfb9f06426fc57c5a6d/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6d5827bc0e3a428d64eeadebb363bd003c5e361 commit e6d5827bc0e3a428d64eeadebb363bd003c5e361 Author: Matthew Halpern <matthalp@google.com> Date: Thu Aug 03 21:30:10 2017 [GRC] Tab-level CPU Profiling for UKM (via a Finch Trial) This CL enables tab-level CPU profiling infrastructure in GRC (i.e. the resource_coordinator service) and sends collected profiles to UKM. The CPU profiles consist of sequences of CPU measruements collected at a specified interval for a given period. Both the CPU use measurement interval and duration are configurable through Finch parameters. BUG= 691886 ,741768 Change-Id: I486f26db06789e16ff4a80a6c72e9ac869f29d8a Reviewed-on: https://chromium-review.googlesource.com/580288 Commit-Queue: Matthew Halpern <matthalp@google.com> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Zhen Wang <zhenw@chromium.org> Reviewed-by: Oystein Eftevaag <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#491850} [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.cc [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.h [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/metrics/public/cpp/ukm_source_id.h [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/BUILD.gn [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.h [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/coordination_unit_impl.h [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/coordination_unit_manager.cc [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/coordination_unit_manager.h [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.cc [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.h [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h [add] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/tab_metrics_collector.cc [add] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/tab_metrics_collector.h [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/tab_signal_generator_impl.cc [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/tab_signal_generator_impl.h [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.cc [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.h [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/public/cpp/resource_coordinator_features.cc [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/public/cpp/resource_coordinator_features.h [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/public/interfaces/coordination_unit.mojom [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/services/resource_coordinator/resource_coordinator_service.cc [modify] https://crrev.com/e6d5827bc0e3a428d64eeadebb363bd003c5e361/tools/metrics/ukm/ukm.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/103f77f4d54d200cd3b80597ce5b9ef4aacca644 commit 103f77f4d54d200cd3b80597ce5b9ef4aacca644 Author: Ojan Vafai <ojan@chromium.org> Date: Thu Aug 17 23:28:27 2017 Remove CoordinationPolicies. They're not used anymore. Bug: 691886 Change-Id: Ia1c2ec0dd9013b336eb80b6815cd581bd6ebdfec Reviewed-on: https://chromium-review.googlesource.com/613668 Commit-Queue: Ojan Vafai <ojan@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: lpy <lpy@chromium.org> Reviewed-by: Oystein Eftevaag <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#495378} [modify] https://crrev.com/103f77f4d54d200cd3b80597ce5b9ef4aacca644/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [modify] https://crrev.com/103f77f4d54d200cd3b80597ce5b9ef4aacca644/services/resource_coordinator/coordination_unit/coordination_unit_impl.h [modify] https://crrev.com/103f77f4d54d200cd3b80597ce5b9ef4aacca644/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc [modify] https://crrev.com/103f77f4d54d200cd3b80597ce5b9ef4aacca644/services/resource_coordinator/public/interfaces/coordination_unit.mojom [modify] https://crrev.com/103f77f4d54d200cd3b80597ce5b9ef4aacca644/services/resource_coordinator/public/interfaces/signals.mojom [modify] https://crrev.com/103f77f4d54d200cd3b80597ce5b9ef4aacca644/services/resource_coordinator/resource_coordinator_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/791626530d8819a9a44c7176ceb3e9b82c884738 commit 791626530d8819a9a44c7176ceb3e9b82c884738 Author: Peiyong Lin <lpy@chromium.org> Date: Wed Sep 13 20:19:03 2017 [GRC] Move CoordinationUnitGraphObserver to its own directory. BUG= 691886 Change-Id: I24970d1be3a714976b57c859897ca7c210ae0d97 Reviewed-on: https://chromium-review.googlesource.com/658147 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by: Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501733} [modify] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/BUILD.gn [modify] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [modify] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/coordination_unit/coordination_unit_manager.cc [modify] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc [modify] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.cc [modify] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.cc [modify] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl_unittest.cc [rename] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/observers/background_metrics_reporter.h [rename] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/observers/coordination_unit_graph_observer.cc [rename] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/observers/coordination_unit_graph_observer.h [rename] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/observers/coordination_unit_graph_observer_unittest.cc [rename] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/observers/metrics_collector.cc [rename] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/observers/metrics_collector.h [rename] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/observers/metrics_collector_unittest.cc [rename] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/observers/tab_signal_generator_impl.cc [rename] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/observers/tab_signal_generator_impl.h [rename] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/observers/tab_signal_generator_impl_unittest.cc [modify] https://crrev.com/791626530d8819a9a44c7176ceb3e9b82c884738/services/resource_coordinator/resource_coordinator_service.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dc8ae617834dec3009b75428fe8f4eabeaba130 commit 3dc8ae617834dec3009b75428fe8f4eabeaba130 Author: Peiyong Lin <lpy@chromium.org> Date: Wed Sep 13 23:23:10 2017 [ResourceCoordinator] Rename WebContents to Page in services/resource_coordinator/. WebContents is a concept in browser, we want to put resource coordinator closer to platform, thus rename all WebContents-prefix class to be Page-prefix since Page is the equivalent concept of WebContents in platform. Minor: rename some of the usage of tab to use page. BUG= 691886 Change-Id: I011643c4e69612a3610b286052bb0b41a0a9cd29 Reviewed-on: https://chromium-review.googlesource.com/663609 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Zhen Wang <zhenw@chromium.org> Commit-Queue: lpy <lpy@chromium.org> Cr-Commit-Position: refs/heads/master@{#501795} [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/BUILD.gn [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/coordination_unit/coordination_unit_impl.h [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.cc [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.cc [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.h [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.cc [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.h [rename] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/coordination_unit/page_coordination_unit_impl.cc [rename] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/coordination_unit/page_coordination_unit_impl.h [add] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/coordination_unit/page_coordination_unit_impl_unittest.cc [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc [delete] https://crrev.com/1eb56350d1b6aa3316f9ce52fc0ec50734cb276c/services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl_unittest.cc [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/observers/background_metrics_reporter.h [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/observers/coordination_unit_graph_observer.h [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/observers/metrics_collector.cc [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/observers/metrics_collector.h [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/observers/metrics_collector_unittest.cc [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/observers/tab_signal_generator_impl.cc [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/observers/tab_signal_generator_impl.h [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/observers/tab_signal_generator_impl_unittest.cc [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/public/cpp/coordination_unit_struct_traits.cc [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/public/cpp/coordination_unit_types.h [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/public/interfaces/coordination_unit.mojom [modify] https://crrev.com/3dc8ae617834dec3009b75428fe8f4eabeaba130/services/resource_coordinator/resource_coordinator_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c31a2bd1f636671fa48c7c3424a581f21b349b43 commit c31a2bd1f636671fa48c7c3424a581f21b349b43 Author: Peiyong Lin <lpy@chromium.org> Date: Wed Oct 04 00:35:54 2017 [GRC] Rename CoordinationUnitImpl to CoordinationUnitBase. This patch renames CoordinationUnitImpl to CoordinationUnitBase, currently CoordinationUnitImpl implements shared functionality for different types of CoordinationUnit, and is used as an abstract type, thus rename to CoordinationUnitBase to outline that it serves as base class for all CoordinationUnits. Minor: Rename CoordinationUnitImplTestBase to CoordinationUnitTestHarness. BUG= 691886 Change-Id: I306d2d83f30e54c6e12ad48d69b6346d7542e268 Reviewed-on: https://chromium-review.googlesource.com/572226 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#506249} [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/BUILD.gn [rename] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/coordination_unit_base.cc [rename] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/coordination_unit_base.h [rename] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/coordination_unit_base_unittest.cc [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.cc [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/coordination_unit_manager.cc [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/coordination_unit_manager.h [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.h [rename] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/coordination_unit_test_harness.cc [rename] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/coordination_unit_test_harness.h [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.cc [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.h [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.cc [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.h [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/page_coordination_unit_impl.cc [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/page_coordination_unit_impl.h [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/page_coordination_unit_impl_unittest.cc [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h [add] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/coordination_unit/process_coordination_unit_impl_unittest.cc [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/observers/coordination_unit_graph_observer.h [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/observers/coordination_unit_graph_observer_unittest.cc [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/observers/metrics_collector.cc [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/observers/metrics_collector.h [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/observers/metrics_collector_unittest.cc [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/observers/tab_signal_generator_impl.cc [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/observers/tab_signal_generator_impl.h [modify] https://crrev.com/c31a2bd1f636671fa48c7c3424a581f21b349b43/services/resource_coordinator/observers/tab_signal_generator_impl_unittest.cc
I think this can be assumed done? cc a bunch of people for record.
Issue 724304 has been merged into this issue.
Issue 724303 has been merged into this issue.
Bulk applying component Internals>Services>ServiceManager to issues referencing the text ServiceManager. This may not be 100% accurate, so please feel free to pull the component as needed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c3611e0a7cd093b9549ab912af54cd37aeb7096 commit 0c3611e0a7cd093b9549ab912af54cd37aeb7096 Author: Francois Doray <fdoray@chromium.org> Date: Thu Oct 04 20:52:14 2018 RC: Cleanup GlobalResourceCoordinator feature. This is step 8 of go/finch-best-practices. Bug: 691886 Change-Id: If2eaf11b08e975bd1dfa864e1ff8b2a90c70d6bf Reviewed-on: https://chromium-review.googlesource.com/c/1249906 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#596843} [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/chrome/browser/metrics/process_memory_metrics_emitter.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/chrome/browser/metrics/process_memory_metrics_emitter.h [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/chrome/browser/resource_coordinator/browser_child_process_watcher.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/chrome/browser/resource_coordinator/chrome_browser_main_extra_parts_resource_coordinator.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/chrome/browser/resource_coordinator/page_signal_receiver.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/chrome/browser/resource_coordinator/render_process_probe.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/chrome/browser/resource_coordinator/render_process_probe_browsertest.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/chrome/browser/resource_coordinator/tab_helper.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/services/resource_coordinator/public/cpp/resource_coordinator_features.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/services/resource_coordinator/public/cpp/resource_coordinator_features.h [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/third_party/blink/renderer/core/frame/local_frame.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/third_party/blink/renderer/platform/exported/platform.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/third_party/blink/renderer/platform/instrumentation/BUILD.gn [delete] https://crrev.com/aae05875997fd83069b7eb5c7d12b7932bb56187/third_party/blink/renderer/platform/instrumentation/resource_coordinator/blink_resource_coordinator_base.h [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/third_party/blink/renderer/platform/instrumentation/resource_coordinator/frame_resource_coordinator.h [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/third_party/blink/renderer/platform/instrumentation/resource_coordinator/renderer_resource_coordinator.h [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc [modify] https://crrev.com/0c3611e0a7cd093b9549ab912af54cd37aeb7096/third_party/blink/renderer/platform/testing/testing_platform_support.cc
Comment 1 by bugdroid1@chromium.org
, Feb 14 2017