New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691853 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Regression: Language settings page appears wrong-sized

Project Member Reported by varkha@chromium.org, Feb 14 2017

Issue description

Chrome Version: 58.0.3009.0
OS: Chrome OS

What steps will reproduce the problem?
(1) Open system menu
(2) Click "US Keyboard"
(3) Click settings (gear icon)

What is the expected result?
language-good.png

What happens instead?
language-bad.png

Breaking CL (from manual bisect):
https://codereview.chromium.org/2684793004 (r449702).
 
language-good.png
91.7 KB View Download
language-bad.png
102 KB View Download

Comment 1 by varkha@chromium.org, Feb 14 2017

Probably this block leaks outside of Bluetooth settings:
https://cs.chromium.org/chromium/src/chrome/browser/resources/options/chromeos/bluetooth.css?l=9

Comment 2 by x...@chromium.org, Feb 14 2017

Sorry! Didn't realize bluetooth.css is also used elsewhere. Will work on a fix. 
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be40a647b788038f94500f7329fa194ef8519d2d

commit be40a647b788038f94500f7329fa194ef8519d2d
Author: xdai <xdai@chromium.org>
Date: Tue Feb 14 22:09:36 2017

[ChromeOS] Fix the wrong language settings page size.

It's a regression caused by https://codereview.chromium.org/2684793004.

BUG= 691853 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2694273003
Cr-Commit-Position: refs/heads/master@{#450489}

[modify] https://crrev.com/be40a647b788038f94500f7329fa194ef8519d2d/chrome/browser/resources/chromeos/bluetooth_pair_device.css
[modify] https://crrev.com/be40a647b788038f94500f7329fa194ef8519d2d/chrome/browser/resources/options/chromeos/bluetooth.css

Comment 4 by x...@chromium.org, Feb 15 2017

Status: Fixed (was: Assigned)
Cc: shuchen@chromium.org xiangye@chromium.org zhan...@chromium.org michae...@chromium.org wuyingbing@chromium.org dbeam@chromium.org
 Issue 692366  has been merged into this issue.

Comment 6 by son...@google.com, Feb 21 2017

Status: Verified (was: Fixed)
Verified on build 9304.0.0

Sign in to add a comment