New issue
Advanced search Search tips

Issue 691848 link

Starred by 2 users
Status: Fixed
Owner:
pkotw...@chromium.org
Closed: Mar 2017
Cc:
pkotw...@chromium.org
boliu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add integration test to test starting renderer in WebAPK mode

Project Member Reported by pkotw...@chromium.org, Feb 14 2017 
Add integration test to test starting renderer in WebAPK mode


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by pkotw...@chromium.org, Feb 14 2017

Cc: pkotw...@chromium.org
Components: Mobile>WebAPKs
Owner: pkotw...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by boliu@chromium.org, Feb 14 2017 

also refactor code so UsedByReflection is not sprinkled all over the code base

Comment 3 by pkotw...@chromium.org, Feb 14 2017 

#2: I don't know how to refactor the code so that UsedByReflection is used less. ChildProcessServiceImpl is the only Chrome class which is used by reflection. In ChildProcessServiceImpl we only use 4 methods via reflection

Comment 4 by boliu@chromium.org, Feb 14 2017 

just write a wrapper class for anything that needs to be called via reflection, just a bunch of static methods or something

it's basically defining a public API

Comment 5 by boliu@chromium.org, Feb 14 2017 

> In ChildProcessServiceImpl we only use 4 methods via reflection

annotate them all
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61822c770a48bfdaa5a5d0e3b525db37123b1ce9

commit 61822c770a48bfdaa5a5d0e3b525db37123b1ce9
Author: sergeyu <sergeyu@chromium.org>
Date: Tue Feb 28 22:29:16 2017

Revert of Add integration tests for WebAPKs (patchset #5 id:180001 of https://codereview.chromium.org/2701333002/ )

Reason for revert:
Broke android build: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Builder

Original issue's description:
> Add integration tests for WebAPKs
>
> This CL adds an integration test to verify that launching a WebAPK:
> - Does not crash
> - The initial URL eventually finishes loading
> - The splash screen eventually hides
>
> BUG= 691848 
>
> Review-Url: https://codereview.chromium.org/2701333002
> Cr-Commit-Position: refs/heads/master@{#453700}
> Committed: https://chromium.googlesource.com/chromium/src/+/6a6e60653e99e4f6ae358a282e2893d05ef04427

TBR=dfalcantara@chromium.org,agrieve@chromium.org,pkotwicz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 691848 

Review-Url: https://codereview.chromium.org/2719403005
Cr-Commit-Position: refs/heads/master@{#453728}

[modify] https://crrev.com/61822c770a48bfdaa5a5d0e3b525db37123b1ce9/chrome/android/BUILD.gn
[modify] https://crrev.com/61822c770a48bfdaa5a5d0e3b525db37123b1ce9/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
[modify] https://crrev.com/61822c770a48bfdaa5a5d0e3b525db37123b1ce9/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/61822c770a48bfdaa5a5d0e3b525db37123b1ce9/chrome/android/java_sources.gni
[delete] https://crrev.com/4e0d26ac80d31bbfa773948f61122c635c5487f4/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java
[modify] https://crrev.com/61822c770a48bfdaa5a5d0e3b525db37123b1ce9/chrome/android/webapk/shell_apk/BUILD.gn
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5903684572a3df26e3eb91932a9de0174eb9b70

commit f5903684572a3df26e3eb91932a9de0174eb9b70
Author: sergeyu <sergeyu@chromium.org>
Date: Tue Feb 28 22:34:37 2017

Reland of Add integration tests for WebAPKs (patchset #1 id:1 of https://codereview.chromium.org/2719403005/ )

Reason for revert:
Build breakage not related to this CL.

Original issue's description:
> Revert of Add integration tests for WebAPKs (patchset #5 id:180001 of https://codereview.chromium.org/2701333002/ )
>
> Reason for revert:
> Broke android build: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Builder
>
> Original issue's description:
> > Add integration tests for WebAPKs
> >
> > This CL adds an integration test to verify that launching a WebAPK:
> > - Does not crash
> > - The initial URL eventually finishes loading
> > - The splash screen eventually hides
> >
> > BUG= 691848 
> >
> > Review-Url: https://codereview.chromium.org/2701333002
> > Cr-Commit-Position: refs/heads/master@{#453700}
> > Committed: https://chromium.googlesource.com/chromium/src/+/6a6e60653e99e4f6ae358a282e2893d05ef04427
>
> TBR=dfalcantara@chromium.org,agrieve@chromium.org,pkotwicz@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 691848 
>
> Review-Url: https://codereview.chromium.org/2719403005
> Cr-Commit-Position: refs/heads/master@{#453728}
> Committed: https://chromium.googlesource.com/chromium/src/+/61822c770a48bfdaa5a5d0e3b525db37123b1ce9

TBR=dfalcantara@chromium.org,agrieve@chromium.org,pkotwicz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 691848 

Review-Url: https://codereview.chromium.org/2724543003
Cr-Commit-Position: refs/heads/master@{#453730}

[modify] https://crrev.com/f5903684572a3df26e3eb91932a9de0174eb9b70/chrome/android/BUILD.gn
[modify] https://crrev.com/f5903684572a3df26e3eb91932a9de0174eb9b70/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
[modify] https://crrev.com/f5903684572a3df26e3eb91932a9de0174eb9b70/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/f5903684572a3df26e3eb91932a9de0174eb9b70/chrome/android/java_sources.gni
[add] https://crrev.com/f5903684572a3df26e3eb91932a9de0174eb9b70/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java
[modify] https://crrev.com/f5903684572a3df26e3eb91932a9de0174eb9b70/chrome/android/webapk/shell_apk/BUILD.gn

Comment 9 by pkotw...@chromium.org, Mar 14 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment