New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691843 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

MD Settings: Do not track info dialog missing.

Project Member Reported by dpa...@chromium.org, Feb 14 2017

Issue description

The old Options display a dialog when the "do not track" options is enabled, see screenshot. That info is not displayed by MD Settings.
 
do_not_track_dialog.png
36.8 KB View Download

Comment 1 by dpa...@chromium.org, Feb 14 2017

Cc: dschuyler@chromium.org dbeam@chromium.org
Having a dialog pop-up after clicking a toggle is really strange. Can we do one of these options instead:

(In order of preference)

- Put a concise line of secondary text on the toggle button row that conveys the message from the dialog (without popping up a dialog). This allows the user to see the information before enabling the feature.

- Or, change the toggle row to an expanding row (with a chevron icon at the end) and place the message along with the toggle in the expanded area (without popping up a dialog).

- Or, change the top-level row to a subpage button (with a subpage-arrow.svg) and then put the message along with the toggle in the subpage (without popping up a dialog).

Comment 3 by dpa...@chromium.org, Feb 15 2017

Cc: tbuck...@chromium.org
Labels: Hotlist-MD-Settings-Privacy
Status: Available (was: Untriaged)
I don't know that showing a dialog when clicking a toggle is that strange, I feel like I've seen it elsewhere often enough. 
Labels: M-58
Owner: steve...@chromium.org
This seems reasonable and important for 58.

Blocking: 671375
Labels: -Pri-2 Pri-1
You're right, this info probably warrants being a beta-blocker.
Status: Assigned (was: Available)
Labels: -M-58 M-59
Status: Started (was: Assigned)
Screenshot attached

Screenshot 2017-03-09 at 11.13.04 AM.png
280 KB View Download
Cc: bettes@chromium.org
Looking at the two screenshots I realized that the 'learn more' link is missing. Will ping bettes@ about whether he wants it in the dialog, in the control, or not at all.

Updated screenshot with 'Learn more' link at the end of the message text as per bettes@

Screenshot 2017-03-09 at 12.05.12 PM.png
268 KB View Download
Note: As per discussion with bettes@ the change will also remove any '.' before or after a 'Learn more' link in this section.

Alan, there is some confusion that removing '.' does not conform to the MD spec which shows a '.' before the Learn more (but not after):

https://www.google.com/url?q=https%3A%2F%2Fmaterial.io%2Fguidelines%2Fstyle%2Fwriting.html%23writing-capitalization-punctuation&sa=D&sntz=1&usg=AFQjCNHwEcnt-GbJM8JhBUq0Oaq8F63XMg

Could you confirm which we want in Settings? Thanks!

Comment 15 by dbeam@chromium.org, Mar 11 2017

hey bettes@ and srahim@ (ux writer), should there be a period between a sentence and a Learn More link?

everything in settings already has a . between, as does MD spec

https://material.io/guidelines/style/writing.html#writing-capitalization-punctuation
Screen Shot 2017-03-10 at 3.59.29 PM.png
51.4 KB View Download

Comment 16 by dbeam@chromium.org, Mar 11 2017

Cc: srahim@chromium.org
+srahim@ for realz now (see comment 15)
Steven, I think we misunderstood each other: should be a period between learn more and text but not after. 

"blah blah blah. Learn more"
Status: Fixed (was: Started)

Sign in to add a comment