MD Settings: Do not track info dialog missing. |
|||||||||||
Issue descriptionThe old Options display a dialog when the "do not track" options is enabled, see screenshot. That info is not displayed by MD Settings.
,
Feb 14 2017
Having a dialog pop-up after clicking a toggle is really strange. Can we do one of these options instead: (In order of preference) - Put a concise line of secondary text on the toggle button row that conveys the message from the dialog (without popping up a dialog). This allows the user to see the information before enabling the feature. - Or, change the toggle row to an expanding row (with a chevron icon at the end) and place the message along with the toggle in the expanded area (without popping up a dialog). - Or, change the top-level row to a subpage button (with a subpage-arrow.svg) and then put the message along with the toggle in the subpage (without popping up a dialog).
,
Feb 15 2017
,
Feb 16 2017
I don't know that showing a dialog when clicking a toggle is that strange, I feel like I've seen it elsewhere often enough.
,
Mar 4 2017
This seems reasonable and important for 58.
,
Mar 7 2017
You're right, this info probably warrants being a beta-blocker.
,
Mar 7 2017
,
Mar 7 2017
,
Mar 7 2017
,
Mar 9 2017
Screenshot attached
,
Mar 9 2017
Looking at the two screenshots I realized that the 'learn more' link is missing. Will ping bettes@ about whether he wants it in the dialog, in the control, or not at all.
,
Mar 9 2017
Updated screenshot with 'Learn more' link at the end of the message text as per bettes@
,
Mar 10 2017
Note: As per discussion with bettes@ the change will also remove any '.' before or after a 'Learn more' link in this section.
,
Mar 11 2017
Alan, there is some confusion that removing '.' does not conform to the MD spec which shows a '.' before the Learn more (but not after): https://www.google.com/url?q=https%3A%2F%2Fmaterial.io%2Fguidelines%2Fstyle%2Fwriting.html%23writing-capitalization-punctuation&sa=D&sntz=1&usg=AFQjCNHwEcnt-GbJM8JhBUq0Oaq8F63XMg Could you confirm which we want in Settings? Thanks!
,
Mar 11 2017
hey bettes@ and srahim@ (ux writer), should there be a period between a sentence and a Learn More link? everything in settings already has a . between, as does MD spec https://material.io/guidelines/style/writing.html#writing-capitalization-punctuation
,
Mar 11 2017
+srahim@ for realz now (see comment 15)
,
Mar 11 2017
Steven, I think we misunderstood each other: should be a period between learn more and text but not after. "blah blah blah. Learn more"
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aaaf9b612ae3aa0a8d148feecd950009d9433fe5 commit aaaf9b612ae3aa0a8d148feecd950009d9433fe5 Author: stevenjb <stevenjb@chromium.org> Date: Wed Mar 15 17:47:27 2017 MD Settings: Privacy: Show dialog when changing do-not-track BUG= 691843 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2731403005 Cr-Commit-Position: refs/heads/master@{#457128} [modify] https://crrev.com/aaaf9b612ae3aa0a8d148feecd950009d9433fe5/chrome/app/settings_strings.grdp [modify] https://crrev.com/aaaf9b612ae3aa0a8d148feecd950009d9433fe5/chrome/browser/resources/settings/privacy_page/compiled_resources2.gyp [modify] https://crrev.com/aaaf9b612ae3aa0a8d148feecd950009d9433fe5/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/aaaf9b612ae3aa0a8d148feecd950009d9433fe5/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/aaaf9b612ae3aa0a8d148feecd950009d9433fe5/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Mar 15 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by dpa...@chromium.org
, Feb 14 2017