New issue
Advanced search Search tips

Issue 691841 link

Starred by 1 user
Status: Fixed
Owner:
yosin@chromium.org
Closed: Feb 2017
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

move-up-down-should-skip-hidden-elements.html should be fast

Project Member Reported by yosin@chromium.org, Feb 14 2017 
It contains 2000 META elements and up and down 100 times. Since this test isn't speed test and we don't need to test with too many elements and many operations.

This slow test blocks landing [1] on Win7 bot.

[1] http://crrev.com/2680943004: Make FrameSelection to hold non-canonicalized positions

Comment 1 by yosin@chromium.org, Feb 14 2017 

Partial Result of move-up-with-hidden-elements.html
Details are found in https://docs.google.com/spreadsheets/d/1-2NhaqVWY5XMx3VhLxahktQ_kfTFcrHPUAZ8jzpJEKA/edit#gid=0


#elements	avg	median
100	7229.72	7240.3
500	2158.97	2168
750	1518.4	1518.28
1000	1157.5	1160.34
2000	605.46	605
3000	409.69	409.61
4000	309.35	309.83
5000	250.81	250.91
10000	127.15	127.3
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8a73d769c8090eb22f25cea950303a50ba98788

commit c8a73d769c8090eb22f25cea950303a50ba98788
Author: yosin <yosin@chromium.org>
Date: Tue Feb 14 06:18:15 2017

Convert layout test move-up-down-should-skip-hidden-elements.html to performance test

This patch converts layout test "move-up-down-should-skip-hidden-elements.html"
to performance tests, move line up and move line down, since this layout test
measures verifies execution speed regression. Using performance test is easier
to track performance regression than detecting timeout in layout test.

BUG= 691841 
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2689183003
Cr-Commit-Position: refs/heads/master@{#450278}

[delete] https://crrev.com/977fe146bd6777af01d8de34cbaab350b53d62f3/third_party/WebKit/LayoutTests/editing/execCommand/move-up-down-should-skip-hidden-elements-expected.txt
[delete] https://crrev.com/977fe146bd6777af01d8de34cbaab350b53d62f3/third_party/WebKit/LayoutTests/editing/execCommand/move-up-down-should-skip-hidden-elements.html
[add] https://crrev.com/c8a73d769c8090eb22f25cea950303a50ba98788/third_party/WebKit/PerformanceTests/Editing/move-down-with-hidden-elements.html
[add] https://crrev.com/c8a73d769c8090eb22f25cea950303a50ba98788/third_party/WebKit/PerformanceTests/Editing/move-up-with-hidden-elements.html

Comment 3 by yosin@chromium.org, Feb 14 2017

Status: Fixed (was: Started)
►

Sign in to add a comment