New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691828 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove {Audio,Video}CodecBridge

Project Member Reported by w...@chromium.org, Feb 14 2017

Issue description

These serve little purpose now, and make mocking harder.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c71ef8d720f0aea74a3ac4efe15df87670fa3875

commit c71ef8d720f0aea74a3ac4efe15df87670fa3875
Author: watk <watk@chromium.org>
Date: Thu Feb 23 01:40:42 2017

media: Clean up MediaCodecBridge and remove subclasses

Previously we had two subclasses of MediaCodecBridgeImpl,
VideoCodecBridge and AudioCodecBridge, which have become unnecessary.
For simplicity and ease of mocking, now we just have
MediaCodecBridgeImpl.

This CL also includes various cleanups, including:
* MediaCodecBridge factories return unique_ptrs.
* Remove some unused MCB functions.
* Use the java enum generator where possible to sync native and java
  enums.
* Collapsing DEQUEUE_OUTPUT_TRY_AGAIN and DEQUEUE_INPUT_TRY_AGAIN into
  a single TRY_AGAIN (like MediaCodec).
* Remove size params from isAdaptivePlaybackSupported() because they
  weren't used.
* Localizing codec to mime type conversions to MediaCodecUtil.
* Passing mime strings to MediaCodecUtil::CanDecode() instead of an
  ad-hoc codec name string.

BUG= 691828 
TEST=existing tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2697643003
Cr-Commit-Position: refs/heads/master@{#452334}

[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/components/cdm/browser/cdm_message_filter_android.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/BUILD.gn
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/BUILD.gn
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/java/src/org/chromium/media/CodecProfileLevelList.java
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/java/src/org/chromium/media/MediaCodecUtil.java
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/media_codec_bridge.h
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/media_codec_bridge_impl.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/media_codec_bridge_impl.h
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/media_codec_bridge_impl_unittest.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/media_codec_direction.h
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/media_codec_loop.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/media_codec_loop_unittest.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/media_codec_util.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/media_codec_util.h
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/mock_media_codec_bridge.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/android/mock_media_codec_bridge.h
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/encryption_scheme.h
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/base/video_codecs.h
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/filters/android/media_codec_audio_decoder.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/gpu/android/media_codec_video_decoder.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/gpu/android_video_decode_accelerator.h
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/gpu/android_video_encode_accelerator.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/gpu/android_video_encode_accelerator.h
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/gpu/avda_codec_allocator.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/gpu/avda_codec_allocator.h
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/gpu/avda_codec_allocator_unittest.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/gpu/avda_codec_image.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/gpu/avda_codec_image.h
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/gpu/avda_picture_buffer_manager.cc
[modify] https://crrev.com/c71ef8d720f0aea74a3ac4efe15df87670fa3875/media/gpu/avda_picture_buffer_manager.h

Comment 2 by w...@chromium.org, Feb 23 2017

Status: Fixed (was: Started)

Sign in to add a comment