New issue
Advanced search Search tips

Issue 691810 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Remove Grouped Builder Support

Project Member Reported by dgarr...@chromium.org, Feb 13 2017

Issue description

We are getting close to removing all grouped builder configs. If we get rid of all of them, we can remove grouped builder support from cbuildbot.

If you search for "AddGroup" in chromeos_config.py, you can find all grouped builder definitions.

Currently, we have:
 * A bunch of PreCQ builders (some obsoleted, some not)
 * <board>-release-afdo builder definitions (used?)
 * "test-ap-group" (used?)

 

Comment 1 by aut...@google.com, Feb 14 2017

Labels: -current-issue
Owner: dgarr...@chromium.org
Do we have any of those beasts left?
Yep.

The important ones are <board>-release-afdo and test-ap-group.

Both can be reworked to get rid of groups, but it'll need a bit of time.
Also, the toolchain team uses the afdo builders.

And the test-ap-group is used (very rarely) to create a production image run inside the wifi testing infrastructure, somewhere.
Everything is gone, except the AFDO builders, and the test-ap-group builder.
Status: Available (was: Untriaged)
Labels: Type-Feature
Labels: -Pri-2 Pri-3
Cc: grundler@chromium.org
Looking at the config, I believe that these two commands are identical, except that the results are archived in 1 directory vs 3.

# Group Config
cros tryjob test-ap-group

# As individual builders
cros tryjob stumpy-test-ap panther-test-ap whirlwind-test-ap

$ cros tryjob stumpy-test-ap panther-test-ap whirlwind-test-ap
17:09:55: ERROR: These configs are not tryjob safe:
  stumpy-test-ap, panther-test-ap, whirlwind-test-ap
Consider these configs instead:
  stumpy-test-ap-tryjob, panther-test-ap-tryjob, whirlwind-test-ap-tryjob
See go/cros-explicit-tryjob-build-configs-psa.

I guess have some reading to do...but I'll need to add more args:
1) to make sure all build artifacts are preserved.
2) specify an R65 release branch
3) add the change I want included to upgrade netperf.
Oops... I believe I could have marked these configs as tryjob safe.

This will work:
  cros tryjob --production stumpy-test-ap panther-test-ap whirlwind-test-ap

Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS
Owner: ----
Status: Untriaged (was: Available)

Sign in to add a comment