New issue
Advanced search Search tips

Issue 691800 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Remove legacy keys from SerializableUserDataManagerImpl.

Project Member Reported by kkhorimoto@chromium.org, Feb 13 2017

Issue description

TabID was previously serialized directly directly by CRWSessionStorage, but is not persisted via SerializableUserData.  Currently there is code to manager this conversion, but it should be removed eventually.  Since SerializableUserDataManager is to be released in M58, it should be removed in M59.
 
Cc: pkl@chromium.org
+pkl for input.  Is one milestone enough of a buffer to update serialization keys?  We also have other serialization code to handle legacy serialization keys; when do you think it would be appropriate to remove them?

Comment 2 by cma...@chromium.org, Mar 10 2017

Components: Mobile>WebView>Glue
Components: -Mobile>WebView>Glue UI>Browser>Navigation

Comment 4 by pkl@chromium.org, Mar 10 2017

Let's talk in person about the details.
Labels: -Type-Bug Type-Feature
Labels: -Type-Feature Type-Task
Cc: kkhorimoto@chromium.org mrefaat@chromium.org
Owner: ----
Status: Available (was: Assigned)
Owner: sdefresne@chromium.org
Status: Started (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6de946db9c3290cf74a61595962116b6d5384e45

commit 6de946db9c3290cf74a61595962116b6d5384e45
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Aug 02 13:52:03 2018

Remove support for legacy WebState user data format

The format was changed in M-57, so legacy code can now be dropped
as M-69 has been branched.

Bug: 661633,  691800 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8cd160acfb994091658939662534d578881c981c
Reviewed-on: https://chromium-review.googlesource.com/1158698
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580155}
[modify] https://crrev.com/6de946db9c3290cf74a61595962116b6d5384e45/ios/web/BUILD.gn
[modify] https://crrev.com/6de946db9c3290cf74a61595962116b6d5384e45/ios/web/navigation/serializable_user_data_manager_impl.h
[modify] https://crrev.com/6de946db9c3290cf74a61595962116b6d5384e45/ios/web/navigation/serializable_user_data_manager_impl.mm
[delete] https://crrev.com/4fc490dcb251520ce0c3661a4e3fad4eb2d3429b/ios/web/navigation/serializable_user_data_manager_impl_unittest.mm

Status: Fixed (was: Started)

Sign in to add a comment