NQE should record the main frame metrics at the beginning of transaction start |
||||||
Issue descriptionCurrently, NQE records the main frame metrics when the response headers for the main frame request are received. Instead, it should record the main frame metrics at the beginning of transaction start. The former is less accurate than latter, since the former is when the NQE public APIs would be called.
,
Feb 15 2017
,
Feb 15 2017
,
Feb 16 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 16 2017
Please merge your change to M57 branch 2987 before 5:00 PM PT Friday (02/17), so we can pick it up for next week Beta release. Thank you.
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c82d9e4024d4ada2d0a0677c2ced1f1147dddb7c commit c82d9e4024d4ada2d0a0677c2ced1f1147dddb7c Author: tbansal <tbansal@chromium.org> Date: Thu Feb 16 21:43:59 2017 Revert of NQE: Record the main frame metrics at transaction start (patchset #2 id:60001 of https://codereview.chromium.org/2695783003/ ) Reason for revert: Caused perf regression. See https://bugs.chromium.org/p/chromium/issues/detail?id=692933 Original issue's description: > NQE: Record the main frame metrics at transaction start > > In network quality estimator (NQE), record the main frame metrics at the > beginning of transaction start, instead of when the response headers have > been received for the main frame. > > BUG= 691798 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester > > Review-Url: https://codereview.chromium.org/2695783003 > Cr-Commit-Position: refs/heads/master@{#450536} > Committed: https://chromium.googlesource.com/chromium/src/+/0be260cab40bb7162d01d99afb1144abdd2469c2 TBR=ryansturm@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 691798 , 692933 Review-Url: https://codereview.chromium.org/2690303011 Cr-Commit-Position: refs/heads/master@{#451106} [modify] https://crrev.com/c82d9e4024d4ada2d0a0677c2ced1f1147dddb7c/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/c82d9e4024d4ada2d0a0677c2ced1f1147dddb7c/net/nqe/network_quality_estimator.h [modify] https://crrev.com/c82d9e4024d4ada2d0a0677c2ced1f1147dddb7c/net/nqe/network_quality_estimator_unittest.cc
,
Feb 16 2017
If CL is reverted from trunk, will M57 merge needed? If not, please remove "Merge-Approved-57" label. Thank you.
,
Feb 17 2017
I am going to modify the CL slightly, and land it again. Then, after making sure there are no regressions, I will merge it.
,
Feb 17 2017
Please merge your change to M57 branch 2987 before 5:00 PM PT Monday (02/20), so we can pick it up for next week Beta release. Thank you.
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3d164f6e807c5f9669ceb4ba213475d6072d626 commit c3d164f6e807c5f9669ceb4ba213475d6072d626 Author: tbansal <tbansal@chromium.org> Date: Fri Feb 17 23:41:28 2017 NQE: Record the main frame metrics at transaction start In network quality estimator (NQE), record the main frame metrics at the beginning of transaction start, instead of when the response headers have been received for the main frame. BUG= 691798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2698913006 Cr-Commit-Position: refs/heads/master@{#451400} [modify] https://crrev.com/c3d164f6e807c5f9669ceb4ba213475d6072d626/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/c3d164f6e807c5f9669ceb4ba213475d6072d626/net/nqe/network_quality_estimator.h [modify] https://crrev.com/c3d164f6e807c5f9669ceb4ba213475d6072d626/net/nqe/network_quality_estimator_unittest.cc
,
Feb 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69415b51072fb20605fc129f136950f7c2560ceb commit 69415b51072fb20605fc129f136950f7c2560ceb Author: tbansal <tbansal@chromium.org> Date: Sat Feb 18 09:03:56 2017 NQE: Move recording of metrics to when the response headers are received Currently, NQE (Network Quality Estimator) records the network quality metrics when the transaction starts. This CL moves the recording of the metrics to when the response headers are received. BUG= 691798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester TBR=ryansturm@chromium.org Review-Url: https://codereview.chromium.org/2702013002 Cr-Commit-Position: refs/heads/master@{#451446} [modify] https://crrev.com/69415b51072fb20605fc129f136950f7c2560ceb/net/nqe/network_quality_estimator.cc
,
Feb 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/747aab0de56d72b41287c65befbee89dfa433739 commit 747aab0de56d72b41287c65befbee89dfa433739 Author: tbansal <tbansal@chromium.org> Date: Mon Feb 20 00:49:29 2017 NQE: Move ECT computation to NotifyHeadersReceived Currently, NQE (Network Quality Estimator) computes the effective connection type when the transaction starts. This CL moves the computation of effective connection type to when the response headers are received. BUG= 691798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester TBR=ryansturm@chromium.org Review-Url: https://codereview.chromium.org/2703103002 Cr-Commit-Position: refs/heads/master@{#451535} [modify] https://crrev.com/747aab0de56d72b41287c65befbee89dfa433739/net/nqe/network_quality_estimator.cc
,
Feb 20 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 21 2017
Please merge your change to M57 branch 2987 by 5:00 PM PT Tuesday (02/21) so we can pick it up for this week beta release. Thank you.
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/443abf275b957869722ec105d9a4d35cd71590c8 commit 443abf275b957869722ec105d9a4d35cd71590c8 Author: Tarun Bansal <tbansal@google.com> Date: Tue Feb 21 17:25:24 2017 NQE: Move ECT computation to NotifyHeadersReceived Currently, NQE (Network Quality Estimator) computes the effective connection type when the transaction starts. This CL moves the computation of effective connection type to when the response headers are received. BUG= 691798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2703103002 Cr-Commit-Position: refs/heads/master@{#451535} (cherry picked from commit 747aab0de56d72b41287c65befbee89dfa433739) NQE: Move recording of metrics to when the response headers are received Currently, NQE (Network Quality Estimator) records the network quality metrics when the transaction starts. This CL moves the recording of the metrics to when the response headers are received. BUG= 691798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2702013002 Cr-Commit-Position: refs/heads/master@{#451446} (cherry picked from commit 69415b51072fb20605fc129f136950f7c2560ceb) NQE: Record the main frame metrics at transaction start In network quality estimator (NQE), record the main frame metrics at the beginning of transaction start, instead of when the response headers have been received for the main frame. BUG= 691798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2695783003 Cr-Commit-Position: refs/heads/master@{#450536} (cherry picked from commit 0be260cab40bb7162d01d99afb1144abdd2469c2) Review-Url: https://codereview.chromium.org/2712443002 . Cr-Commit-Position: refs/branch-heads/2987@{#608} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/443abf275b957869722ec105d9a4d35cd71590c8/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/443abf275b957869722ec105d9a4d35cd71590c8/net/nqe/network_quality_estimator.h [modify] https://crrev.com/443abf275b957869722ec105d9a4d35cd71590c8/net/nqe/network_quality_estimator_unittest.cc
,
Feb 21 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tbansal@chromium.org
, Feb 15 2017