Metabug to track the different frame-related cleanups.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/616d2f430dc084729f71b275408df8ae9555f629 commit 616d2f430dc084729f71b275408df8ae9555f629 Author: sashab <sashab@chromium.org> Date: Fri Feb 24 06:28:27 2017 Removed FrameHost::settings() Removed the FrameHost::settings() method, and redirected calls to Page::settings() using FrameHost's Page reference, or directly on the Page object if it is available. This is part of the work to merge FrameHost back into Page. BUG=691794 Review-Url: https://codereview.chromium.org/2709263003 Cr-Commit-Position: refs/heads/master@{#452774} [modify] https://crrev.com/616d2f430dc084729f71b275408df8ae9555f629/third_party/WebKit/Source/core/css/MediaValues.cpp [modify] https://crrev.com/616d2f430dc084729f71b275408df8ae9555f629/third_party/WebKit/Source/core/frame/Frame.cpp [modify] https://crrev.com/616d2f430dc084729f71b275408df8ae9555f629/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/616d2f430dc084729f71b275408df8ae9555f629/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/616d2f430dc084729f71b275408df8ae9555f629/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/616d2f430dc084729f71b275408df8ae9555f629/third_party/WebKit/Source/core/frame/Screen.cpp [modify] https://crrev.com/616d2f430dc084729f71b275408df8ae9555f629/third_party/WebKit/Source/core/frame/VisualViewport.cpp [modify] https://crrev.com/616d2f430dc084729f71b275408df8ae9555f629/third_party/WebKit/Source/modules/storage/DOMWindowStorage.cpp [modify] https://crrev.com/616d2f430dc084729f71b275408df8ae9555f629/third_party/WebKit/Source/web/InspectorOverlay.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0 commit d1291c79d5f9b2e34bb9c15c32d869f44111f8e0 Author: sashab <sashab@chromium.org> Date: Tue Feb 28 03:40:41 2017 Removed FrameHost::chromeClient() Removed the FrameHost::chromeClient() method, and redirected calls to Page::chromeClient() using FrameHost's Page reference (or directly on the Page object if it is available). Also removed some now-redundant FrameHost includes, and added a TODO to remove Page::frameHost(). This is part of the work to merge FrameHost back into Page. BUG=691794 Review-Url: https://codereview.chromium.org/2716153003 Cr-Commit-Position: refs/heads/master@{#453485} [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/css/MediaValues.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/frame/BarProp.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/frame/BrowserControls.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/frame/Navigator.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/frame/Screen.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/frame/VisualViewport.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/html/HTMLInputElement.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/html/forms/InputType.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/page/CreateWindow.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/page/Page.h [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/core/svg/SVGAElement.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/web/InspectorOverlay.cpp [modify] https://crrev.com/d1291c79d5f9b2e34bb9c15c32d869f44111f8e0/third_party/WebKit/Source/web/WebInputEventConversion.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49faab2e95fdb5f6cb63788ac6212676558402bf commit 49faab2e95fdb5f6cb63788ac6212676558402bf Author: sashab <sashab@chromium.org> Date: Tue Feb 28 06:16:43 2017 Removed FrameHost::deprecation() Removed the FrameHost::deprecation() method, and redirected calls to Page::deprecation() using FrameHost's Page reference (or directly on the Page object if it is available). Also preemptively removed some nearby FrameHost::useCounter() calls, and removed now-redundant FrameHost.h includes. This is part of the work to merge FrameHost back into Page. BUG=691794 Review-Url: https://codereview.chromium.org/2720213002 Cr-Commit-Position: refs/heads/master@{#453519} [modify] https://crrev.com/49faab2e95fdb5f6cb63788ac6212676558402bf/third_party/WebKit/Source/core/frame/Deprecation.cpp [modify] https://crrev.com/49faab2e95fdb5f6cb63788ac6212676558402bf/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/49faab2e95fdb5f6cb63788ac6212676558402bf/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/49faab2e95fdb5f6cb63788ac6212676558402bf/third_party/WebKit/Source/core/frame/UseCounterTest.cpp [modify] https://crrev.com/49faab2e95fdb5f6cb63788ac6212676558402bf/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9a9d43c56e9b272cec3c46eb9864d515dacdbaf commit a9a9d43c56e9b272cec3c46eb9864d515dacdbaf Author: sashab <sashab@chromium.org> Date: Tue Feb 28 06:27:43 2017 Removed FrameHost::useCounter() Removed the FrameHost::useCounter() method, and redirected calls to Page::useCounter() using FrameHost's Page reference (or directly on the Page object if it is available). This is part of the work to merge FrameHost back into Page. BUG=691794 Review-Url: https://codereview.chromium.org/2720933003 Cr-Commit-Position: refs/heads/master@{#453524} [modify] https://crrev.com/a9a9d43c56e9b272cec3c46eb9864d515dacdbaf/third_party/WebKit/Source/core/css/parser/CSSLazyParsingTest.cpp [modify] https://crrev.com/a9a9d43c56e9b272cec3c46eb9864d515dacdbaf/third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp [modify] https://crrev.com/a9a9d43c56e9b272cec3c46eb9864d515dacdbaf/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/a9a9d43c56e9b272cec3c46eb9864d515dacdbaf/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/a9a9d43c56e9b272cec3c46eb9864d515dacdbaf/third_party/WebKit/Source/core/frame/UseCounter.cpp [modify] https://crrev.com/a9a9d43c56e9b272cec3c46eb9864d515dacdbaf/third_party/WebKit/Source/core/testing/Internals.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c23baccef3a9647076ad0dde83a1a847c702b03 commit 0c23baccef3a9647076ad0dde83a1a847c702b03 Author: sashab <sashab@chromium.org> Date: Wed Mar 01 06:54:46 2017 Renamed deviceScaleFactor() to deviceScaleFactorDeprecated() in Page Renamed the deviceScaleFactor() method to deviceScaleFactorDeprecated() in the Page class, to be consistent with the FrameHost method that calls this one. Also moved the comment for the method to the Page class. This is pre-work to remove FrameHost::deviceScaleFactorDeprecated(), and is part of merging FrameHost back into Page. BUG=691794 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2724543002 Cr-Commit-Position: refs/heads/master@{#453871} [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/core/html/HTMLImageElement.cpp [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/core/page/Page.h [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/core/paint/FramePainter.cpp [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/web/DevToolsEmulator.cpp [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/web/PageWidgetDelegate.cpp [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/0c23baccef3a9647076ad0dde83a1a847c702b03/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bcb0bd7cd927a70d47c983fbd071ccf6cdded58 commit 9bcb0bd7cd927a70d47c983fbd071ccf6cdded58 Author: sashab <sashab@chromium.org> Date: Thu Mar 02 03:38:04 2017 Removed FrameHost::deviceScaleFactorDeprecated() Removed the FrameHost::deviceScaleFactorDeprecated() method, and redirected calls to Page::deviceScaleFactorDeprecated() using FrameHost's Page reference (or directly on the Page object if it is available). Also removed now-redundant FrameHost.h includes. This is part of the work to merge FrameHost back into Page. BUG=691794 Review-Url: https://codereview.chromium.org/2719293002 Cr-Commit-Position: refs/heads/master@{#454165} [modify] https://crrev.com/9bcb0bd7cd927a70d47c983fbd071ccf6cdded58/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/9bcb0bd7cd927a70d47c983fbd071ccf6cdded58/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/9bcb0bd7cd927a70d47c983fbd071ccf6cdded58/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/9bcb0bd7cd927a70d47c983fbd071ccf6cdded58/third_party/WebKit/Source/core/page/DragController.cpp [modify] https://crrev.com/9bcb0bd7cd927a70d47c983fbd071ccf6cdded58/third_party/WebKit/Source/web/InspectorOverlay.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60bfbf8a7d59d1f63b5a73f1ac10dee41c6a7ded commit 60bfbf8a7d59d1f63b5a73f1ac10dee41c6a7ded Author: sashab <sashab@chromium.org> Date: Thu Mar 02 05:52:37 2017 Move FrameHost::m_pageScaleConstraintsSet to Page This is part of merging FrameHost back into Page. BUG=691794 Review-Url: https://codereview.chromium.org/2723493004 Cr-Commit-Position: refs/heads/master@{#454188} [modify] https://crrev.com/60bfbf8a7d59d1f63b5a73f1ac10dee41c6a7ded/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/60bfbf8a7d59d1f63b5a73f1ac10dee41c6a7ded/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/60bfbf8a7d59d1f63b5a73f1ac10dee41c6a7ded/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/60bfbf8a7d59d1f63b5a73f1ac10dee41c6a7ded/third_party/WebKit/Source/core/page/Page.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70dfd29bb016498ed8e1ff3f5c76948f5f57a6ee commit 70dfd29bb016498ed8e1ff3f5c76948f5f57a6ee Author: sashab <sashab@chromium.org> Date: Thu Mar 02 07:52:50 2017 Moved FrameHost::setDefaultPageScaleLimits/UserAgentPageScaleConstraints Moved FrameHost::setDefaultPageScaleLimits and FrameHost::UserAgentPageScaleConstraints to have the implementation in Page, which FrameHost calls. This is pre-work to remove these methods from FrameHost. BUG=691794 Review-Url: https://codereview.chromium.org/2722773002 Cr-Commit-Position: refs/heads/master@{#454208} [modify] https://crrev.com/70dfd29bb016498ed8e1ff3f5c76948f5f57a6ee/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/70dfd29bb016498ed8e1ff3f5c76948f5f57a6ee/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/70dfd29bb016498ed8e1ff3f5c76948f5f57a6ee/third_party/WebKit/Source/core/page/Page.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1bcb71f31974fd109abfe54e3c7bd2827ad504a commit d1bcb71f31974fd109abfe54e3c7bd2827ad504a Author: sashab <sashab@chromium.org> Date: Mon Mar 06 07:42:18 2017 Remove FrameHost setDefaultPageScaleLimits/UserAgentPageScaleConstraints BUG=691794 Review-Url: https://codereview.chromium.org/2720723004 Cr-Commit-Position: refs/heads/master@{#454838} [modify] https://crrev.com/d1bcb71f31974fd109abfe54e3c7bd2827ad504a/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/d1bcb71f31974fd109abfe54e3c7bd2827ad504a/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/d1bcb71f31974fd109abfe54e3c7bd2827ad504a/third_party/WebKit/Source/core/testing/Internals.cpp [modify] https://crrev.com/d1bcb71f31974fd109abfe54e3c7bd2827ad504a/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp [modify] https://crrev.com/d1bcb71f31974fd109abfe54e3c7bd2827ad504a/third_party/WebKit/Source/web/WebViewImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f2871f61b5280b0f20d80aedd47bd8dbd04695d commit 5f2871f61b5280b0f20d80aedd47bd8dbd04695d Author: sashab <sashab@chromium.org> Date: Wed Mar 08 03:01:46 2017 Removed FrameHost::pageScaleConstraintsSet() This is part of the work to merge FrameHost back into Page. BUG=691794 Review-Url: https://codereview.chromium.org/2718313002 Cr-Commit-Position: refs/heads/master@{#455360} [modify] https://crrev.com/5f2871f61b5280b0f20d80aedd47bd8dbd04695d/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/5f2871f61b5280b0f20d80aedd47bd8dbd04695d/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/5f2871f61b5280b0f20d80aedd47bd8dbd04695d/third_party/WebKit/Source/core/frame/VisualViewport.cpp [modify] https://crrev.com/5f2871f61b5280b0f20d80aedd47bd8dbd04695d/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp [modify] https://crrev.com/5f2871f61b5280b0f20d80aedd47bd8dbd04695d/third_party/WebKit/Source/web/WebViewImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2dc92c168f5010a9eefd1156e09567b23896907 commit d2dc92c168f5010a9eefd1156e09567b23896907 Author: sashab <sashab@chromium.org> Date: Wed Mar 08 03:09:08 2017 Make BrowserControls take and store a Page instead of a FrameHost This is part of the work to remove FrameHost. BUG=691794 Review-Url: https://codereview.chromium.org/2734073002 Cr-Commit-Position: refs/heads/master@{#455362} [modify] https://crrev.com/d2dc92c168f5010a9eefd1156e09567b23896907/third_party/WebKit/Source/core/frame/BrowserControls.cpp [modify] https://crrev.com/d2dc92c168f5010a9eefd1156e09567b23896907/third_party/WebKit/Source/core/frame/BrowserControls.h [modify] https://crrev.com/d2dc92c168f5010a9eefd1156e09567b23896907/third_party/WebKit/Source/core/frame/FrameHost.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c4056a61c3d24b5df4ebdba406467b96ff68866 commit 5c4056a61c3d24b5df4ebdba406467b96ff68866 Author: sashab <sashab@chromium.org> Date: Wed Mar 08 04:33:17 2017 Make EventHandlerRegistry store Page instead of FrameHost This is pre-work to move FrameHost::m_eventHandlerRegistry to Page. Also renamed didMove{Into,OutOf}FrameHost to didMove{Into,OutOf}Page, which now makes more sense. BUG=691794 Review-Url: https://codereview.chromium.org/2736753003 Cr-Commit-Position: refs/heads/master@{#455379} [modify] https://crrev.com/5c4056a61c3d24b5df4ebdba406467b96ff68866/third_party/WebKit/Source/core/dom/Node.cpp [modify] https://crrev.com/5c4056a61c3d24b5df4ebdba406467b96ff68866/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp [modify] https://crrev.com/5c4056a61c3d24b5df4ebdba406467b96ff68866/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h [modify] https://crrev.com/5c4056a61c3d24b5df4ebdba406467b96ff68866/third_party/WebKit/Source/core/frame/FrameHost.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d265114438e787fbcefdbe0e081491349a5816b4 commit d265114438e787fbcefdbe0e081491349a5816b4 Author: sashab <sashab@chromium.org> Date: Wed Mar 08 05:28:34 2017 Move FrameHost::m_browserControls to Page Move FrameHost::m_browserControls to Page, and reroute the FrameHost::browserControls() getter methods to point to Page's m_browserControls object instead. BUG=691794 Review-Url: https://codereview.chromium.org/2734873003 Cr-Commit-Position: refs/heads/master@{#455385} [modify] https://crrev.com/d265114438e787fbcefdbe0e081491349a5816b4/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/d265114438e787fbcefdbe0e081491349a5816b4/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/d265114438e787fbcefdbe0e081491349a5816b4/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/d265114438e787fbcefdbe0e081491349a5816b4/third_party/WebKit/Source/core/page/Page.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5a5f183a349f0088685acc2a063f9b84e9ec237 commit c5a5f183a349f0088685acc2a063f9b84e9ec237 Author: petermayo <petermayo@chromium.org> Date: Wed Mar 08 16:05:50 2017 Revert of Make EventHandlerRegistry store Page instead of FrameHost (patchset #1 id:1 of https://codereview.chromium.org/2736753003/ ) Reason for revert: virtual/gpu-rasterization/images/cross-fade-background-size.html failed after this change. No idea why, perhaps it is too sensitive, or needs a concurrent rebaseline. Tracked in bug 699573 Original issue's description: > Make EventHandlerRegistry store Page instead of FrameHost > > This is pre-work to move FrameHost::m_eventHandlerRegistry to Page. Also > renamed didMove{Into,OutOf}FrameHost to didMove{Into,OutOf}Page, which > now makes more sense. > > BUG=691794 > > Review-Url: https://codereview.chromium.org/2736753003 > Cr-Commit-Position: refs/heads/master@{#455379} > Committed: https://chromium.googlesource.com/chromium/src/+/5c4056a61c3d24b5df4ebdba406467b96ff68866 TBR=joelhockey@chromium.org,sashab@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691794 Review-Url: https://codereview.chromium.org/2737863005 Cr-Commit-Position: refs/heads/master@{#455462} [modify] https://crrev.com/c5a5f183a349f0088685acc2a063f9b84e9ec237/third_party/WebKit/Source/core/dom/Node.cpp [modify] https://crrev.com/c5a5f183a349f0088685acc2a063f9b84e9ec237/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp [modify] https://crrev.com/c5a5f183a349f0088685acc2a063f9b84e9ec237/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h [modify] https://crrev.com/c5a5f183a349f0088685acc2a063f9b84e9ec237/third_party/WebKit/Source/core/frame/FrameHost.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fe37909237df848564e70b749eac2a3a8e32b95 commit 6fe37909237df848564e70b749eac2a3a8e32b95 Author: sashab <sashab@chromium.org> Date: Wed Mar 08 23:00:18 2017 Reland of Make EventHandlerRegistry store Page instead of FrameHost (patchset #1 id:1 of https://codereview.chromium.org/2737863005/ ) Reason for revert: Patch unrelated to test failure; trying to revert-revert Original issue's description: > Revert of Make EventHandlerRegistry store Page instead of FrameHost (patchset #1 id:1 of https://codereview.chromium.org/2736753003/ ) > > Reason for revert: > virtual/gpu-rasterization/images/cross-fade-background-size.html failed after this change. > > No idea why, perhaps it is too sensitive, or needs a concurrent rebaseline. > > Tracked in bug 699573 > > Original issue's description: > > Make EventHandlerRegistry store Page instead of FrameHost > > > > This is pre-work to move FrameHost::m_eventHandlerRegistry to Page. Also > > renamed didMove{Into,OutOf}FrameHost to didMove{Into,OutOf}Page, which > > now makes more sense. > > > > BUG=691794 > > > > Review-Url: https://codereview.chromium.org/2736753003 > > Cr-Commit-Position: refs/heads/master@{#455379} > > Committed: https://chromium.googlesource.com/chromium/src/+/5c4056a61c3d24b5df4ebdba406467b96ff68866 > > TBR=joelhockey@chromium.org,sashab@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=691794 > > Review-Url: https://codereview.chromium.org/2737863005 > Cr-Commit-Position: refs/heads/master@{#455462} > Committed: https://chromium.googlesource.com/chromium/src/+/c5a5f183a349f0088685acc2a063f9b84e9ec237 TBR=joelhockey@chromium.org,petermayo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691794 Review-Url: https://codereview.chromium.org/2742543002 Cr-Commit-Position: refs/heads/master@{#455575} [modify] https://crrev.com/6fe37909237df848564e70b749eac2a3a8e32b95/third_party/WebKit/Source/core/dom/Node.cpp [modify] https://crrev.com/6fe37909237df848564e70b749eac2a3a8e32b95/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp [modify] https://crrev.com/6fe37909237df848564e70b749eac2a3a8e32b95/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h [modify] https://crrev.com/6fe37909237df848564e70b749eac2a3a8e32b95/third_party/WebKit/Source/core/frame/FrameHost.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23681f7f9786a74472661de74377afcf19754ab1 commit 23681f7f9786a74472661de74377afcf19754ab1 Author: sashab <sashab@chromium.org> Date: Thu Mar 09 02:00:53 2017 Remove VisualViewport::frameHost() Remove the VisualViewport::frameHost() method, and replace it with Remove Remove VisualViewport::page() and update callsites. This is pre-work to remove FrameHost from VisualViewport, which is part of the work to remove FrameHost. BUG=691794 Review-Url: https://codereview.chromium.org/2728873002 Cr-Commit-Position: refs/heads/master@{#455637} [modify] https://crrev.com/23681f7f9786a74472661de74377afcf19754ab1/third_party/WebKit/Source/core/frame/VisualViewport.cpp [modify] https://crrev.com/23681f7f9786a74472661de74377afcf19754ab1/third_party/WebKit/Source/core/frame/VisualViewport.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4344f497cf240b361ccc9499ed965aede2f9c49d commit 4344f497cf240b361ccc9499ed965aede2f9c49d Author: sashab <sashab@chromium.org> Date: Thu Mar 09 02:53:33 2017 Remove FrameHost::browserControls() Remove FrameHost::browserControls(), and redirect all calls to Page::browserControls(). BUG=691794 Review-Url: https://codereview.chromium.org/2737703002 Cr-Commit-Position: refs/heads/master@{#455650} [modify] https://crrev.com/4344f497cf240b361ccc9499ed965aede2f9c49d/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/4344f497cf240b361ccc9499ed965aede2f9c49d/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp [modify] https://crrev.com/4344f497cf240b361ccc9499ed965aede2f9c49d/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/4344f497cf240b361ccc9499ed965aede2f9c49d/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c88cfa0fce93d1ce6ecc57108a776d356c67c765 commit c88cfa0fce93d1ce6ecc57108a776d356c67c765 Author: sashab <sashab@chromium.org> Date: Thu Mar 09 04:32:44 2017 Move FrameHost::m_eventHandlerRegistry to Page Move the field FrameHost::m_eventHandlerRegistry to Page, and update FrameHost methods to directly call the equivalent Page method. BUG=691794 Review-Url: https://codereview.chromium.org/2728423005 Cr-Commit-Position: refs/heads/master@{#455666} [modify] https://crrev.com/c88cfa0fce93d1ce6ecc57108a776d356c67c765/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/c88cfa0fce93d1ce6ecc57108a776d356c67c765/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/c88cfa0fce93d1ce6ecc57108a776d356c67c765/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/c88cfa0fce93d1ce6ecc57108a776d356c67c765/third_party/WebKit/Source/core/page/Page.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32fbfd186648b908ee1f708b6a95f1308f52e308 commit 32fbfd186648b908ee1f708b6a95f1308f52e308 Author: sashab <sashab@chromium.org> Date: Fri Mar 10 03:52:06 2017 Make TopDocumentRootScrollerController store Page instead of FrameHost This is pre-work to move FrameHost::m_topDocumentRootScrollerController to Page. BUG=691794 Review-Url: https://codereview.chromium.org/2732363003 Cr-Commit-Position: refs/heads/master@{#455980} [modify] https://crrev.com/32fbfd186648b908ee1f708b6a95f1308f52e308/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/32fbfd186648b908ee1f708b6a95f1308f52e308/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp [modify] https://crrev.com/32fbfd186648b908ee1f708b6a95f1308f52e308/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57 commit 2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57 Author: sashab <sashab@chromium.org> Date: Fri Mar 10 04:02:56 2017 Remove FrameHost::eventHandlerRegistry() Remove FrameHost::eventHandlerRegistry(), and redirect all calls to Page::eventHandlerRegistry(). BUG=691794 Review-Url: https://codereview.chromium.org/2741633002 Cr-Commit-Position: refs/heads/master@{#455985} [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/core/dom/Node.cpp [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/core/input/TouchEventManager.cpp [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/core/testing/Internals.cpp [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp [modify] https://crrev.com/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57/third_party/WebKit/Source/web/tests/WebViewTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0438224434b32dff5d3e15fb1b4b7a03d7e343a commit c0438224434b32dff5d3e15fb1b4b7a03d7e343a Author: sashab <sashab@chromium.org> Date: Fri Mar 10 04:11:24 2017 Change VisualViewport to store a Page instead of a FrameHost This is part of the work to remove FrameHost. BUG=691794 Review-Url: https://codereview.chromium.org/2727563004 Cr-Commit-Position: refs/heads/master@{#455987} [modify] https://crrev.com/c0438224434b32dff5d3e15fb1b4b7a03d7e343a/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/c0438224434b32dff5d3e15fb1b4b7a03d7e343a/third_party/WebKit/Source/core/frame/VisualViewport.cpp [modify] https://crrev.com/c0438224434b32dff5d3e15fb1b4b7a03d7e343a/third_party/WebKit/Source/core/frame/VisualViewport.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb7ffe6561358b82498f885544ffdf50a5e46646 commit eb7ffe6561358b82498f885544ffdf50a5e46646 Author: sashab <sashab@chromium.org> Date: Mon Mar 13 05:21:31 2017 Move FrameHost::m_subframeCount to Page Move the field FrameHost::m_subframeCount to Page, and update FrameHost methods to directly call the equivalent Page method. BUG=691794 Review-Url: https://codereview.chromium.org/2739033003 Cr-Commit-Position: refs/heads/master@{#456321} [modify] https://crrev.com/eb7ffe6561358b82498f885544ffdf50a5e46646/third_party/WebKit/Source/core/dom/NodeRareData.cpp [modify] https://crrev.com/eb7ffe6561358b82498f885544ffdf50a5e46646/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/eb7ffe6561358b82498f885544ffdf50a5e46646/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/eb7ffe6561358b82498f885544ffdf50a5e46646/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp [modify] https://crrev.com/eb7ffe6561358b82498f885544ffdf50a5e46646/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/eb7ffe6561358b82498f885544ffdf50a5e46646/third_party/WebKit/Source/core/page/Page.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c516312b21a48df2839de5a1e5e5e338a1ed4de commit 4c516312b21a48df2839de5a1e5e5e338a1ed4de Author: sashab <sashab@chromium.org> Date: Mon Mar 13 05:33:23 2017 Moved FrameHost::m_visualViewport to Page Moved FrameHost::m_visualViewport and it's methods to Page, and updated callers to use Page instead. This is part of merging FrameHost back into Page. BUG=691794 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2730573003 Cr-Commit-Position: refs/heads/master@{#456326} [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/dom/ViewportDescription.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/frame/BrowserControls.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/frame/LocalFrameTest.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/html/ImageDocument.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/input/EventHandler.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/input/GestureManager.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/layout/LayoutMedia.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/layout/TextAutosizer.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/loader/EmptyClients.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/loader/FrameLoader.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/page/Page.h [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/core/testing/Internals.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/DevToolsEmulator.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/InspectorOverlay.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/PageOverlay.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/WebInputEventConversion.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/WebPagePopupImpl.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/tests/TextFinderTest.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/tests/WebFrameTest.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp [modify] https://crrev.com/4c516312b21a48df2839de5a1e5e5e338a1ed4de/third_party/WebKit/Source/web/tests/WebViewTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/214dd7fe513f8d06e76644c08db75fd8d3355d65 commit 214dd7fe513f8d06e76644c08db75fd8d3355d65 Author: yoichio <yoichio@chromium.org> Date: Mon Mar 13 08:03:59 2017 Revert of Move FrameHost::m_subframeCount to Page (patchset #3 id:40001 of https://codereview.chromium.org/2739033003/ ) Reason for revert: Builders this step failed on: WebKit Linux Trusty Leak [2 since first detection] 2 tests failed: external/wpt/fullscreen/api/document-exit-fullscreen-nested-in-iframe-manual.html ( Code Search ) fast/forms/select/input-select-after-resize.html ( Code Search ) https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak Original issue's description: > Move FrameHost::m_subframeCount to Page > > Move the field FrameHost::m_subframeCount to Page, and update > FrameHost methods to directly call the equivalent Page method. > > BUG=691794 > > Review-Url: https://codereview.chromium.org/2739033003 > Cr-Commit-Position: refs/heads/master@{#456321} > Committed: https://chromium.googlesource.com/chromium/src/+/eb7ffe6561358b82498f885544ffdf50a5e46646 TBR=joelhockey@chromium.org,sashab@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691794 Review-Url: https://codereview.chromium.org/2746873002 Cr-Commit-Position: refs/heads/master@{#456334} [modify] https://crrev.com/214dd7fe513f8d06e76644c08db75fd8d3355d65/third_party/WebKit/Source/core/dom/NodeRareData.cpp [modify] https://crrev.com/214dd7fe513f8d06e76644c08db75fd8d3355d65/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/214dd7fe513f8d06e76644c08db75fd8d3355d65/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/214dd7fe513f8d06e76644c08db75fd8d3355d65/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp [modify] https://crrev.com/214dd7fe513f8d06e76644c08db75fd8d3355d65/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/214dd7fe513f8d06e76644c08db75fd8d3355d65/third_party/WebKit/Source/core/page/Page.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b97e7ff8b6cb77ac0a76f7b55863221fb8a395b commit 5b97e7ff8b6cb77ac0a76f7b55863221fb8a395b Author: skyostil <skyostil@chromium.org> Date: Mon Mar 13 14:03:34 2017 mac: Fix typo in header file name BUG=691794 TBR=haraken@chromium.org Review-Url: https://codereview.chromium.org/2743343002 Cr-Commit-Position: refs/heads/master@{#456369} [modify] https://crrev.com/5b97e7ff8b6cb77ac0a76f7b55863221fb8a395b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5076fed2c0cfaaac4357e93d4fc890a82f1e34b5 commit 5076fed2c0cfaaac4357e93d4fc890a82f1e34b5 Author: sashab <sashab@chromium.org> Date: Tue Mar 14 03:09:51 2017 Move FrameHost::m_globalRootScrollerController to Page Move the field FrameHost::m_globalRootScrollerController to Page, and update FrameHost methods to directly call the equivalent Page method. BUG=691794 Review-Url: https://codereview.chromium.org/2743523002 Cr-Commit-Position: refs/heads/master@{#456605} [modify] https://crrev.com/5076fed2c0cfaaac4357e93d4fc890a82f1e34b5/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/5076fed2c0cfaaac4357e93d4fc890a82f1e34b5/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/5076fed2c0cfaaac4357e93d4fc890a82f1e34b5/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/5076fed2c0cfaaac4357e93d4fc890a82f1e34b5/third_party/WebKit/Source/core/page/Page.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afc9aca51a79ce4007176b30b94e46399205e551 commit afc9aca51a79ce4007176b30b94e46399205e551 Author: sashab <sashab@chromium.org> Date: Tue Mar 14 06:01:36 2017 Remove FrameHost::globalRootScrollerController() Remove FrameHost::globalRootScrollerController(), and redirect all calls to Page::globalRootScrollerController(). BUG=691794 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2742673002 Cr-Commit-Position: refs/heads/master@{#456633} [modify] https://crrev.com/afc9aca51a79ce4007176b30b94e46399205e551/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/afc9aca51a79ce4007176b30b94e46399205e551/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/afc9aca51a79ce4007176b30b94e46399205e551/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/afc9aca51a79ce4007176b30b94e46399205e551/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/afc9aca51a79ce4007176b30b94e46399205e551/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/afc9aca51a79ce4007176b30b94e46399205e551/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp [modify] https://crrev.com/afc9aca51a79ce4007176b30b94e46399205e551/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp [modify] https://crrev.com/afc9aca51a79ce4007176b30b94e46399205e551/third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp [modify] https://crrev.com/afc9aca51a79ce4007176b30b94e46399205e551/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp [modify] https://crrev.com/afc9aca51a79ce4007176b30b94e46399205e551/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/afc9aca51a79ce4007176b30b94e46399205e551/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9ae71b54435ce738e3e7d3717a42183bbea811c commit d9ae71b54435ce738e3e7d3717a42183bbea811c Author: sashab <sashab@chromium.org> Date: Wed Mar 15 03:53:00 2017 Move FrameHost::m_consoleMessageStorage to Page Move the field FrameHost::m_consoleMessageStorage to Page, and update FrameHost methods to directly call the equivalent Page method. BUG=691794 Review-Url: https://codereview.chromium.org/2738703003 Cr-Commit-Position: refs/heads/master@{#456984} [modify] https://crrev.com/d9ae71b54435ce738e3e7d3717a42183bbea811c/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/d9ae71b54435ce738e3e7d3717a42183bbea811c/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/d9ae71b54435ce738e3e7d3717a42183bbea811c/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/d9ae71b54435ce738e3e7d3717a42183bbea811c/third_party/WebKit/Source/core/page/Page.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05e8c5485ad41543721a89009285d8b7feb9a6f4 commit 05e8c5485ad41543721a89009285d8b7feb9a6f4 Author: sashab <sashab@chromium.org> Date: Wed Mar 15 08:11:01 2017 Move m_overscrollController to Page Move m_overscrollController to Page from FrameHost. This is part of the work to remove FrameHost. BUG=691794 Review-Url: https://codereview.chromium.org/2729603005 Cr-Commit-Position: refs/heads/master@{#457029} [modify] https://crrev.com/05e8c5485ad41543721a89009285d8b7feb9a6f4/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/05e8c5485ad41543721a89009285d8b7feb9a6f4/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/05e8c5485ad41543721a89009285d8b7feb9a6f4/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/05e8c5485ad41543721a89009285d8b7feb9a6f4/third_party/WebKit/Source/core/page/Page.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3249af70be7a33e4c48f58bf9d415dae8575a9e5 commit 3249af70be7a33e4c48f58bf9d415dae8575a9e5 Author: sashab <sashab@chromium.org> Date: Thu Mar 16 01:59:01 2017 Remove FrameHost::consoleMessageStorage() methods Remove FrameHost::consoleMessageStorage() methods, since these can now call consoleMessageStorage() directly in Page. BUG=691794 Review-Url: https://codereview.chromium.org/2732113004 Cr-Commit-Position: refs/heads/master@{#457306} [modify] https://crrev.com/3249af70be7a33e4c48f58bf9d415dae8575a9e5/third_party/WebKit/Source/core/frame/FrameConsole.cpp [modify] https://crrev.com/3249af70be7a33e4c48f58bf9d415dae8575a9e5/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/3249af70be7a33e4c48f58bf9d415dae8575a9e5/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/3249af70be7a33e4c48f58bf9d415dae8575a9e5/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp [modify] https://crrev.com/3249af70be7a33e4c48f58bf9d415dae8575a9e5/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/3249af70be7a33e4c48f58bf9d415dae8575a9e5/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2879e8ebd796a5a459f0297624b284e32ec6ae9a commit 2879e8ebd796a5a459f0297624b284e32ec6ae9a Author: sashab <sashab@chromium.org> Date: Thu Mar 16 02:16:55 2017 Move FrameHost::m_subframeCount to Page Move the field FrameHost::m_subframeCount to Page, and update FrameHost methods to directly call the equivalent Page method. Reverted in https://codereview.chromium.org/2746873002/ due to failing WebKit Linux Trusty Leak, re-landing to see if error can be repro'd. TBR=haraken,joelhockey BUG=691794 Review-Url: https://codereview.chromium.org/2752543003 Cr-Commit-Position: refs/heads/master@{#457314} [modify] https://crrev.com/2879e8ebd796a5a459f0297624b284e32ec6ae9a/third_party/WebKit/Source/core/dom/NodeRareData.cpp [modify] https://crrev.com/2879e8ebd796a5a459f0297624b284e32ec6ae9a/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/2879e8ebd796a5a459f0297624b284e32ec6ae9a/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/2879e8ebd796a5a459f0297624b284e32ec6ae9a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp [modify] https://crrev.com/2879e8ebd796a5a459f0297624b284e32ec6ae9a/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/2879e8ebd796a5a459f0297624b284e32ec6ae9a/third_party/WebKit/Source/core/page/Page.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92d0ed2d9d9afaf4a3ddd0e9a5b9c773b9dff3a0 commit 92d0ed2d9d9afaf4a3ddd0e9a5b9c773b9dff3a0 Author: sashab <sashab@chromium.org> Date: Fri Mar 17 03:10:20 2017 Remove FrameHost::overscrollController() methods Remove FrameHost::overscrollController() methods, since these can now call overscrollController() directly in Page. BUG=691794 Review-Url: https://codereview.chromium.org/2730313002 Cr-Commit-Position: refs/heads/master@{#457670} [modify] https://crrev.com/92d0ed2d9d9afaf4a3ddd0e9a5b9c773b9dff3a0/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/92d0ed2d9d9afaf4a3ddd0e9a5b9c773b9dff3a0/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/92d0ed2d9d9afaf4a3ddd0e9a5b9c773b9dff3a0/third_party/WebKit/Source/core/input/ScrollManager.cpp [modify] https://crrev.com/92d0ed2d9d9afaf4a3ddd0e9a5b9c773b9dff3a0/third_party/WebKit/Source/core/input/ScrollManager.h [modify] https://crrev.com/92d0ed2d9d9afaf4a3ddd0e9a5b9c773b9dff3a0/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89a1877418ea6acbc9521be4bb8071356dcb41e3 commit 89a1877418ea6acbc9521be4bb8071356dcb41e3 Author: sashab <sashab@chromium.org> Date: Fri Mar 17 07:13:56 2017 Remove FrameHost::subFrameCount() Remove FrameHost::subFrameCount(), incrementSubframeCount() and decrementSubframeCount(), and redirect all calls to Page. BUG=691794 Review-Url: https://codereview.chromium.org/2737243003 Cr-Commit-Position: refs/heads/master@{#457707} [modify] https://crrev.com/89a1877418ea6acbc9521be4bb8071356dcb41e3/third_party/WebKit/Source/core/frame/FrameHost.cpp [modify] https://crrev.com/89a1877418ea6acbc9521be4bb8071356dcb41e3/third_party/WebKit/Source/core/frame/FrameHost.h [modify] https://crrev.com/89a1877418ea6acbc9521be4bb8071356dcb41e3/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp [modify] https://crrev.com/89a1877418ea6acbc9521be4bb8071356dcb41e3/third_party/WebKit/Source/web/WebFrame.cpp
Seems like sashab is working on this, updating status.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bf5669767a63f7e1d851c953e949f9e740aaf64 commit 1bf5669767a63f7e1d851c953e949f9e740aaf64 Author: nverne <nverne@chromium.org> Date: Tue May 30 06:48:27 2017 Moves CompositorMutatorImpl from web/ to core/animation. Next we can move AnimationWorkletProxyClientImpl. Bug: chromium:691794 Change-Id: Ib3a09aab2eb155fc9d37e6240439e6d8df9bafc2 Reviewed-on: https://chromium-review.googlesource.com/516904 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#475445} [modify] https://crrev.com/1bf5669767a63f7e1d851c953e949f9e740aaf64/third_party/WebKit/Source/core/animation/BUILD.gn [rename] https://crrev.com/1bf5669767a63f7e1d851c953e949f9e740aaf64/third_party/WebKit/Source/core/animation/CompositorAnimator.h [rename] https://crrev.com/1bf5669767a63f7e1d851c953e949f9e740aaf64/third_party/WebKit/Source/core/animation/CompositorMutatorImpl.cpp [rename] https://crrev.com/1bf5669767a63f7e1d851c953e949f9e740aaf64/third_party/WebKit/Source/core/animation/CompositorMutatorImpl.h [modify] https://crrev.com/1bf5669767a63f7e1d851c953e949f9e740aaf64/third_party/WebKit/Source/platform/graphics/CompositorMutator.h [modify] https://crrev.com/1bf5669767a63f7e1d851c953e949f9e740aaf64/third_party/WebKit/Source/web/AnimationWorkletProxyClientImpl.cpp [modify] https://crrev.com/1bf5669767a63f7e1d851c953e949f9e740aaf64/third_party/WebKit/Source/web/AnimationWorkletProxyClientImpl.h [modify] https://crrev.com/1bf5669767a63f7e1d851c953e949f9e740aaf64/third_party/WebKit/Source/web/BUILD.gn [modify] https://crrev.com/1bf5669767a63f7e1d851c953e949f9e740aaf64/third_party/WebKit/Source/web/CompositorWorkerProxyClientImpl.cpp [modify] https://crrev.com/1bf5669767a63f7e1d851c953e949f9e740aaf64/third_party/WebKit/Source/web/CompositorWorkerProxyClientImpl.h [modify] https://crrev.com/1bf5669767a63f7e1d851c953e949f9e740aaf64/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp [modify] https://crrev.com/1bf5669767a63f7e1d851c953e949f9e740aaf64/third_party/WebKit/Source/web/WebFrameWidgetImpl.h [modify] https://crrev.com/1bf5669767a63f7e1d851c953e949f9e740aaf64/third_party/WebKit/Source/web/WebViewImpl.cpp
Comment 1 by dcheng@chromium.org
, Feb 13 2017