New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691783 link

Starred by 15 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

[MD settings] Can't select text on MD settings

Project Member Reported by nparker@chromium.org, Feb 13 2017

Issue description

The chrome://settings on dev (58.0.3004.3, linux) doesn't let me select text. This makes it hard for a user to do a Google search for the text to learn more about it.

Also, CTRL-F doesn't actually search in the page.
 
Uploaded a CL to allow text selection in Settings UI : https://codereview.chromium.org/2904783003/
Labels: Proj-MaterialDesign-WebUI
Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)
Summary: [MD settings] Can't select text on MD settings (was: Can't select text on MD settings)
Alan, is it okay to select the UI text in the MD settings? (I'm good with it. I just wanted to check with you before LG'ing the CL).

Comment 3 by dpa...@chromium.org, Jun 12 2017

Labels: Hotlist-MD-Settings-General

Comment 4 by bettes@chromium.org, Jun 15 2017

Owner: dschuyler@chromium.org
I'm good with it too!
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0721d307c2e650409d287b02ddeeed4d1635b086

commit 0721d307c2e650409d287b02ddeeed4d1635b086
Author: gajendra.n <gajendra.n@samsung.com>
Date: Fri Jun 16 07:36:48 2017

Allow user to select text in Settings UI

This lets user to do a Google search for the text to learn more about it.
The old Settings UI as well allowed the text to be selected.

BUG= 691783 
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2904783003
Cr-Commit-Position: refs/heads/master@{#479982}

[modify] https://crrev.com/0721d307c2e650409d287b02ddeeed4d1635b086/chrome/browser/resources/settings/settings_ui/settings_ui.html

Status: Fixed (was: Assigned)
Fixed by gajendra.n@samsung.com.
Labels: TE-Verified-M61 TE-Verified-61.0.3135.4
Tested the fix on Ubuntu 14.04 using chrome version 61.0.3135.4.Able to select the text in chrome://settings page.
Please find the attached screen cast for the same.

Adding TE-Verified labels.

Thanks,

691783.ogv
1.5 MB View Download

Comment 8 by dpa...@chromium.org, Jul 13 2017

 Issue 742446  has been merged into this issue.

Comment 9 by dpa...@chromium.org, Jul 27 2017

Cc: durga.behera@chromium.org dschuyler@chromium.org brajkumar@chromium.org ajha@chromium.org kavvaru@chromium.org tbuck...@chromium.org dbeam@chromium.org
 Issue 622092  has been merged into this issue.

Sign in to add a comment